From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD11040313D for ; Fri, 5 Jun 2026 06:15:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780640154; cv=none; b=D+scq2ncnKJQisTdSneprKrpOHTW3wEvklFYUejp3iLPhWZbcoddeszMCot5qwLgASnPoI4iXrYjGhM6g9YaOxWQJTwk4pU8lBSy2rQMcBmhzKPi/2LPN1eWVQdcEHq+ElrvxWw/dmjMxieskQbDEyHsuKFbF0qy+V3UoLlwi+o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780640154; c=relaxed/simple; bh=pSy7JRWjdIKY9QJsH/r9lB8u5WNj2J0RqLxTKweYghc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n2pDVGIhEpyRUoSfIKFIBA9EEoDJ2050FnRcpfzPTvAEK6LZzcHBrjiF12NdZD6IokyUmnOkUAmzW5Ly1n8g2CLV6Yn1Qv+RWIEn/RQjFtZwQyx4Cwh7VpTzhSssPp+XGAfZSGZzqcjDKa7it7ByOfpjhqyt7gRRt8zHlzIOC1g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aoGQOPX1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZT5lN+qV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aoGQOPX1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZT5lN+qV" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6551UilD1957488 for ; Fri, 5 Jun 2026 06:15:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xTVXLo0+IK26zLaAI6u3FwvMuaye+UwKCeJIu/67bic=; b=aoGQOPX1CZXa7kHv bvzNtNdlHxUuNyGwkoxPhmpRyiJoRvM4UtSLVM20rj1rRcnGezPSE0+9GrD1IzQX dw80ZRT9Cey98emJkUZXIFj7bhqffId2p1/ofZ0A9QUTYViImSnjCjWdOLnw3gx+ LUWo4wGOsUpnL8fvoSxVqU3lGixLw+ODbYhbIY6ujCqLFEVVY/Fv5M2xRGKLQESl Fz+Oo4CseqCJuTph7VDspTOf/4LiaPBaeU0gAoKQhgTeSzdfSBSOEaF1ZXQ1omgz 2dED5I7D0IesJHGfM9IAK92hakDDUXN8ont5a+/yxqzKM1nkJVmpLn7UYv1wa1fM AnTwqg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ekckpu5cf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 05 Jun 2026 06:15:47 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2c0c36f4b76so16435015ad.3 for ; Thu, 04 Jun 2026 23:15:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780640146; x=1781244946; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xTVXLo0+IK26zLaAI6u3FwvMuaye+UwKCeJIu/67bic=; b=ZT5lN+qVLkFZUFqt3XDn6Aa3IgJ9a3D6GX/q2C/Q3LGSXkgmdcBEYx9VupVLVRjA+3 LesOL+3QFsyqUwBEZnLvhIFJZdEIGKdLe2MzeZ5vcF/X4uCyCWPKGUZ7l4X+7fG2J4lT rwnt1wyBPNqE4lBsiJTBbIu3clABbI9U309hCZxgKnGoHaQuHHmkglVZAhT+wjWEoi4f iyG7cRGsjxQlvOOAriepohmA/foKgQ7XdTPaQOrlgsOrkPSZhmHqfMNP+3XTCusH0Kiw YY79qHR/60UY7k+aQu/nag+TNh0R0Og9U2avtHWQuPog1kFw2r+AXSQHK2MIOClCRMuN DPIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780640146; x=1781244946; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xTVXLo0+IK26zLaAI6u3FwvMuaye+UwKCeJIu/67bic=; b=Hh2MbMyZ7TcRG/9kgddFfVQA7pgMO58yRDK2Vd/d1KarfmIaUvHFqqRBN7fltkGNMy GemnOlHSr71gVYEhaKohXE6NhajpCzDZyR73qPOp2Or06ddLtIVVTC2KpwmWlpmjjzeF 3bu7efz5nt9hMDNwwDhmo+bQaidZI3kYtGKnG8mdBp5ssoP08xW5i6Rhy8tych2pLwDc UMyaEHId1tgE4NZRyWvD3rivWnvuqN1GmObxJHWdGPQy7EHb+mcZjlBUtfmJ8Vf2oHYW 4IhzKcgOQK2o5SftcRTDuU9y6Z+qVb1rLZeggurNXtoO0nMQxlxWc9uMc/61OfGa1o35 IEQw== X-Forwarded-Encrypted: i=1; AFNElJ92BV4knsGiSsnXa3kC/X38RL2KEnlxGuwLu2Gw2c79337M7pAR3QwZ+KLeeVZSQfcd/lmjBiKfRV2NLyw=@vger.kernel.org X-Gm-Message-State: AOJu0YxrXVn61m9iAuLMu30hjns59CICDC5Xge6zoRHVGyHKIM/ar2So 9+baJhCetAoko8g1mfz11JIrT1WOzA+CXMvOIM3G7WfOjRHIoNsd55uYJL4Cs6rKjHKLR7yEAOy cwBWdoODy149kwdFKRKVkGXgDlIf6Pj1MiHlxjXw6lzs/ue3yOO0cjM/EeI+pRlaCfwc= X-Gm-Gg: Acq92OGslH3MY2pX3/O/8rvhocTUXD5DcOkClKgTIykCdp1xF6CizkTMeBcuuI2gllk 9Cg4Mw/LJBiXYdRccrMNnIoucIsZ8aDUtCn8pG7wg3n/9C2sQfm+3653xK+1rdwcFjYjRgp3utw 86LNMpMRFyZWrm1ZYqz7eYpdD/dLH6c8QuSj2QIC4ww+PAdNBxwdiSsXdkjS7TfErcOz9N0gZoY u9hJTt7H3vRRBLe10hOhNsh77cKr9EIOa4hwo3ce85IelUXQAkH1ikb3xb/WKEbU1/vJ9RGqg+b BBHrNDeDv6lgWL048Wz6UlrlX/dR2du06nyrcoDuGe4RdClmwRr9uZqXv2rvsfDBCJGguEpKMNn m11mHDeKZgqNROISSNXCDCIC41Ixatey26xCn6zgcIjNOKdum9YOlbRWujN3NiI/+utc/Bul7no 452RllWW1et44C/R5C0JdJ X-Received: by 2002:a17:903:1246:b0:2c0:ccdb:e023 with SMTP id d9443c01a7336-2c1e83451a5mr21420315ad.17.1780640146460; Thu, 04 Jun 2026 23:15:46 -0700 (PDT) X-Received: by 2002:a17:903:1246:b0:2c0:ccdb:e023 with SMTP id d9443c01a7336-2c1e83451a5mr21419945ad.17.1780640145970; Thu, 04 Jun 2026 23:15:45 -0700 (PDT) Received: from [10.133.33.77] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164fa00b3sm75603275ad.32.2026.06.04.23.15.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2026 23:15:45 -0700 (PDT) Message-ID: Date: Fri, 5 Jun 2026 14:15:41 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] spmi: pmic-arb: Fix OF node leak in spmi_pmic_arb_register_buses() To: Fenglin Wu , linux-arm-msm@vger.kernel.org, Stephen Boyd , Neil Armstrong , Abel Vesa , Greg Kroah-Hartman Cc: David Collins , Subbaraman Narayanamurthy , Kamal Wadhwa , kernel@oss.qualcomm.com, linux-kernel@vger.kernel.org References: <20260604-spmi-bus-register-fix-v1-1-136adda83a92@oss.qualcomm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <20260604-spmi-bus-register-fix-v1-1-136adda83a92@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: pg9XQYvu2u-3hZZIM6biU4om04UMTDzU X-Proofpoint-ORIG-GUID: pg9XQYvu2u-3hZZIM6biU4om04UMTDzU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA1MDA1NyBTYWx0ZWRfX5GA4nl0w8RFr 4b1sYk0wJwQJwDGnXbc/h/4W+T4X55iQF5rFiObhoi/HBCL0Wj2owWFlxpQkT6IIAIy/BrP2qqA dgwfc6KFxTett2J7/bSjq3soEVrf4b4fcX/Bizqhft8vIAxEMQfRvDaTk+Xdv5kJlqu467nmvxS o5/UZDfy6iaoS1nMtJ5EFrT28a5vG33akhKDeIdOi25X2xvEY6tX7NQEOsB4K2WdmtTF+v+gBE/ waIw2/jhiCiqGr0+8KSuk7wMSkC/yPA+5N0QcoCUO90qptQGm8rWtWPXbw9wttOKPT6B42ipTjv nY876XVBZJmgJfYHnzqnRGIsz6IVNO71swy4dFKix1a+g5mYvIk57ZdbdkRIOEGEx49/+KprnO5 hpIXj/aW87S1NthfqhVxflcVNEAFmHJ/EVpgR2qrVEz07rxQTQDIlA/zzILy+VolxEJhfRXZflT QznOrnZuwSTfI1g0b1g== X-Authority-Analysis: v=2.4 cv=H9jrBeYi c=1 sm=1 tr=0 ts=6a226993 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=_5OF2q1O2MIjwZNLnQYA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-04_07,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 adultscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606050057 On 6/5/2026 1:46 PM, Fenglin Wu wrote: > Call of_node_put(child) to reduce its reference count when > bailing out from the for_each_available_child_of_node() loop > upon an error in bus registration. > > Also, return 0 directly if there are no errors in bus > registration. > > Fixes: 979987371739 ("spmi: pmic-arb: Add multi bus support") > Signed-off-by: Fenglin Wu > --- > drivers/spmi/spmi-pmic-arb.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c > index 2e2cb4774103..26e804ad95a1 100644 > --- a/drivers/spmi/spmi-pmic-arb.c > +++ b/drivers/spmi/spmi-pmic-arb.c > @@ -2055,12 +2055,14 @@ static int spmi_pmic_arb_register_buses(struct spmi_pmic_arb *pmic_arb, > for_each_available_child_of_node_scoped(node, child) { > if (of_node_name_eq(child, "spmi")) { > ret = spmi_pmic_arb_bus_init(pdev, child, pmic_arb); > - if (ret) > + if (ret) { > + of_node_put(child); We dont need of_node_put here. The for_each_available_child_of_node_scoped will handle the refcnt automatically. Thanks, Jie > return ret; > + } > } > } > > - return ret; > + return 0; > } > > static void spmi_pmic_arb_deregister_buses(struct spmi_pmic_arb *pmic_arb) > > --- > base-commit: 3443eec9c55d128064c83225a9111f1a1a37277a > change-id: 20260604-spmi-bus-register-fix-dfdb94bf834e > > Best regards, > -- > Fenglin Wu >