From: Nikolay Aleksandrov <razor@blackwall.org>
To: Yang Yingliang <yangyingliang@huawei.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: den@openvz.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org
Subject: Re: [PATCH net v2 RESEND] net: neigh: don't call kfree_skb() under spin_lock_irqsave()
Date: Mon, 22 Aug 2022 10:49:55 +0300 [thread overview]
Message-ID: <b41b5065-c012-3b3a-2980-3eba25e0a071@blackwall.org> (raw)
In-Reply-To: <20220822025346.3758558-1-yangyingliang@huawei.com>
On 22/08/2022 05:53, Yang Yingliang wrote:
> It is not allowed to call kfree_skb() from hardware interrupt
> context or with interrupts being disabled. So add all skb to
> a tmp list, then free them after spin_unlock_irqrestore() at
> once.
>
> Fixes: 66ba215cb513 ("neigh: fix possible DoS due to net iface start/stop loop")
> Suggested-by: Denis V. Lunev <den@openvz.org>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> v2:
> move all skb to a tmp list, then free them after spin_unlock_irqrestore().
> ---
> net/core/neighbour.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
LGTM,
Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
next prev parent reply other threads:[~2022-08-22 7:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 2:53 Yang Yingliang
2022-08-22 7:49 ` Nikolay Aleksandrov [this message]
2022-08-24 9:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b41b5065-c012-3b3a-2980-3eba25e0a071@blackwall.org \
--to=razor@blackwall.org \
--cc=davem@davemloft.net \
--cc=den@openvz.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®