From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 603C1C433E0 for ; Wed, 17 Jun 2020 14:36:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43D7E20776 for ; Wed, 17 Jun 2020 14:36:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726854AbgFQOgF (ORCPT ); Wed, 17 Jun 2020 10:36:05 -0400 Received: from foss.arm.com ([217.140.110.172]:58942 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725894AbgFQOgE (ORCPT ); Wed, 17 Jun 2020 10:36:04 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 579F231B; Wed, 17 Jun 2020 07:36:04 -0700 (PDT) Received: from [192.168.1.84] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3BBAE3F73C; Wed, 17 Jun 2020 07:36:03 -0700 (PDT) Subject: Re: [PATCH v3] drm/panfrost: Reduce the amount of logs on deferred probe To: Krzysztof Kozlowski , Rob Herring , Tomeu Vizoso Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Alyssa Rosenzweig References: <20200527200544.7849-1-krzk@kernel.org> <20200527204334.GA15485@kevin> <20200617141547.GA30516@kozik-lap> From: Steven Price Message-ID: Date: Wed, 17 Jun 2020 15:35:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200617141547.GA30516@kozik-lap> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/06/2020 15:15, Krzysztof Kozlowski wrote: > On Wed, May 27, 2020 at 04:43:34PM -0400, Alyssa Rosenzweig wrote: >> Reviewed-by: Alyssa Rosenzweig >> >> On Wed, May 27, 2020 at 10:05:44PM +0200, Krzysztof Kozlowski wrote: >>> There is no point to print deferred probe (and its failures to get >>> resources) as an error. Also there is no need to print regulator errors >>> twice. >>> >>> In case of multiple probe tries this would pollute the dmesg. >>> >>> Signed-off-by: Krzysztof Kozlowski >>> Reviewed-by: Steven Price >>> >>> --- >>> >>> Changes since v2: >>> 1. Rebase >>> 2. Add Steven's review >>> >>> Changes since v1: >>> 1. Remove second error message from calling panfrost_regulator_init() >>> --- >>> drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> > > Hi Rob, Tomeu and Steven, > > You're listed as maintainers for panfrost. Is anyone going to pick this > up? I'm only a reviewer so I've been leaving it for Rob or Tomeu, but I can pick it up if Rob/Tomeu are happy for me to do that. > Maybe I sent it to wrong mailing list or forgot about anything? No, there's actually a few Panfrost commits waiting, it was on my todo list to ask if Rob/Tomeu needed some help with merging patches. Steve