From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2F963AEF5B for ; Wed, 25 Feb 2026 13:25:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772025950; cv=none; b=JkDwEl9GiSuhGXFZyqbAIlxdr6uGCMBviTGRAnTC9Y/mmOwbB6697NjZHVKw28VlBU5hC+i61G/4u5W/gAeRPH/UlQH9kMR0I7shsKZ13lZ4ReD+FMXlJL0qg9q56X7Ct8XKP3s4Sfdj6hQG1kLNU1bzs4Pyvm2brGiQkkrU07k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772025950; c=relaxed/simple; bh=QBnGQRhjPCgFqzWG1srroUfv1xQs2zaYDV82nxKh1sI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=r3vnsWZoXPvakv4TElA9VTmkNYiRkjcMTOCpNQoSVVmx397MvRIW4RP8u799Bq79OWuo5iFgxZDVUaz0bqmxXTKS+gEypJTsuL4STwAjujAtOmEc14X/+8XdoLJs6W765AS35bmG70Jm5GcLaddhiD/yLibn1AP4e0Ff8ukKAeA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FlNLDDHM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PAUwjwYP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FlNLDDHM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PAUwjwYP" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61P9SCCZ806549 for ; Wed, 25 Feb 2026 13:25:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dl070totApNxtzNfs2Ht2ITbl3V+CGxeE7SKwvt2uYU=; b=FlNLDDHMuGJUk4NU cPrhaHevuB3AZSH6Oweq10Ppn/ZaskuaGRetf0Ml0q9GlCgixCNfh/OzXuzJZSKI rOyeFuRozAzmI6ly4cBa6s0tQV3zFd5mqrCBZMl4hGXoomVY38crIlSYniPfFjTj XL4/VZWRqKcNOUne9yBSlBS2A18P+bFODs3/3zn1yqjtvUQ2tv3BZqo3zZPAGJed xjv4dx7ht6ssRxE3KLuwukH6IpULQA7EoACaXDw0EQZ+x6F1QEkr2z6pB+FAbBQw qqJJyI+1nMYVUZOYEMcUgEJpxIXT0pepvwnQoTVSvkkmhtIpNElzGwKN4ZzeATt7 D+Bj1w== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4chr5p9qpy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Feb 2026 13:25:48 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c6fd07933aaso3920291a12.0 for ; Wed, 25 Feb 2026 05:25:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772025947; x=1772630747; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dl070totApNxtzNfs2Ht2ITbl3V+CGxeE7SKwvt2uYU=; b=PAUwjwYPIrewhgOc9sQJh4nzsJy4g+6T4oY0+QycBnOIXl4qT53xbspdZNlZxLbw3k aSkzWZN6jLnYw+yZc7wdGZBy9ABDj1ETL/tgMQSzCdF/Ds65f2papA0EX2SJwYOloHJJ Bi8rbb2jurgTu9m1B+cG4Hx9LiKDjHUj4lxKVyEnMJQys8Yf3N/LmhRW7EQvJP3BG4Rx G2yGxR6SScXmh/dxexJIkJ9CSz232jcGwHbTqw9yZaF6r5AsasJeSHU9039ZOrLlRurr RrFgIX9X0EmfyHil0BlevC4GS5zdxEROXo88LN+JS+a/Vgda4MsqsHSPkW+Drzbp6SU1 QrNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772025947; x=1772630747; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dl070totApNxtzNfs2Ht2ITbl3V+CGxeE7SKwvt2uYU=; b=qlgBVd7pfI2dcfcYWfvMql3eb9O6GfEc7T7LYVf//kp9YI98iDXf4kHQw9j5xBgc4j j/+7KyJhgFQZEsWwSbpfMsJHUlPfBtcDYjUZqJ4D/nXeDSPZ9Kvq7nclOrIxmgBpyC0p BY9KnfkJ8x4GEFnJ8zpltGqqTLlZrs/pbxOfrm8prwcsAkdkiThf9jELyut0UO+Kf9pd ega+aJ3HSp8bkRIlg71HbYY50h2wzJshKIRtPgOixx/nsA5eHjgTrYDIV32L1O5q7nBz kbPHU4Xnq8FEYBOOSxZiVqKbixOb0/0XfZpBDcAsWknJlRSSxAUTPY3/cprQxiy6cmn4 vbuQ== X-Forwarded-Encrypted: i=1; AJvYcCWCEF8KagBo+9J1kmqSYcYYyAX2ns6/4p68HTR/5NagGKMDyEp7JIV70ZHCLs/HO9ieoNZDJMRlnP38/6o=@vger.kernel.org X-Gm-Message-State: AOJu0Yyek5cjr+6NScaRckE6/+0y2Oh0q6IpXUlLKJlCPiOt8uRyTxAj H5IcF3sSByAGceBohN/ykjCQQa9KRIbvVPu4dzmVa1HqZOS+ojXZBjCuwXFeJE4zThJJv9yv7Hv UgO1/innBk3K0WU9ERA8yrhzBd/+29cZRwWtUdScoMMLPrFwBwWn+WaCAia5hdPdzdaE= X-Gm-Gg: ATEYQzwq276qXzLNPT4RWhPAYq1vu1lt+4smTrfF3TDE6sr+Hzs52C3aTtvNzpML0Sr J6pF6Zr29ugm4bIFn2eGhHt/QsTmOxhFDhRQcP/W8MuqRXpSKbPbES6rivwYdxh2GNz5H040Iil OFg/00z78AQm3VsR510A8bgF3dM1+8A7e+018F/vw73eg8rNS3bPcEnxNP3KLb2WEnx44zzwC3r ls44MhIP9U0zLvl42lPIos+xdwryGFcetIFMVaLkd+JXl8wnmzIYK+V5xmYeKTzfFaz3blZfmyv 9TpDBccBR7uCyf9BOoQWDz+WLQt/ir9mPSHsLG3HpqMCLwL9l9FE7Gur1a1qMTHzw7/R3ey5z31 dvbmIwPOvWmYHoIE0yI6kXu9W0q0vSQn5769WnNiEkosQTv6C0g6CiU8attn9D+y9 X-Received: by 2002:a05:6a00:885:b0:81f:477d:58db with SMTP id d2e1a72fcca58-826daa0cddfmr16888227b3a.39.1772025947509; Wed, 25 Feb 2026 05:25:47 -0800 (PST) X-Received: by 2002:a05:6a00:885:b0:81f:477d:58db with SMTP id d2e1a72fcca58-826daa0cddfmr16888200b3a.39.1772025946950; Wed, 25 Feb 2026 05:25:46 -0800 (PST) Received: from [192.168.1.7] ([122.164.81.73]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-826dd8a1145sm13438814b3a.45.2026.02.25.05.25.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Feb 2026 05:25:46 -0800 (PST) Message-ID: Date: Wed, 25 Feb 2026 18:55:40 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 4/5] watchdog: qcom: add support to get the bootstatus from IMEM To: Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Wim Van Sebroeck , Guenter Roeck , Rajendra Nayak Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org References: <20260225-wdt_reset_reason-v7-0-65d5b7e3e1eb@oss.qualcomm.com> <20260225-wdt_reset_reason-v7-4-65d5b7e3e1eb@oss.qualcomm.com> <1a28d203-e0ee-4c0d-a6ac-7f50ab26bdeb@oss.qualcomm.com> Content-Language: en-US From: Kathiravan Thirumoorthy In-Reply-To: <1a28d203-e0ee-4c0d-a6ac-7f50ab26bdeb@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI1MDEyOSBTYWx0ZWRfX8NJ1AmSeSDYt AvNQWtIYab+K7A2SGs45a0QWSsKfB+SsNV0s/wmDm4iLOvd6rCANNgFZdfrDWg6alTo8560Rsej JOM7xfBAmS0fbm61KDu5WAXfdYXPj2onaxOYSKZYDOcn0hEyt1urLKjXjl6UVDL5BuO7O0dheL0 SWS28KrWGYvoLdAuXkc3ELj5ib5RVKqFij+5OPCCbsePcpvD770c5bhFXSlGdJTSkmu32b/CIIc /WHzABHxgSjp8KjGiTwNXso+TcmK8aGuuvvvY4XOTyspBdnmJwKTfO4vh0J3gkopfVuOP4pfvRl IVQCPh2OG/B1qiMPc0tO3Ck9yX8c3XXNVplDaU0oOidnarrNPTjecMoycyzQT8izlhJWHk52QV2 FtbVCJOnXe1vdLy/3NgyCxBs4lqg2nm6fTDWqCcO97IEsyKgGJ0E91+eifOakF5hkwtzoufvjW5 +dtv4oXi132/wY2veSg== X-Authority-Analysis: v=2.4 cv=GstPO01C c=1 sm=1 tr=0 ts=699ef85c cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=mNPf3JdYh40LbGEelsvk6A==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=wjWkyli7g8A6NY-DO1gA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-GUID: PURWK1qBlVqDANduJxE331Ri2AzY5B9B X-Proofpoint-ORIG-GUID: PURWK1qBlVqDANduJxE331Ri2AzY5B9B X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-25_01,2026-02-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602250129 On 2/25/2026 6:11 PM, Konrad Dybcio wrote: > On 2/25/26 7:43 AM, Kathiravan Thirumoorthy wrote: >> When the system boots up after a watchdog reset, the EXPIRED_STATUS bit >> in the WDT_STS register is cleared. To identify if the system was >> restarted due to WDT expiry, XBL update the information in the IMEM region. >> Update the driver to read the restart reason from IMEM and populate the >> bootstatus accordingly. >> >> With the CONFIG_WATCHDOG_SYSFS enabled, user can extract the information >> as below: >> >> cat /sys/devices/platform/soc@0/f410000.watchdog/watchdog/watchdog0/bootstatus >> 32 >> >> For backward compatibility, keep the EXPIRED_STATUS bit check. Add a new >> function qcom_wdt_get_bootstatus() to read the restart reason from >> IMEM. >> >> Signed-off-by: Kathiravan Thirumoorthy >> --- > [...] > >> +static int qcom_wdt_get_bootstatus(struct device *dev, struct qcom_wdt *wdt, >> + u32 val) >> +{ >> + struct device_node *imem; >> + struct resource res; >> + void __iomem *addr; >> + int ret; >> + >> + imem = of_parse_phandle(dev->of_node, "sram", 0); >> + if (!imem) { >> + >> + /* Fallback to the existing check */ > Odd \n above > > 'existing' is imprecise, perhaps something like > > /* Read the EXPIRED_STATUS bit as a fallback */ Thanks, will update the comment as above in next spin. > > lg otherwise > > Reviewed-by: Konrad Dybcio > > Konrad