From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751871AbdBATJv (ORCPT ); Wed, 1 Feb 2017 14:09:51 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:37750 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751736AbdBATJr (ORCPT ); Wed, 1 Feb 2017 14:09:47 -0500 Subject: Re: [PATCH V2 1/3] blk-mq: allocate blk_mq_tags and requests in correct node To: Shaohua Li , , References: CC: , From: Jens Axboe Message-ID: Date: Wed, 1 Feb 2017 11:09:36 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c090:200::1:95ad] X-ClientProxiedBy: CY1PR17CA0004.namprd17.prod.outlook.com (10.163.68.14) To DM5PR15MB1195.namprd15.prod.outlook.com (10.173.209.13) X-MS-Office365-Filtering-Correlation-Id: 774c186b-2d25-4b83-00c3-08d44ad5dfe0 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DM5PR15MB1195; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1195;3:mnG3O43fEbx4Tbr1ezui1Eh8MHwktfnb2baDQjrw0tovbQ5QgxWDLCYE3I0dEmlv+NYyD8kSryClMt5sMStB1AtS8FStEkybNMWqxi2fYVU5x2wN7rs8jHP31ovDSj4CBC4WRdHSinCd0x3qyFq/QteqXfntzqUkQ0+pEeD3wk3Muk+DbDwiOZNkHUME28ppdSEXkibboOXxUhB9sJw4uQAk2f4tDVJnOPtL2PrIiqY/gpZE5Oa4BJxsuIjnJn4U52n+btHL9PDnFKk2eZQmFw== X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1195;25:CBdLv15Nrlk6ZYMQKgnGzI+AaW+aNCSFA+7niQtBK0M9/o80LVrM5n36lJBTTk7IrekDRVF1aShbgTVMOZmc+g4wQxt1/uM3i9nvPVQhRr62MWb8l4Dga8R73cEomszWTh1ICjHaew2qsj4M86cm7OnVg0JoRDmWnk12KE4C7E0BOSVzlkIvJ1dhwuD2Xl011UXpTi6J2BOizerQibn48VQv68oXv78CznP/HVO0vAI0BlowLdB76rHkfq4YiPaqMZN0JrEb5e/03XZgFOcH/QbvJl2E+HlbFn5LZELCHP8Hn2xC+0YBZwvD3EcBPhlFMKuZGX1xbWMBiLwwDP3U0ZMK6QjwvOZGmzFn9qbbFceuNpkP+KGgfmM5Gx5PAgDYsBsbxjZxVf5Skz+uF8Ss4ruPBLNbbFKX1h1mn5/9wZsewJpRQjeO+iKSINtNEOSyHmkz4clEWJeEJc3lmxWaTzKi/8xMsJvppg3SOKfvKU3j+//mbsE+zGTpiZ/rmsthYEn+diullu1K8+KmBOflnrD1vjUyWK+jC0q9wpIsp3tEt7s7C4iIRXSGRQkmzoirDrwqqIT6kLdNmfauCcUOIvJ/mQY1u/V1xAd6fhLEp8gNQC+qgxWGg87ns30Q7o21sUn3ZccdZEyT1MS5cPJkPpddDGCdAeLiRZpcxHwoLcCIsYf4ilirBjwuvCXwEclI X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1195;31:W3fxGvTdn0KHulqrRB+Blqt2RzkMeoMVDP7091GRscxicxCPySCUCbZ41Mu+e78ob6gZXLjhg8N4OAQjM8QhdziAhIeoAa6uIcs4E5zIQrbPX5PjbtSSmnZS4j4QG5umhvrBHulE+eQAa/kKeZuRSHk+KFZIbWUh/SWSaatl1KLTqOQud6TpLx8YkM/iDnzfLnBy7+fyjHvN/9iCrN3d6Z5fErHYng0e0WeD2QF3EE/UhLrOoqeGMw0HH7cluglfK+6LpboNqfT+tGwQ/MenWg==;20:KrpmGRaGGNSvBaAL+kOie1g/6kYJPhhaVj/TPm6sZ1dXhM8n0uzL1isJx0lDtcQLpQCEBNPiAa2MSUBBO/Ot9EtjTu/nFXOCEau+xbcXelsiMKO52iqhEhH9iql965aI8JctWjfM/GNaOBZoPJ7flsnkOrLI+1bmA1df6GqWb8hhiLWu4A6/+/YBkny+KH0YAq2SLkzihPzbKFryzxcENtjMs/I13IA2EOB+JnbMXYAdybB48aqEot70OQnLxiOycaNyyOJF0eOQL+H3tk0AqwLx2pn9Bvzrqomk43GkRVQpaD1mdv5fH8ferSjm6qcI9cP41NIqG5yDv5+E8qcLDHp5v8GAaHqvZo41SM9gw4c2bLtUEMX5GQegPtkDJMt6LaUwX/mxRz7/TKBOlntcw0Ob/vE+J7H+t4MNdSx5Y7X73vNdHh93GrCrjdERdP+8JW8so/sXet48L4Sr3ytDL++P6gq6n/sjFBKQaiXD2Q5QdxchUDJPZ+o3eg0Xc0s2 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123558025)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(6072148);SRVR:DM5PR15MB1195;BCL:0;PCL:0;RULEID:;SRVR:DM5PR15MB1195; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1195;4:tKfBr+IkiBPmMfQlNKAg/VTa5uEoLGRYjXZANFKnsD7roEkB0+5IQIlDBC5WQA1GHvg1jl8Y6iuMWq+Zsjjq8V5/6txNQeC0zUNImLB8CN9juTVq8l9G6dvNKC2Uc+FuvkTxbyObrj21esAMqldMsd5MPcIYDVEqRTi/XB2JHQK51sWWc24E5a4xBxjpm7DF+WZY8WOKezaDEvQ0JVvzJ9w2VX+FU2LKiEZ4EnUIZ4eIJjFoB2yWpwyBSE8eyG4505qBEWYORUX12rWHcO1Ynmq8lvvsXOrTA8aDXSnMAd4eUd12zRc21eoIkFXklFMIBSIlOI6KYmffQCPsam3D9EAWVnpC0rbUz66nqcMYIpVt1JrQHZ3jMxShhgH+Xibs8IXU2nYTSNFdnZPoseFYUoXR5EaO12FjZzm4MFUqu3zoZLVZmcHTRcSK0dKc5Eu9TVh8lnUDWF0GCzShagOCYcMZlID8EqJPsh5ZljFyweHiDAwpKzrwIGwkIScE/xl0l4saAnsZRBo77nDcpbn+t2jUE/Y+UQF6YsEHrf4whV/A2g3UgHfkEbYq/jgKBFWQX+lHXD/Xz7V2Q6UMoEJ4A+LpFZdrFk7veyAdM9JF0tM= X-Forefront-PRVS: 0205EDCD76 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(39410400002)(39830400002)(39450400003)(199003)(377454003)(189002)(24454002)(86362001)(83506001)(31696002)(2201001)(31686004)(7736002)(305945005)(23746002)(230700001)(50466002)(2906002)(5660300001)(64126003)(1706002)(106356001)(105586002)(189998001)(6116002)(33646002)(53936002)(81156014)(54906002)(50986999)(25786008)(54356999)(68736007)(4326007)(76176999)(65826007)(229853002)(47776003)(81166006)(42186005)(92566002)(5001770100001)(97736004)(36756003)(65806001)(2950100002)(8676002)(38730400001)(4001350100001)(6486002)(101416001)(65956001)(6666003);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR15MB1195;H:[IPv6:2620:10d:c082:1055:7b1:e7d7:fd6a:7d8f];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM5PR15MB1195;23:A56TZJZzgzKRzOEPI0YGwLQFHZtF4Sgluh7gv?= =?Windows-1252?Q?ek/lT3+SFcJB6wyy2SdhC1c2Mi3uFutaigvg+zfmrwLZwJL7Ivh6inxT?= =?Windows-1252?Q?CWKWg9VCtXC0lf3pOn64Ryp/uABmzkXovzKhxAftCqMCVYNZionRBiaJ?= =?Windows-1252?Q?dpgOP/uAvxEyyrFzYODoJS0byNqlplLC3VR1mMTggW/vJu2se6nG7iPO?= =?Windows-1252?Q?BM55vaL9Tt2OON6pIY0iGZJu/E3XD6+WrSdDJWHtH+qPeKfpl6gJaiDf?= =?Windows-1252?Q?4vi4AI9KjeucE8aTZqf2Aot5vSQRcXglT0EPjilsY3MIOHcXjN0XFr90?= =?Windows-1252?Q?Bg7flFoucElV4kEnwK0AlFcNm+EHWAiUVrDLaxdhuQ+uvO0bvzV+CnjV?= =?Windows-1252?Q?CsKOIDvuGnlMVz+VAYJLDUQeZwlQ4CJGXjbz3yK2AVRhJFmSemczJl19?= =?Windows-1252?Q?3jIKDRyHwjsZwIr1IVxCfDEvayhzLEUpgGZzLVTwzWPC78KMhmyV3WXL?= =?Windows-1252?Q?qH5uvhCkF7gDDpYvoUbvACO6wjWWgkkM+jf0bmhsIiP1Fz2RpVNiLi2P?= =?Windows-1252?Q?br31cv3jHJu3dd9oE8QLwIpB/Jtrb8hnYlpBa+yV4m6MQV2wDqj2CGW4?= =?Windows-1252?Q?8BQjWmznbZlRkuqUWo8/k7b1vPXeug4l47LyHtIXCTgX34hNyWhyr9QA?= =?Windows-1252?Q?4yPpI8MLUn7OghG5L+Dog5araWB95DdyNbxNs9W3/ysCXoekw7bNs/rz?= =?Windows-1252?Q?4Ra2cN1qBslfPZxMAEa5axKaV31oYufgg2sjvLoX80HsA1bFnOs047cl?= =?Windows-1252?Q?LRdEcFGKNbYQpVL5p4ywLpnPpvfJNSCcnr5TqzpUP5dTO1pBxOMtRleP?= =?Windows-1252?Q?Jy6DKb81HRMZbC2rGtIgMsm0ZuSuhgA3quxpqlI5dKNFbe4ygPYu07TV?= =?Windows-1252?Q?Use/FSLxvRnx8PvfoDKDrc9vu/ufIctwUOU27sp3lFvbI/OkoMzhJywW?= =?Windows-1252?Q?gJksYMF17v3IQlvWEF8wUAvuC1cHMnj+1xDEItWILr4/XqoTfd6QNx2I?= =?Windows-1252?Q?vylyyeNIvNPDTVwTY2mFun0WuYqQfAvrWG2WB73YNmMVrznRA2XEKBaU?= =?Windows-1252?Q?REWaneIcjjgC1Q1i9KMLH858F0P3/vCGvaysUu6UzhuGxYkk3HV7udho?= =?Windows-1252?Q?781iO0xO7qB782sFxJjKN1Yoi6xI4156WL2aNYhIEll/e54LNeNqwu6S?= =?Windows-1252?Q?Ad1w0r4uLTTQmlgDdWhciYlpopyChgMq+ulr0MeGPfUi0FhPVXE/CtZ4?= =?Windows-1252?Q?36FHyvGA1+r6YOnjliHGsLE6EUpm9OkqLZBne14q4Vk0O0d8BGggjTyW?= =?Windows-1252?Q?v3Reygwy2ZteZCFDUXSMjDvz+gzDFX/yXj35l5LExVQBgO0YX1k3pTNP?= =?Windows-1252?Q?VNj8XKcSNZInMHrAUM0KBz7UoUqkivqXK4kTun0MQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1195;6:6O/rK0QA8qUEwRfOzffVis5EO65+hKDpZon9aJSlfZPdfLfVIIz+IHMjXPyMu0Kc8/Krp1P5v8JcSTVIGu5HAxbSL3aBMy9Oa92ReteZJ07SjdDV6oO8VxBB4gFzEZAEpuyR+aJaw0rchaKjeCgLfP+S4FOmgf9ilYIP/iiVqWqG19twTs1Mu7NSC25yaoDN5u+lKVeBiDyrFd7EoZk6Cm4IMBCup8WRHIGQJcQz/6BrFL/DOGzeHn2dWsfsvoeaVGTGj5+YpRAbKjwbkC5nEoDG3k0/YZbzHW1I1iyirXNfO9774lsB0fK5078qwq/4Ext4fheyNne61U2MWIxhqW+ClPsx3q1u0EJk9+wlawAiWCYmVGUFVls2/E5B2S1UwcLSqE/b9DpwrkCqoJm7+VIBIT1H2+3ZsY2cadDvRsk=;5:EdJeyPJW6jsPNaV+uUzLk8kZ5YlNQUeTaBQxhXW5Xjv18qTlQLcf4u6qxPk2XZ9ehEcgBnup3KGYoPgAhB0T2Tu16bO4Ai6bn5bpx+hRJfKcoL2/we4kATM0BoOMhIRFm2uwzw+bxKHvTZNPxAblDA==;24:w4HidanZGf+0h2mPBLG89rQy8wYaE/lBp5GVpssZBf/BNoI5i20iJiFxFccc8I3EfFuR2r66/tBv7eqmf0EYuVwX7fLeDOx93XhK67doXFM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1195;7:N19mEbfsE3XiK9Hgd0UXq/d5HqmkF1pqaly2jvJUSi3XkA5VKoDevfmTe/BysgHKVEEiK57J3G5QPHIsBMBd4h7ZmUyso4CHvLZRXuemcUmRPnvFVajx6U29mRj4hRT5N7M9x5lmaD58bLftb8n4BnsMo5xyvShB1pm6pKm1GTQ1HkNK3UFj/qPv6uuuRr2+Enq0Gm96fSD1nY27Qp8bfPNZrPNlrIK4MqktIx+k2mVxaxJUdvkzafoJl/BQIxFvAxQVHCRNaeO74gArDlJQjwjWDrHzgXKSUUP9K3BBb6mH+3yqcBrSRwLzaX+IkNSoSNN3XjFnSAHlCyl69Y9WkJ8BWODzAwUfFAWXIXVnmhkTqgWyvTEubuueiB3BAeMJun5w5eXGa/qqdakWAoRRyjQSUoXjBokoRlinbHC5OvPdTMqcQmafPjffbGYQF1OzwpJsApOIl1Ssyq8c7D+GZJctWdVfCVi4pSEo+7LGWysFPyzOBhhv4FaGi0zQbbZabh/qFV1pk+d14Xug7qy0rkjFXRFXlYZju0Eh0afUBEf1u5A5+X+A8hqoxwpkljyr;20:SIpSMic6OlS9glb3CGicrkhyKi4ramVxV6zc2Af/dSh0RU73pmUOZxcpGAWfpb5kADavFyRaLyfC/aReJka0LR65MlIsGTEHvhxDua/o/qHuWG8yuOZAUxyxmtmUVdI0GWksGyJFz4w8V8Yxedzh+5he6CpRBrxjaPSm+RvEpoE= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2017 19:09:40.5737 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1195 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-01_14:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/01/2017 09:53 AM, Shaohua Li wrote: > blk_mq_tags/requests of specific hardware queue are mostly used in > specific cpus, which might not be in the same numa node as disk. For > example, a nvme card is in node 0. half hardware queue will be used by > node 0, the other node 1. All three patches look good to me. Bjorn, to avoid complications, if you can review/ack patch #2, then I will queue it up through the block tree for 4.11. -- Jens Axboe