From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933047AbcFCOo7 (ORCPT ); Fri, 3 Jun 2016 10:44:59 -0400 Received: from AUSXIPPS310.us.dell.com ([143.166.148.211]:36949 "EHLO ausxipps310.us.dell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932173AbcFCOo5 convert rfc822-to-8bit (ORCPT ); Fri, 3 Jun 2016 10:44:57 -0400 DomainKey-Signature: s=smtpout; d=dell.com; c=nofws; q=dns; h=X-LoopCount0:X-IronPort-AV:From:To:CC:Subject: Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language: X-MS-Has-Attach:X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader:x-originating-ip: Content-Type:Content-Transfer-Encoding:MIME-Version: Return-Path; b=bp+0lvoo0546d2RsM2hZrDRFYvnhSh/TFyVV4WBDoin72RfEZe/gYyKz sZPUmYyyDkD+DXU2TKQxMIA04Aco7acv1sVX9iF4aO7y9VjlgZwqQey9F YhU6rHbJSJBksiMMxeq2WTpz/QH59NZGSsmtR3qu/T4mxbgZnhaFS8VlS Q=; X-LoopCount0: from 10.175.216.250 X-IronPort-AV: E=Sophos;i="5.26,412,1459832400"; d="scan'208";a="323453204" From: To: CC: , , , , , , Subject: RE: [PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address Thread-Topic: [PATCH v2] r8152: Add support for setting MAC to system's Auxiliary MAC address Thread-Index: AQHRvO/4qOkaZaVerUSL1iyCPJzWv5/WudCAgAAN+QD//6/tUIAAZOQA//+sXNCAAFWiAIAA8biw Date: Fri, 3 Jun 2016 14:44:55 +0000 Message-ID: References: <1464886687-16284-1-git-send-email-mario_limonciello@dell.com> <1464886687-16284-2-git-send-email-mario_limonciello@dell.com> <20160602174808.GA32131@kroah.com> <2d81e70165b8447d92b873eafeaeded7@ausx13mpc124.AMER.DELL.COM> <20160602190238.GK15379@lunn.ch> <20160602190946.GL15379@lunn.ch> In-Reply-To: <20160602190946.GL15379@lunn.ch> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.11.181.4] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Andrew Lunn [mailto:andrew@lunn.ch] > Sent: Thursday, June 2, 2016 2:10 PM > To: Limonciello, Mario > Cc: gregkh@linuxfoundation.org; hayeswang@realtek.com; linux- > kernel@vger.kernel.org; netdev@vger.kernel.org; linux- > usb@vger.kernel.org; pali.rohar@gmail.com; anthony.wong@canonical.com > Subject: Re: [PATCH v2] r8152: Add support for setting MAC to system's > Auxiliary MAC address > > On Thu, Jun 02, 2016 at 07:04:32PM +0000, Mario_Limonciello@Dell.com > wrote: > > > -----Original Message----- > > > From: Andrew Lunn [mailto:andrew@lunn.ch] > > > Sent: Thursday, June 2, 2016 2:03 PM > > > To: Limonciello, Mario > > > Cc: gregkh@linuxfoundation.org; hayeswang@realtek.com; linux- > > > kernel@vger.kernel.org; netdev@vger.kernel.org; linux- > > > usb@vger.kernel.org; pali.rohar@gmail.com; > anthony.wong@canonical.com > > > Subject: Re: [PATCH v2] r8152: Add support for setting MAC to system's > > > Auxiliary MAC address > > > > > > > > And you want to check this for all Dell devices? Please be model > > > > > specific, I doubt a bunch of Dell servers wants to run this code... > > > > > > > > > > > > > Tracking model specific is really going to turn into a giant list never > ending > > > list. > > > > To drill down more specifically, I can match on chassis too. > > > > > > Does Dell happen to use its own USB Vendor ID for the USB device in > > > the dock? You could go at this problem from the other direction if it > > > does have a unique vendor ID. > > > > > > Andrew > > > > Unfortunately it's not a Dell specific VID/PID. I'm asking around to find out > > if there is something else identifiable about this dock's NIC (maybe that > r8152 > > can query). > > lsusb -v > > I assume there is a USB hub in the dock, maybe that has a Dell VID? > Going one level up the USB tree hierarchy should not be too hard. > > Andrew I confirmed with some internal contacts a few extra bits about questions about this from throughout the conversation. 1) This feature IS in the general Realtek driver for Windows, not a special Dell driver. 2) The feature only offered to the Realtek 8153-AD, no other Realtek chip will do it (even Realtek 8153-VB won't). 3) The feature is activated when a special "Docking" bit is set on the 8153-AD. 4) The feature is activated on all Realtek 8153-AD's on the host system with the docking bit set. So on Windows if two Dell docks were hooked up they would both have the same AUX MAC. So considering that I think it would make sense to only activate in those same special circumstances (RTL8153-AD, docking bit set, system has \\_SB.AMAC). I also feel this should stay in the Realtek driver as this as this implementation is very Realtek specific.