From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: dts: qcom: apq8026: remove superfluous "input-enable"
Date: Tue, 11 Apr 2023 13:05:39 +0200 [thread overview]
Message-ID: <b42f7c48-84b1-1e50-bcad-1bf5edf1a168@linaro.org> (raw)
In-Reply-To: <20230410181005.25853-1-krzysztof.kozlowski@linaro.org>
On 10.04.2023 20:10, Krzysztof Kozlowski wrote:
> Pin configuration property "input-enable" was used with the intention to
> disable the output, but this is done by default by Linux drivers. Since
> patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not
> input-enable") the property is not accepted anymore.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts | 2 --
> arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts | 1 -
> arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts | 3 ---
> 3 files changed, 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts b/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts
> index 7a80e1c9f126..aa0e0e8d2a97 100644
> --- a/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts
> +++ b/arch/arm/boot/dts/qcom-apq8026-asus-sparrow.dts
> @@ -268,7 +268,6 @@ bluetooth_default_state: bluetooth-default-state {
> function = "gpio";
> drive-strength = <8>;
> bias-disable;
> - input-enable;
> };
>
> wlan_hostwake_default_state: wlan-hostwake-default-state {
> @@ -276,7 +275,6 @@ wlan_hostwake_default_state: wlan-hostwake-default-state {
> function = "gpio";
> drive-strength = <2>;
> bias-disable;
> - input-enable;
> };
>
> wlan_regulator_default_state: wlan-regulator-default-state {
> diff --git a/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts b/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts
> index d64096028ab1..5593a3a60d6c 100644
> --- a/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts
> +++ b/arch/arm/boot/dts/qcom-apq8026-huawei-sturgeon.dts
> @@ -352,7 +352,6 @@ wlan_hostwake_default_state: wlan-hostwake-default-state {
> function = "gpio";
> drive-strength = <2>;
> bias-disable;
> - input-enable;
> };
>
> wlan_regulator_default_state: wlan-regulator-default-state {
> diff --git a/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts b/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
> index b82381229adf..b887e5361ec3 100644
> --- a/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
> +++ b/arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts
> @@ -307,7 +307,6 @@ bluetooth_default_state: bluetooth-default-state {
> function = "gpio";
> drive-strength = <2>;
> bias-disable;
> - input-enable;
> };
>
> touch_pins: touch-state {
> @@ -317,7 +316,6 @@ irq-pins {
>
> drive-strength = <8>;
> bias-pull-down;
> - input-enable;
> };
>
> reset-pins {
> @@ -335,7 +333,6 @@ wlan_hostwake_default_state: wlan-hostwake-default-state {
> function = "gpio";
> drive-strength = <2>;
> bias-disable;
> - input-enable;
> };
>
> wlan_regulator_default_state: wlan-regulator-default-state {
next prev parent reply other threads:[~2023-04-11 11:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 18:10 Krzysztof Kozlowski
2023-04-10 18:10 ` [PATCH 2/3] ARM: dts: qcom: mdm9615: " Krzysztof Kozlowski
2023-04-11 19:59 ` Konrad Dybcio
2023-04-10 18:10 ` [PATCH 3/3] ARM: dts: qcom: msm8974: " Krzysztof Kozlowski
2023-04-11 19:59 ` Konrad Dybcio
2023-04-11 11:05 ` Konrad Dybcio [this message]
2023-05-23 3:03 ` (subset) [PATCH 1/3] ARM: dts: qcom: apq8026: " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b42f7c48-84b1-1e50-bcad-1bf5edf1a168@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®