From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933042AbdHVPDN (ORCPT <rfc822;w@1wt.eu>);
        Tue, 22 Aug 2017 11:03:13 -0400
Received: from mout.web.de ([212.227.15.14]:59749 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932329AbdHVPDL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 22 Aug 2017 11:03:11 -0400
Subject: Re: [alsa-devel] ALSA: pcsp: Use common error handling code in
 snd_card_pcsp_probe()
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Cc: kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Dan Carpenter <dan.carpenter@oracle.com>
References: <08ee0d6b-788b-2845-6964-e1e55c2d2292@users.sourceforge.net>
 <20170822121625.syvr64kwyh5xjexg@mwanda> <s5hziar9483.wl-tiwai@suse.de>
 <f138ba40-a61f-cdab-3d9b-699dbcacad9d@users.sourceforge.net>
 <s5ho9r792yl.wl-tiwai@suse.de>
 <fc4d8c96-7de2-e8f0-4cb4-5dda795d298a@users.sourceforge.net>
 <s5hbmn78zmg.wl-tiwai@suse.de>
 <139363f6-e059-defb-357e-f18645ba9768@users.sourceforge.net>
 <s5h378j8xos.wl-tiwai@suse.de>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <b434f976-33a1-7ced-55b5-b55487f2fb14@users.sourceforge.net>
Date: Tue, 22 Aug 2017 17:03:00 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <s5h378j8xos.wl-tiwai@suse.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:XwKNVb9ovpO9Prr9ooaulcb0ccaIuEItZOzgyxr9amO3y78I6oa
 BYiAKLsDUCzn3kcehgAv5eAu+IF6ci0IqMkkihoUTijbOxmX5eA+Cm/EMU3HdquIs1t9veU
 8ucST4Rb5Vd4KbGflVCaGBiKe4GzcIKVA+t2/Taw7RtjAfyNAYhe19I4wnlOxLxAgpL2dk0
 MuILxy3JmJUoWLELK9W1Q==
X-UI-Out-Filterresults: notjunk:1;V01:K0:o+ljt9JP67M=:vhD85kl6Cn9wxDcbpqE8/l
 cyVCULs3oxE7Gs6GqpRbAj6+GqHw5/qVJ0ycC6s3IAunmEkqj7w4AV60IePrGLMS+jM+PES2j
 3jknTPo5ky/7K1nORUUhUPlTFI2AdT5MVqmnJgyYl7KW5cD5Qo4S1ouv+NbaWkrWlMAX3dq4k
 UE6fcMZKUeq3EBpHjxD8bC6uGexEHLGtth4a024aIct4zUHZKbSG6AiHxfhjT846daZwHEP2O
 dfebJSYgXr0FvzZ9n9zIlIcwUgjvYQWc0nnJ67TZf6kCCRByRx2DgZ5zdlFPt1vqM6c8T7mCD
 leihu0gQKEilYYwdonrlzD8sR/2HQGJzo8nL/DEPORj5uRKIu5B6/HqodA19nT8nYsGw2qxtj
 htyjfYgo+5lUq64rWejwSqOKou49NH4BtVZ3G9doP+kXubdJYGjH121GTu2nnRvUF89Y1CDGZ
 oI65SHVipH7PxO6h3dLj5fsmi7RswZvZv+xms3Fa81sv7EyVGK+3xGk/4jyOVkJxGfiLIGita
 M39E/A8YxjXVbNx7pDYlpz/vcaUJ9zIjf7A53zG5lK6j6g+8AG2OKWhvtxbCfIpAtr+Ne+7g/
 3QOoTkeg6oZVLm2cQIQnJaCr8ShzZ0vAD5Rh0011ciVX8x0NIAW4xw7ryXJ9RIFOLW91yesnH
 qUKwhtwxswKmC4hGqJax5g/YW+omsKb/VVwmLZoSlTyHTuZ7hZ8m7N8Y3HvcB4TIhVLVY3lm7
 natU3iO/gzM4mAr5AMGnSFCc+6OZsv32PKMMDcRt+RgeOW0MfXgW586szrZC5TujLY23c6SpA
 t3Fqb1mtxNaCCHEERi3sf/T1H4irM07t6hzZLlNwvad9c7arZ8FQ6xdAeYq1HeNjvnMrsmR
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> * I find it a bit safer when the error predicate is “return value != 0”.
> 
> Can't agree.

How do you think about to reduce the probability that positive return values
will accidentally be interpreted as a successful function execution.


> And I have no interest to continue bike-shedding, sorry.

I do not like that you prefer to put this technical detail into such
a communication category.


> You can't convince me regarding this.

Would you still like to integrate the proposed refactoring with the use
of previous failure predicates then?

Regards,
Markus