From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752502AbdGEIDP (ORCPT ); Wed, 5 Jul 2017 04:03:15 -0400 Received: from esa2.microchip.iphmx.com ([68.232.149.84]:49879 "EHLO esa2.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752367AbdGEIDM (ORCPT ); Wed, 5 Jul 2017 04:03:12 -0400 X-IronPort-AV: E=Sophos;i="5.40,310,1496127600"; d="scan'208";a="4386355" Subject: Re: [PATCH][-next] net: macb: remove extraneous return when MACB_EXT_DESC is defined To: Colin King , , David Miller CC: , References: <20170704150959.18315-1-colin.king@canonical.com> From: Nicolas Ferre Organization: microchip Message-ID: Date: Wed, 5 Jul 2017 10:03:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170704150959.18315-1-colin.king@canonical.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/07/2017 at 17:09, Colin King wrote: > From: Colin Ian King > > When macro MACB_EXT_DESC is defined we end up with two identical > return statements and just one is sufficient. Remove the extra > return. > > Detected by CoverityScan, CID#1449361 ("Structurally dead code") > > Signed-off-by: Colin Ian King Acked-by: Nicolas Ferre > --- > drivers/net/ethernet/cadence/macb_main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c > index 41e5711544fc..e69ebdd65658 100644 > --- a/drivers/net/ethernet/cadence/macb_main.c > +++ b/drivers/net/ethernet/cadence/macb_main.c > @@ -146,7 +146,6 @@ static unsigned int macb_adj_dma_desc_idx(struct macb *bp, unsigned int desc_idx > default: > break; > } > - return desc_idx; > #endif > return desc_idx; > } > -- Nicolas Ferre