From: "Gupta, Akshay" <Akshay.Gupta@amd.com>
To: Max Kellermann <max.kellermann@ionos.com>,
arnd@arndb.de, gregkh@linuxfoundation.org,
naveenkrishna.chatradhi@amd.com, linux@roeck-us.net,
linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] drivers/misc/amd-sbi/Kconfig: select REGMAP_I2C
Date: Thu, 4 Sep 2025 11:26:01 +0530 [thread overview]
Message-ID: <b43dcd31-93c8-4fd8-8ecb-60dead19470a@amd.com> (raw)
In-Reply-To: <20250829091442.1112106-1-max.kellermann@ionos.com>
On 8/29/2025 2:44 PM, Max Kellermann wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> Without CONFIG_REGMAP, rmi-i2c.c fails to build because struct
> regmap_config is not defined:
>
> drivers/misc/amd-sbi/rmi-i2c.c: In function ‘sbrmi_i2c_probe’:
> drivers/misc/amd-sbi/rmi-i2c.c:57:16: error: variable ‘sbrmi_i2c_regmap_config’ has initializer but incomplete type
> 57 | struct regmap_config sbrmi_i2c_regmap_config = {
> | ^~~~~~~~~~~~~
>
> Additionally, CONFIG_REGMAP_I2C is needed for devm_regmap_init_i2c():
>
> ld: drivers/misc/amd-sbi/rmi-i2c.o: in function `sbrmi_i2c_probe':
> drivers/misc/amd-sbi/rmi-i2c.c:69:(.text+0x1c0): undefined reference to `__devm_regmap_init_i2c'
>
> Fixes: 013f7e7131bd ("misc: amd-sbi: Use regmap subsystem")
> Cc: stable@vger.kernel.org
> Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
> ---
> drivers/misc/amd-sbi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/amd-sbi/Kconfig b/drivers/misc/amd-sbi/Kconfig
> index 4840831c84ca..4aae0733d0fc 100644
> --- a/drivers/misc/amd-sbi/Kconfig
> +++ b/drivers/misc/amd-sbi/Kconfig
> @@ -2,6 +2,7 @@
> config AMD_SBRMI_I2C
> tristate "AMD side band RMI support"
> depends on I2C
> + select REGMAP_I2C
> help
> Side band RMI over I2C support for AMD out of band management.
>
> --
> 2.47.2
Thank you for the patch.
Tested-by: Akshay Gupta <Akshay.Gupta@amd.com>
Reviewed-by: Akshay Gupta <Akshay.Gupta@amd.com>
prev parent reply other threads:[~2025-09-04 5:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 9:14 Max Kellermann
2025-09-04 5:56 ` Gupta, Akshay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b43dcd31-93c8-4fd8-8ecb-60dead19470a@amd.com \
--to=akshay.gupta@amd.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=max.kellermann@ionos.com \
--cc=naveenkrishna.chatradhi@amd.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®