mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Jim Mattson <jmattson@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kvm list <kvm@vger.kernel.org>
Subject: Re: [PATCH 1/4] KVM: VMX: cache secondary exec controls
Date: Thu, 24 Aug 2017 18:08:53 +0200	[thread overview]
Message-ID: <b441c811-f35e-5233-fef9-a7b5c0ca8a92@redhat.com> (raw)
In-Reply-To: <CALMp9eQYf4YjkD9W_4ySbJAxqe_oXQYrn5dpbp1Vm6jBu_2g7A@mail.gmail.com>

On 24/08/2017 18:02, Jim Mattson wrote:
> On the subject of complexity, why do we clear
> CPUID.(EAX=07H,ECX=0):EBX.INVPCID[bit 10] when CPUID.01H:ECX.PCID[bit
> 17] is clear? Sure, it would be odd to support the INVPCID instruction
> without also supporting PCIDs, but why single out this one check?
> Isn't it equally bizarre to support SSE2 without SSE, or XSAVES
> without XSAVE, or RDTSCP without TSC, or DS-CPL without DS, or ...?

I actually agree with you.  It's just been like this forever:

    commit ad756a1603c5fac207758faaac7f01c34c9d0b7b
    Author: Mao, Junjie <junjie.mao@intel.com>
    Date:   Mon Jul 2 01:18:48 2012 +0000

    KVM: VMX: Implement PCID/INVPCID for guests with EPT

Paolo

  reply	other threads:[~2017-08-24 16:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24 13:37 [PATCH v7 0/4] Raise #UD and disable execution controls for more CPUID bits Paolo Bonzini
2017-08-24 13:37 ` [PATCH 1/4] KVM: VMX: cache secondary exec controls Paolo Bonzini
2017-08-24 14:47   ` Jim Mattson
2017-08-24 15:25     ` Paolo Bonzini
2017-08-24 15:41       ` Jim Mattson
2017-08-24 15:46         ` Paolo Bonzini
2017-08-24 16:02           ` Jim Mattson
2017-08-24 16:08             ` Paolo Bonzini [this message]
2017-08-24 13:37 ` [PATCH 2/4] kvm: vmx: Raise #UD on unsupported RDRAND Paolo Bonzini
2017-08-24 17:42   ` David Hildenbrand
2017-08-24 13:37 ` [PATCH 3/4] kvm: vmx: Raise #UD on unsupported RDSEED Paolo Bonzini
2017-08-24 17:42   ` David Hildenbrand
2017-08-24 13:37 ` [PATCH 4/4] kvm: vmx: Raise #UD on unsupported XSAVES/XRSTORS Paolo Bonzini
2017-08-24 14:54   ` Jim Mattson
2017-08-24 16:09     ` [PATCH v8 " Paolo Bonzini
2017-08-24 20:41       ` Jim Mattson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b441c811-f35e-5233-fef9-a7b5c0ca8a92@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®