mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Haiwei Li <lihaiwei.kernel@gmail.com>,
	Sean Christopherson <sean.j.christopherson@intel.com>,
	"vkuznets@redhat.com" <vkuznets@redhat.com>,
	wanpengli@tencent.com,
	"jmattson@google.com" <jmattson@google.com>,
	"joro@8bytes.org" <joro@8bytes.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"bp@alien8.de" <bp@alien8.de>,
	hpa@zytor.com
Cc: "x86@kernel.org" <x86@kernel.org>,
	kvm@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: Fix the indentation to match coding style
Date: Mon, 18 May 2020 12:55:51 +0200	[thread overview]
Message-ID: <b4443a42-bd06-4b67-64e6-6c636507713b@redhat.com> (raw)
In-Reply-To: <2f78457e-f3a7-3bc9-e237-3132ee87f71e@gmail.com>

On 18/05/20 03:31, Haiwei Li wrote:
> From: Haiwei Li <lihaiwei@tencent.com>
> 
> There is a bad indentation in next&queue branch. The patch looks like
> fixes nothing though it fixes the indentation.
> 
> Before fixing:
> 
>                 if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
>                         kvm_skip_emulated_instruction(vcpu);
>                         ret = EXIT_FASTPATH_EXIT_HANDLED;
>                }
>                 break;
>         case MSR_IA32_TSCDEADLINE:
> 
> After fixing:
> 
>                 if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
>                         kvm_skip_emulated_instruction(vcpu);
>                         ret = EXIT_FASTPATH_EXIT_HANDLED;
>                 }
>                 break;
>         case MSR_IA32_TSCDEADLINE:
> 
> 
> Signed-off-by: Haiwei Li <lihaiwei@tencent.com>
> ---
>  arch/x86/kvm/x86.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 471fccf..446f747 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -1631,7 +1631,7 @@ fastpath_t handle_fastpath_set_msr_irqoff(struct
> kvm_vcpu *vcpu)
>                 if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
>                         kvm_skip_emulated_instruction(vcpu);
>                         ret = EXIT_FASTPATH_EXIT_HANDLED;
> -               }
> +               }
>                 break;
>         case MSR_IA32_TSCDEADLINE:
>                 data = kvm_read_edx_eax(vcpu);
> -- 
> 1.8.3.1
> 

Queued, thanks.

Paolo


      parent reply	other threads:[~2020-05-18 10:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-18  1:31 Haiwei Li
2020-05-18  3:00 ` Wanpeng Li
2020-05-18 10:55 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4443a42-bd06-4b67-64e6-6c636507713b@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=jmattson@google.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=lihaiwei.kernel@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=tglx@linutronix.de \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®