From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AG47ELup2RV2g23u0tOhaonoKnOIh8U8MnWc0v6e+Z+VEFMXn9Zvtb7QKtQdljpqKjh0cqgdjar8 ARC-Seal: i=1; a=rsa-sha256; t=1520336213; cv=none; d=google.com; s=arc-20160816; b=dY0dA6Zfnpe9CrFudMGSrVAfsU5vTIuqUf3AL5gHpUfp/Giym2E0tCfQjgaelZB6ps Snd8JHtcIoX33sbD87PP8ExiIi6e8b0M+wbFQETojW9fuR1qoCHXUsOoMei5mLTvBVPD 5Gxgl7kZmIVnkoSgRmfUlgLbul6I6Ren30DFFGPHzvRvupvlWCqxYIDCtQq9qSfW6f3D toVqroM8iKbOzuKK1oE5RfB8WHQdrbcKSQ9M1VCc2YFkolzuVtUtJxnrsrBGkHpQKfvO 34Hs42EbRnO2SOndTQQhzD+uKDGGGNClROZvPiajXcOM12L9YL6S1CE7ltca5ey4D5Zd 16pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:cc:references:to:subject:arc-authentication-results; bh=lMv4HmySXHfbUk/K5QdB53jdvj+STeh6BYp3EClsCFg=; b=qqbWgN75NuO7AxEC3LXGBYMCcMfKWxYN+hyiCXT7RXmzoBwNA+9hnAkXGqoYtpLb8+ LVDej/xSKvH0+Fk2Q7cQWs5nTPRXuRlYXLRwPDVi2yhPSiSWaoAVYY+oRSk/ElEiINfx q2ZqNwINsNelfAtqUe/uiqPo1wOusKBbtYvMLkqaBmi7avSrtJBiNJQsrd2LXKkv0hqG vZaOvd+BecAGIY67S2ROMhw2mUlgm/QyUHgpCEwS2QMHwW36YI4CNZScsl9Fr/K2OFek WZqoN8+EADI/JG2HEPbri0nVvYgUorR3X6FMFhD/kc31zBCosYmva1TMYLZGir9JpVAd E1dQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of john.garry@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=john.garry@huawei.com Authentication-Results: mx.google.com; spf=pass (google.com: domain of john.garry@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=john.garry@huawei.com Subject: Re: [PATCH v16 0/9] LPC: legacy ISA I/O support To: Andy Shevchenko , , , , , , , , , , , , , References: <1520333268-82754-1-git-send-email-john.garry@huawei.com> <1520335317.10722.416.camel@linux.intel.com> CC: , , , , , , , , , , , , , From: John Garry Message-ID: Date: Tue, 6 Mar 2018 11:36:27 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1520335317.10722.416.camel@linux.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.238] X-CFilter-Loop: Reflected X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1594185012385637551?= X-GMAIL-MSGID: =?utf-8?q?1594188064953785447?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 06/03/2018 11:21, Andy Shevchenko wrote: > On Tue, 2018-03-06 at 18:47 +0800, John Garry wrote: >> This patchset supports the IPMI-bt device attached to the Low-Pin- >> Count >> interface implemented on Hisilicon Hip06/Hip07 SoC. >> ----------- >> | LPC host| >> | | >> ----------- >> | >> _____________V_______________LPC >> | | >> V V >> ------------ >> | BT(ipmi)| >> ------------ >> >> When master accesses those peripherals beneath the Hip06/Hip07 LPC, a >> specific >> LPC driver is needed to make LPC host generate the standard LPC I/O >> cycles with >> the target peripherals'I/O port addresses. But on curent arm64 world, >> there is >> no real I/O accesses. All the I/O operations through in/out accessors >> are based >> on MMIO ranges; on Hip06/Hip07 LPC the I/O accesses are performed >> through driver >> specific accessors rather than MMIO. >> To solve this issue and keep the relevant existing peripherals' >> drivers untouched, >> this patchset: >> - introduces a generic I/O space management framework, logical PIO, >> to support >> I/O operations on host controllers operating either on MMIO >> buses or on buses >> requiring specific driver I/O accessors; >> - redefines the in/out accessors to provide a unified interface for >> both MMIO >> and driver specific I/O operations. Using logical PIO, th call of >> in/out() from >> the host children drivers, such as ipmi-si, will be redirected to >> the >> corresponding device-specific I/O hooks to perform the I/O >> accesses. >> >> Based on this patch-set, all the I/O accesses to Hip06/Hip07 LPC >> peripherals can >> be supported without any changes on the existing ipmi-si driver. >> >> The whole patchset has been tested on Hip07 D05 board both using DTB >> and ACPI. >> > >> V15 thread here: https://lkml.org/lkml/2018/2/26/584 > > Thanks for an update. > Though I answered to previous thread. > > Summary: I'm fine with the series as long as maintainers are fine > (Rafael et al.). On personal side I think that the handler approach is > better. Details are in v15 thread. Hi Andy, Thanks for your input and continued support. As I mentioned in reply in v15, the handler support would (or has) faced issues. And Rafael seems fine with deferring the probe to the LLDD in Patch #7/9 Anyway, let's wait for any more input. Much appreciated, John >