From: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
Rajendra Nayak <quic_rjendra@quicinc.com>
Subject: Re: [PATCH V3 1/3] dt-bindings: sram: qcom,imem: Add Boot Stat region within IMEM
Date: Fri, 14 Apr 2023 17:53:56 +0530 [thread overview]
Message-ID: <b44bedcf-2272-9f9f-0f11-ca9894567e9a@quicinc.com> (raw)
In-Reply-To: <58bf68b4-dad4-64dc-6eee-9f6cc154c1ca@linaro.org>
On 4/13/2023 10:11 PM, Krzysztof Kozlowski wrote:
> On 13/04/2023 11:28, Souradeep Chowdhury wrote:
>
> Thank you for your patch. There is something to discuss/improve.
>
>> + "^stats@[0-9a-f]+$":
>> + type: object
>> + description:
>> + Imem region dedicated for storing timestamps related
>> + information regarding bootstats.
>> +
>> + properties:
>> + compatible:
>> + items:
>> + - enum:
>> + - qcom,sm8450-bootstats
>> + - const: qcom,imem-bootstats
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + required:
>> + - compatible
>> + - reg
>> +
>> + additionalProperties: false
>
> The feedback about additionalProperties was given in different place. On
> purpose, because it is easier to read when it is placed before
> properties for indented cases. Therefore move it after description, how
> I originally asked.
Ack
>
>> +
>> required:
>> - compatible
>> - reg
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-04-14 12:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 9:28 [PATCH V3 0/3] soc: qcom: boot_stats: Add driver support for boot_stats Souradeep Chowdhury
2023-04-13 9:28 ` [PATCH V3 1/3] dt-bindings: sram: qcom,imem: Add Boot Stat region within IMEM Souradeep Chowdhury
2023-04-13 16:41 ` Krzysztof Kozlowski
2023-04-14 12:23 ` Souradeep Chowdhury [this message]
2023-04-13 9:28 ` [PATCH V3 2/3] soc: qcom: boot_stat: Add Driver Support for Boot Stats Souradeep Chowdhury
2023-04-14 11:34 ` Srinivas Kandagatla
2023-04-14 12:22 ` Souradeep Chowdhury
2023-04-13 9:28 ` [PATCH V3 3/3] MAINTAINERS: Add the entry for boot_stats driver support Souradeep Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b44bedcf-2272-9f9f-0f11-ca9894567e9a@quicinc.com \
--to=quic_schowdhu@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®