From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D6F6391E52 for ; Wed, 10 Jun 2026 08:23:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781079832; cv=none; b=owrWobaAPsIA9P2EV25xNYE/CDA/skQQuIgCbj1X83fb8IABCOguada5GrkJry6icmkiGqwQnqhLAyAReAtq91CA/QwHqj2oYlie9VAk1yk6J5cQsggZTT+FckiaoTWHIKJdWXj9DGFrqdaBHkp8jvQHaiOObH4niNV3Pi4/Rgc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781079832; c=relaxed/simple; bh=LkbvRb4Lxa3vbTQK4ekpMqZOPYOFQsKDqFtDgQKLURE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p72KLp/JOAH4NByObIHvsRigM/QIJGRv5rSvNkiolnZZzNyYzFXsXNhsDgNUQLikKtnpO+YJKJxO0vvutMAesJ42c4PRjDyC/UKaIWQSC2XA3rg+uE2mBrfIyVbY1t32Othd93K8vfB7j6jVKa4wPJA6s1lQm3Jpo3BqnYg1UQA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VqlLSJzm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cTzE0cub; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VqlLSJzm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cTzE0cub" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65A7i0v1531853 for ; Wed, 10 Jun 2026 08:23:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JYDOedvWLAS4SJUQqvQ16zubYkeixi+iRS6jV/d0I28=; b=VqlLSJzmzF154OeE /ENKpohDDVjlds1p8RGt1KYNdofHNz0k3ITjDIuHXfoADtRtk/BTFjpX52pi46t5 4+0pZSXnYvDSmu/B+yBzS09TUaaITZMI5Cn8OUogt8O8b989qoS6hnoK8PXu07Wg RQD6Bk2fBnPFFsrWHB5k4MVwLGsonMcAxgirU5iR55JZKYx7EHa4+elIXQhhLTLM aCDZkJkUKoZGSrY9eHM9ra0ybCNEQR0p1lCGzANde4kYU9NXVwXjR+wAZBY35OtC 0MWizSaNVj4c/5AyQc0hIGCujft+j0XvSw8siViBMpuM2/1gENKFTh9X1gp2EMT9 aRjQgQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eq0m1ruyg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Jun 2026 08:23:49 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-9159c4b210aso1236810985a.1 for ; Wed, 10 Jun 2026 01:23:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781079829; x=1781684629; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JYDOedvWLAS4SJUQqvQ16zubYkeixi+iRS6jV/d0I28=; b=cTzE0cubNkaAwmeTYxMpEkQs8KU9Jd0dxXqiQ1xjnhJGA4d09RGWcKuZ0HsL2pMmEt qbCEqJozulR3zVnuBiXPy30J2TO0TqcURuLzqIjzix+geo8+eT6TzWowW+fKlgGZq4xB jKHhAQzo8OcaRYQtt6tQM53M7KXvcE9CvG/8nGQzXu9hZRVDpK9GdQxPmtzWTeUS49II km3XdUQeq+NON59/EQ2KeOFkkP/zXaMVsJMMzSUIK+JLX/MU2dq3IRmqLwe5he4+gpfM HwolHHxsdwH2UYM6SalY1R2iLl35Fr2fA2JyiA9bP26D8Q7XaXTdF5PZNCLKqub53PMm uhdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781079829; x=1781684629; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JYDOedvWLAS4SJUQqvQ16zubYkeixi+iRS6jV/d0I28=; b=PRZn/azDMuxiizovheDqpEVqziLcI7oywDBQMJCd5h3whlPaHOs01340sNkBRfUnH6 uINoNvvTSl2Hlf0HG7+3IWEn8A+vJ2joeHm9IJ/jM+bqBbIRAbxQFkNHRFSmKJ6n8YnG 9n4FtRp/ZMYb7O/LDjUhbg7rGk4B3cNY8v/kKDHg+R7Wfs7/nccfFBBsLnmpdn0uQY65 fR+0k01oy3TOaJ0BsP21Zj3MKOmwFwFNbBjhbT2dTOMg6+5aTVKuSNBsttmouo79XRXX /kKq01xKPMwB0IK6mdcPgtyYqyLFbYoTZCUIscc3P94/aOb+8hJV4NZ7jWQRzjGU+4Ed H3dg== X-Forwarded-Encrypted: i=1; AFNElJ8j4UN4MnNq5w17yYYvlC1NXewXc3xjD97NOVKMj3COD9F2bpBt0XIU6Mm5EkLPGRAAH3fISunbUP5CQEA=@vger.kernel.org X-Gm-Message-State: AOJu0YxEQSPMvTx6i+nbk1R8a7pVLKPnz0ynS5JAVKuB94HQvNC8aiM5 8LU55QX21zmIbDkyMMoX9H7ONfO/LQHr8tk6HDNvs8xstlvXvRfIa37HV60AlPyuj8O8wrzUlQx 0H+srqtNT5Tims/+67lYpgtWHwdYlWzZgYxDYVCdQh6mtVmqECo2mvI+kBnLOf/amT7A= X-Gm-Gg: Acq92OG2EBofF0eRNMN7k8mCaVl7+CR+v/c8m6iAjU+14W8S1H2fQlsJE8uoO1fc1ZF Lt9bzdiUVtGIaD8McDEBxOKk+D8/uxkXH8vx1tg3ByWW0P7oy3x7dkEew2BO42zOxSyesMxJSVV 4fMJyyj0hfdy/48adQSsTnjV1Uro6xr7TdKKt/rnpesR2Cx6AtLIjO/iMsy6lNT2xppnRvIdJ0j KKNAzhk7y3odKFT6i22Qo0EI+KfyCZujwgL8BaotBYCICYDXHv5kyN63kC4NpiSH8D9c1RiomGo r9bohnBBP/x9Bt40kAFfToacOmrO8Kz0UZ5PRXk9V+nLoDVSE3L2o9TbsMeZzX1SQJLlhqHHRYB HTb/WsGBfSKGRZVCXrLQsnm8Mupm+/3XItRHIb0qxW9dhB5LaTkiv9L02GNL7BQ6/+0NPwX8inO U+x/tO3tXexMhDhkA+uDU= X-Received: by 2002:a05:620a:4407:b0:915:4217:bf0b with SMTP id af79cd13be357-915ad11ecdcmr2818559885a.19.1781079828936; Wed, 10 Jun 2026 01:23:48 -0700 (PDT) X-Received: by 2002:a05:620a:4407:b0:915:4217:bf0b with SMTP id af79cd13be357-915ad11ecdcmr2818557985a.19.1781079828545; Wed, 10 Jun 2026 01:23:48 -0700 (PDT) Received: from [10.111.165.13] (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9158a2465e7sm2407977585a.19.2026.06.10.01.23.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2026 01:23:47 -0700 (PDT) Message-ID: Date: Wed, 10 Jun 2026 16:23:40 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 7/8] media: qcom: camss: Account for C-PHY when calculating link frequency To: david@ixit.cz, Robert Foss , Todor Tomov , Bryan O'Donoghue , Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , Luca Weiss , Petr Hodina , "Dr. Git" , Cory Keitz , Loic Poulain Cc: Frank Li , Konrad Dybcio , Kieran Bingham , Sakari Ailus , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20260605-qcom-cphy-v7-0-426c37e9008f@ixit.cz> <20260605-qcom-cphy-v7-7-426c37e9008f@ixit.cz> Content-Language: en-US From: Wenmeng Liu In-Reply-To: <20260605-qcom-cphy-v7-7-426c37e9008f@ixit.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEwMDA3OCBTYWx0ZWRfX2uHnMa+ihzz0 3aGoED9lnaqtNTRGPpGC1dJxdUVYPIja4eMLA73xV5phlN5i6HHYcRRIVhxIvvkZsfe6AErLODW ypqRRMYqAZqL/aaUQ/eHWfgcKWa07N8XwbEayFT1EBOZ2cmmeE0NCcDhPMJxQm9724ktU5g/WHd KarN3dAN793Pf8i3RP9jI/vkLxBc5IFpdF9MlDPoGaBwClT27c38X96cG4rvyXiIwHzzwA8hWj8 ObvrPsqBe5nQeMZLi1bYXo68oCPGWH7GLmVjX2eU3YhnpN2Snzp5H5oUmOW0RWXhus61qkUwEJT pCmbGR+o4wix4ZWq4ukuA8QiW5GEy0abnBOVdgNjlQ9EfhM61/9x0mrHRUcGBumncwr/DhQOPEc Z+Ei2gnMGi62v6QXCr6cA7q1dn6I0pqKjo+Q65Hkwi6ZD1loZ0bGg9hMdL1l653WteEOKkjr9AZ m+9/R/jBZtjBXgKYhGA== X-Proofpoint-GUID: vlsfG4oMFkS4Zbnt4zhR5vklmcDEYzCt X-Authority-Analysis: v=2.4 cv=UdJhjqSN c=1 sm=1 tr=0 ts=6a291f15 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=vggBfdFIAAAA:8 a=KKAkSRfTAAAA:8 a=pCfSTlZN1A5Xfdvpc7kA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: vlsfG4oMFkS4Zbnt4zhR5vklmcDEYzCt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-10_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 phishscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606100078 On 6/5/2026 9:14 PM, David Heidelberg via B4 Relay wrote: > From: David Heidelberg > > Ensure that the link frequency divider correctly accounts for C-PHY > operation. The divider differs between D-PHY and C-PHY, as described > in the MIPI CSI-2 specification. > > For more details, see: > https://docs.kernel.org/driver-api/media/tx-rx.html#pixel-rate > > Suggested-by: Sakari Ailus > Acked-by: Cory Keitz > Tested-by: Cory Keitz > Reviewed-by: Bryan O'Donoghue > Link: https://docs.kernel.org/driver-api/media/tx-rx.html#pixel-rate > Signed-off-by: David Heidelberg > --- > drivers/media/platform/qcom/camss/camss-csid.c | 7 +++++-- > drivers/media/platform/qcom/camss/camss-csiphy.c | 6 ++---- > drivers/media/platform/qcom/camss/camss.c | 18 +++++++++++++++--- > drivers/media/platform/qcom/camss/camss.h | 2 +- > 4 files changed, 23 insertions(+), 10 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c > index bcc34ac9dd212..7415e811082da 100644 > --- a/drivers/media/platform/qcom/camss/camss-csid.c > +++ b/drivers/media/platform/qcom/camss/camss-csid.c > @@ -534,25 +534,28 @@ const struct csid_format_info *csid_get_fmt_entry(const struct csid_format_info > > /* > * csid_set_clock_rates - Calculate and set clock rates on CSID module > * @csiphy: CSID device > */ > static int csid_set_clock_rates(struct csid_device *csid) > { > struct device *dev = csid->camss->dev; > + struct csiphy_device *csiphy = &csid->camss->csiphy[csid->phy.csiphy_id]; The PHY indices are not necessarily contiguous on some platforms, such as Hamoa or Purwa. For example, on Hamoa, we have csiphy0, csiphy1, csiphy2, and csiphy4. Using csiphy->id directly would lead to an array out-of-bounds access. Thanks, Wenmeng > + struct csiphy_lanes_cfg *lane_cfg = &csiphy->cfg.csi2->lane_cfg; > const struct csid_format_info *fmt; > + > s64 link_freq; > int i, j; > int ret; >