From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750964AbdE3H1C (ORCPT ); Tue, 30 May 2017 03:27:02 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:35716 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750720AbdE3H1A (ORCPT ); Tue, 30 May 2017 03:27:00 -0400 Subject: Re: [PATCH v5 01/10] drm: Add drm_{crtc/encoder/connector}_mode_valid() To: Jose Abreu , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: Cc: Carlos Palminha From: Neil Armstrong Organization: Baylibre Message-ID: Date: Tue, 30 May 2017 09:26:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/25/2017 04:19 PM, Jose Abreu wrote: > Add a new helper to call crtc->mode_valid, connector->mode_valid > and encoder->mode_valid callbacks. > > Suggested-by: Ville Syrjälä > Signed-off-by: Jose Abreu > Reviewed-by: Daniel Vetter > Reviewed-by: Andrzej Hajda > Cc: Carlos Palminha > Cc: Dave Airlie > > Changes v2->v3: > - Move helpers to drm_probe_helper.c (Daniel) > - Squeeze patches that introduce helpers into a single > one (Daniel) > > Signed-off-by: Jose Abreu > --- > drivers/gpu/drm/drm_crtc_helper_internal.h | 13 ++++++++++ > drivers/gpu/drm/drm_probe_helper.c | 38 ++++++++++++++++++++++++++++++ > 2 files changed, 51 insertions(+) > > diff --git a/drivers/gpu/drm/drm_crtc_helper_internal.h b/drivers/gpu/drm/drm_crtc_helper_internal.h > index 28295e5..97dfe20 100644 > --- a/drivers/gpu/drm/drm_crtc_helper_internal.h > +++ b/drivers/gpu/drm/drm_crtc_helper_internal.h > @@ -26,7 +26,11 @@ > * implementation details and are not exported to drivers. > */ > > +#include > +#include > #include > +#include > +#include > > /* drm_fb_helper.c */ > #ifdef CONFIG_DRM_FBDEV_EMULATION > @@ -62,4 +66,13 @@ static inline int drm_dp_aux_register_devnode(struct drm_dp_aux *aux) > static inline void drm_dp_aux_unregister_devnode(struct drm_dp_aux *aux) > { > } > + > +/* drm_probe_helper.c */ > +enum drm_mode_status drm_crtc_mode_valid(struct drm_crtc *crtc, > + const struct drm_display_mode *mode); > +enum drm_mode_status drm_encoder_mode_valid(struct drm_encoder *encoder, > + const struct drm_display_mode *mode); > +enum drm_mode_status drm_connector_mode_valid(struct drm_connector *connector, > + struct drm_display_mode *mode); > + > #endif > diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c > index 1b0c14a..f01abdc 100644 > --- a/drivers/gpu/drm/drm_probe_helper.c > +++ b/drivers/gpu/drm/drm_probe_helper.c > @@ -38,6 +38,9 @@ > #include > #include > #include > +#include > + > +#include "drm_crtc_helper_internal.h" > > /** > * DOC: output probing helper overview > @@ -113,6 +116,41 @@ static int drm_helper_probe_add_cmdline_mode(struct drm_connector *connector) > return 1; > } > > +enum drm_mode_status drm_crtc_mode_valid(struct drm_crtc *crtc, > + const struct drm_display_mode *mode) > +{ > + const struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private; > + > + if (!crtc_funcs || !crtc_funcs->mode_valid) > + return MODE_OK; > + > + return crtc_funcs->mode_valid(crtc, mode); > +} > + > +enum drm_mode_status drm_encoder_mode_valid(struct drm_encoder *encoder, > + const struct drm_display_mode *mode) > +{ > + const struct drm_encoder_helper_funcs *encoder_funcs = > + encoder->helper_private; > + > + if (!encoder_funcs || !encoder_funcs->mode_valid) > + return MODE_OK; > + > + return encoder_funcs->mode_valid(encoder, mode); > +} > + > +enum drm_mode_status drm_connector_mode_valid(struct drm_connector *connector, > + struct drm_display_mode *mode) > +{ > + const struct drm_connector_helper_funcs *connector_funcs = > + connector->helper_private; > + > + if (!connector_funcs || !connector_funcs->mode_valid) > + return MODE_OK; > + > + return connector_funcs->mode_valid(connector, mode); > +} > + > #define DRM_OUTPUT_POLL_PERIOD (10*HZ) > /** > * drm_kms_helper_poll_enable - re-enable output polling. > Reviewed-by: Neil Armstrong