From: David Laight <David.Laight@ACULAB.COM>
To: 'Willy Tarreau' <w@1wt.eu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Sedat Dilek <sedat.dilek@gmail.com>,
George Spelvin <lkml@sdf.org>,
"Amit Klein" <aksecurity@gmail.com>,
Eric Dumazet <edumazet@google.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Andy Lutomirski <luto@kernel.org>,
Kees Cook <keescook@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
"tytso@mit.edu" <tytso@mit.edu>, Florian Westphal <fw@strlen.de>,
Marc Plumb <lkml.mplumb@gmail.com>
Subject: RE: [PATCH 1/2] random32: make prandom_u32() output unpredictable
Date: Tue, 1 Sep 2020 13:10:18 +0000 [thread overview]
Message-ID: <b460c51a3fa1473b8289d6030a46abdb@AcuMS.aculab.com> (raw)
In-Reply-To: <20200901064302.849-2-w@1wt.eu>
From: Willy Tarreau
> Sent: 01 September 2020 07:43
...
> +/*
> + * Generate some initially weak seeding values to allow
> + * the prandom_u32() engine to be started.
> + */
> +static int __init prandom_init_early(void)
> +{
> + int i;
> + unsigned long v0, v1, v2, v3;
> +
> + if (!arch_get_random_long(&v0))
> + v0 = jiffies;
Isn't jiffies likely to be zero here?
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2020-09-01 13:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 6:43 [PATCH 0/2] prandom_u32: make output less predictable Willy Tarreau
2020-09-01 6:43 ` [PATCH 1/2] random32: make prandom_u32() output unpredictable Willy Tarreau
2020-09-01 8:33 ` Yann Ylavic
2020-09-01 8:39 ` Willy Tarreau
2020-09-01 8:46 ` Sedat Dilek
2020-09-01 8:56 ` Willy Tarreau
2020-09-01 9:26 ` Sedat Dilek
2020-09-01 13:10 ` David Laight [this message]
2020-09-01 13:16 ` Willy Tarreau
[not found] ` <CANEQ_+Kuw6cxWRBE6NyXkr=8p3W-1f=o1q91ZESeueEnna9fvw@mail.gmail.com>
2020-09-14 16:16 ` Sedat Dilek
2020-09-14 16:29 ` Willy Tarreau
2020-09-14 16:48 ` Sedat Dilek
2020-09-01 6:43 ` [PATCH 2/2] random32: add noise from network and scheduling activity Willy Tarreau
2020-09-01 10:24 ` Eric Dumazet
2020-09-01 11:57 ` Willy Tarreau
2020-09-01 14:41 ` [PATCH 0/2] prandom_u32: make output less predictable Sedat Dilek
2020-09-01 14:55 ` Willy Tarreau
2020-09-01 15:19 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b460c51a3fa1473b8289d6030a46abdb@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=Jason@zx2c4.com \
--cc=aksecurity@gmail.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml.mplumb@gmail.com \
--cc=lkml@sdf.org \
--cc=luto@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=sedat.dilek@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®