From: Daniel Bristot de Oliveira <bristot@kernel.org>
To: John Kacur <jkacur@redhat.com>, Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>,
Clark Williams <williams@redhat.com>, Chang Yin <cyin@redhat.com>
Subject: Re: [PATCH] rtla: Fix exit status when returning from calls to usage()
Date: Fri, 4 Nov 2022 15:41:53 +0100 [thread overview]
Message-ID: <b4639b19-94e3-2128-643e-6a3a44a1d944@kernel.org> (raw)
In-Reply-To: <20221103135742.9523-1-jkacur@redhat.com>
On 11/3/22 14:57, John Kacur wrote:
> rtla_usage(), osnoise_usage() and timerlat_usage() all exit with an
> error status
missing .
> However when these are called from help, they should exit with a
> non-error status.
>
> Fix this by passing the exit status to the functions
missing .
> Note, although we remove the subsequent call to exit after calling
> usage, we leave it in at the end of a function to supress the compiler
suppress?
> warning "control reaches end of a non-void function"
missing .
Yep, that is a problem, and agree with the solution (I am already doing it
in the rv cmd line).
-- Daniel
next prev parent reply other threads:[~2022-11-04 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 13:57 John Kacur
2022-11-04 14:41 ` Daniel Bristot de Oliveira [this message]
2022-11-07 13:53 ` John Kacur
2022-11-07 14:20 ` Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4639b19-94e3-2128-643e-6a3a44a1d944@kernel.org \
--to=bristot@kernel.org \
--cc=cyin@redhat.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome