From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C04AA37C103 for ; Mon, 9 Feb 2026 14:59:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770649164; cv=none; b=aV30ldn0Cot8phsIJ21AqJYN7jFn99mGrhNtcyX5brn9kDmITl0Gt+4vZNZo3Vkvj/WQ+WJKWqo2qbOy2bMxyi1I1sEr3KezBB60UsSv50omwdczHwPgWVSNZu2M4dnJ0b60q1z9PFZ9IxMiWtQ/Ew3gCrADSmbnkqlMs0EZtRk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770649164; c=relaxed/simple; bh=WLVJv5ugIhf3VIIc7NthdDs9sjWvcntd5T03Up5qFVk=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=CKzNTTMnfoUFtwFifqvQXJEY/Zt2uFt1jTxAt+meAxuQvQOQeWtSgytsOeKtXjOdA+SSBg38Qkwn1Uirm5Ma7wItYXhi3axQt6IAGLwBkRF1zVIw7FR9JDGf/Pbsfjsxg464LtCCTqLzVBKeOBsIX5tSL5UufSNs57nhx1awuoM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GCn7TNxA; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GCn7TNxA" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-482f2599980so53044635e9.0 for ; Mon, 09 Feb 2026 06:59:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770649162; x=1771253962; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=TzlX62O2iHtDoc/wlp70TM/0Ovim/AGV2yahkY72zas=; b=GCn7TNxAhV7JVuZCQEXpIBPGk0F78lMJmLJMuOJgNtwmeNNbnh9PLCRgx8++yQNWTq BlczZkEtZTRiGASZvD1akuZrsEQVayDAcUD1yY+6exZENMCXQXdSAwh1mzh75FccSHwa pR/LFdCzQuIBQ8F2BdOfzRyBnVMq7/lWUc1THzkyoOFsE28kSX5IrS/WtynoaCwyMoyH hr7UPLMuS217FHUjTs9dS6+8XF+vLiUAG0WeOG/MkleX3WjSWZq+thky6hYNOdOQZX2n p70Xh8VJF/LyzhRxNp20dhfGK1ogOfrzI+3EVG+oQKdg4PKOG81g/IfonGk6jHSIu+Mh tekg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770649162; x=1771253962; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TzlX62O2iHtDoc/wlp70TM/0Ovim/AGV2yahkY72zas=; b=cazdv4AfMUS99v7jz8+Wsa9BvidhugjXlI67Kq0J9JIOyfY2bmVxHmJWZ5nqB3OIyq 3IwbWvuzc8pmKlZGnT7GVpnBF20rdWvj6RNM3u75IPtAMmy0HkAVibSWcXQiNCqlVTfC 3eJn8pVqhhUGB+QxbYu1aYVUOODq/nk793MMH7i4Cz65meMqESc4ScfSRmOHQm4hhKwh DbwIajt600NX9hG2o5vzTluB/e0VmZYF5Yv3sGJcczB6nSjRErvEjMnMBDu+s4tPdlrO MG6pXmalUCbN1/Qi5/iBOL4dVzn233OQi8OPmiKBAcjZlIHNjTUTzyGszJ65p7xYTxKB Q2wA== X-Forwarded-Encrypted: i=1; AJvYcCWp9vyukOLHnOOk4XkRpTOQXRCkdrDFF6HDmS6c11bkXvqR+21TFMFV+aJOzNIcs0LInAOr1aRbzusxOAM=@vger.kernel.org X-Gm-Message-State: AOJu0YysaZIoUiSh64xGTdg+9/YUIJo+nWL2FhEmY3q+fwGzX17yuXH3 OpPcPeGUgdTOfUOQYI4HHQOCIe/VY5w16qSi01xy9cKiTDRIH3PVkOxTc6FyasBdeXk= X-Gm-Gg: AZuq6aL8Q31uBwq4tS3fA9vlyJOng5KWmrJs7c0EpZc4VLf+7RIofpv2IZ1jbMd3aOd 7SJoJSsozUq4z+B+RIIlT830uw1nd/Ap9A+8ZgBIoz/cQ7gPNl05GBceWO46xCvu3x6ULdK9v7s f1wcSVQwG1b7/b6h+yeVjB2emsNmGuaOPtdYU+Q77fnQLHMTwkRTysPVYHr7iTn6Rt6bWNXYFt9 8bIUD15/Z9NwtRyECO2lMaOo8p2f6FQKZMUa5Wx8nSLprMxS33isPSaBQHF0GuK24Apl/mlgiwi Z5CIc0GGVgjPdJp8GOMyiNonVVGFsno7KTlSW0ZVlZcyPH+/K700Yn8DJR/mNUQ9TbjIAC17+Vg CPCsmJvTzU6BbvBUaU6jjsRIhpHOYB3vA+o1J9nwBtAAZjNEtpLLFiTXhp4Qo2MnRAeoohCgwdM oEFkUjAxqqMgbq48PwRhCz+zI7dQkx1fxNRHldeQEGMlAhvSS3FxiX8HKoqLuO0u4= X-Received: by 2002:a05:600c:8719:b0:482:eec4:76d with SMTP id 5b1f17b1804b1-4832021b461mr184052445e9.17.1770649161961; Mon, 09 Feb 2026 06:59:21 -0800 (PST) Received: from ?IPV6:2a01:e0a:106d:1080:44e3:9198:bd5d:a3f? ([2a01:e0a:106d:1080:44e3:9198:bd5d:a3f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4376bd5a074sm10377353f8f.11.2026.02.09.06.59.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Feb 2026 06:59:21 -0800 (PST) Message-ID: Date: Mon, 9 Feb 2026 15:59:20 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v3 4/9] pci: pwrctrl: generic: support for the UPD720201/UPD720202 USB 3.0 xHCI Host Controller To: Manivannan Sadhasivam Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Bartosz Golaszewski , Bjorn Helgaas , Bjorn Andersson , Konrad Dybcio , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260206-topic-sm8650-ayaneo-pocket-s2-base-v3-0-5b79c5d61a03@linaro.org> <20260206-topic-sm8650-ayaneo-pocket-s2-base-v3-4-5b79c5d61a03@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/9/26 15:49, Manivannan Sadhasivam wrote: > On Mon, Feb 09, 2026 at 03:00:02PM +0100, Neil Armstrong wrote: >> On 2/9/26 12:30, Manivannan Sadhasivam wrote: >>> On Fri, Feb 06, 2026 at 03:50:32PM +0100, Neil Armstrong wrote: >>>> Enable the generic pwrctrl driver to control the power of the >>>> PCIe UPD720201/UPD720202 USB 3.0 xHCI Host Controller. >>>> >>>> Signed-off-by: Neil Armstrong >>>> --- >>>> drivers/pci/pwrctrl/generic.c | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/drivers/pci/pwrctrl/generic.c b/drivers/pci/pwrctrl/generic.c >>>> index 08e53243cdbd..4a57a631362f 100644 >>>> --- a/drivers/pci/pwrctrl/generic.c >>>> +++ b/drivers/pci/pwrctrl/generic.c >>>> @@ -73,6 +73,10 @@ static const struct of_device_id pci_pwrctrl_slot_of_match[] = { >>>> { >>>> .compatible = "pciclass,0604", >>>> }, >>>> + /* Renesas UPD720201/UPD720202 USB 3.0 xHCI Host Controller */ >>>> + { >>>> + .compatible = "pci1912,0014", >>> >>> No need to add the compatible to the driver. Just use the existing compatible as >>> fallback in the binding/dts. >> >> ??? >> >> Sorry but this is insane, in no world a standalone PCIe USB controller could be qualified as >> compatible as a pciclass,0604 slot. >> > > AFAIU, 'compatibility' implies that the driver can safely fallback and would > still work. If we add dedicated compatibles for each endpoint devices, then we > will just keep adding forever. Powering up a PCIe slot and an endpoint device > are conceptually same. We're not speaking about driver here, but about compatible string which describes a device, a PCI endpoint and a PCIe slot are 2 very different devices that are nowhere compatible. > >> Technically it would work just fine, but "compatibility" has a meaning.... >> > > I view compatibility interms of device operation, not device as a whole. But > sure, I could be wrong. If the DT maintainers say so, I won't insist. In the actual way it's defined _today_, the "slot" and "endpoint" power up schemes are compatible, but I hope the slot bindings will get much more features to describe the real world slots power properties. And no, endpoints will definitely not have the same features as slots, using it as a fallback today is an error. On the other side, adding a "simple-pci-endpoint" compatible that enables any supply and clock would be a good solution, if the DT maintainers agrees of course. Neil > > - Mani >