From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751056AbdE2Fkd (ORCPT ); Mon, 29 May 2017 01:40:33 -0400 Received: from mail-lf0-f43.google.com ([209.85.215.43]:34998 "EHLO mail-lf0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751028AbdE2Fka (ORCPT ); Mon, 29 May 2017 01:40:30 -0400 Subject: Re: [PATCH/RFC] iio: hi8435: do not enable all events by default To: Jonathan Cameron References: <20170523080830.20571-1-nikita.yoush@cogentembedded.com> <20170524202735.3cf4e14e@kernel.org> <2e6019f5-94fc-bb13-f616-0c1cfe81a7db@cogentembedded.com> <20170528164846.3fa3d4d8@kernel.org> Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Sanchayan Maity , Gregor Boirie , Matt Ranostay , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Healy , Jeff White , Vladimir Barinov From: Nikita Yushchenko X-Enigmail-Draft-Status: N1110 Message-ID: Date: Mon, 29 May 2017 08:40:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170528164846.3fa3d4d8@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Still, isn't there subsystem-level default that all events are disabled >> by default? If such, then current hi8435 state breaks subsystem-level >> rules, which is a [userspace-visible] bug. I'm not sure how far should >> we go in bug compatibility. > > It is indeed the subsystem default (as much as we have one) > > This is a moderately obscure chip for linux systems, do we have a good handle > on where it is being used - i.e. are most of the devices under control of > people we can discuss this with? Company I work with, uses this chip in several boards; what they need is a service that monitors all connected chip's outputs and detects changes. They originally wanted gpio-style access to use with userspace polling, and were not pleased with entire IIO thing. However it's important for them to minimize required kernel patches against mainline, thus if mainline supports this chip as IIO device that's ok for them. Questions like default event enable state has little practical impact. It's more about keeping architecture clean. Nikita