mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: E Shattow <e@freeshell.de>
To: Hung-Chun Tseng <alan.tseng.cs@gmail.com>, Yixun Lan <dlan@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] riscv: dts: spacemit: mark K1 board boot devices bootph-pre-ram
Date: Wed, 21 Oct 2026 04:07:34 -0700	[thread overview]
Message-ID: <b47b95f6-600b-4b0c-8aca-acd7c75d5d07@freeshell.de> (raw)
In-Reply-To: <20261021110001.2905669-1-alan.tseng.cs@gmail.com>

On 10/21/26 03:59, Hung-Chun Tseng wrote:
> Hi Yixun,
> 
> Yixun Lan wrote:
>> but for bootph-pre-ram, isn't it about the DT nodes which needed before DDR
>> initialization in SPL stage, and should have nothing to do with BootROM?
> 
> Thanks for checking with the vendor. I agree, the schema defines it as
> "the phase that sets up SDRAM".
> 
> I also need to correct what I said earlier: the EEPROM is not only
> used to tell the boards apart. It also holds the board's DRAM
> configuration (number of chip selects, data rate and DDR type), which
> has to be read before DRAM can be trained [1].
> 
> So in v3 I'd like to keep the i2c2 and EEPROM tags, and also tag the
> EEPROM on the OrangePi RV2 and R2S, which I missed in v2.
> 
> E, does that address your concern?

Yes, as based on published documentation and confirmed by vendor, that
sounds good to me.

> 
> [1] board/spacemit/k1/spl.c in U-Boot, ddr_early_init() -> read_ddr_info()
> 
> Thanks,
> Hung-Chun

Thank you Hung-Chun and Yixun,

-E

      reply	other threads:[~2026-10-21 11:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-17 18:01 [PATCH v2 0/2] riscv: dts: spacemit: mark K1 boot nodes bootph-pre-ram Hung-Chun Tseng
2026-10-17 18:01 ` [PATCH v2 1/2] riscv: dts: spacemit: k1: mark boot-critical SoC " Hung-Chun Tseng
2026-10-17 21:05   ` E Shattow
2026-10-18 14:08     ` Hung-Chun Tseng
2026-10-19 14:17     ` Hung-Chun Tseng
2026-10-17 18:01 ` [PATCH v2 2/2] riscv: dts: spacemit: mark K1 board boot devices bootph-pre-ram Hung-Chun Tseng
2026-10-17 21:44   ` E Shattow
2026-10-19 14:17     ` Hung-Chun Tseng
2026-10-21  8:34       ` Yixun Lan
2026-10-21 10:59         ` Hung-Chun Tseng
2026-10-21 11:07           ` E Shattow [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b47b95f6-600b-4b0c-8aca-acd7c75d5d07@freeshell.de \
    --to=e@freeshell.de \
    --cc=alan.tseng.cs@gmail.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®