From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8BBC71FCFE7 for ; Wed, 8 Jan 2025 14:48:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736347734; cv=none; b=Ls/SNd3en1vBeePuIXXMIbnIkXPkvdmdAxNqXQR0IM+L9otuJw8+inLBudjih95gf8RAtnLlBWqvAquuZ2gdLAP8AYHV+FaixTnh9gDRryWtCKEuMCi5gMS8or/VcbtOe9xXYbg22Y6UxoQuNBBO6nY/60Y9zJQgeYyxUcNVqS0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736347734; c=relaxed/simple; bh=vO5o9AV2alya7VOBTFwgxs2ni6BLNQ8QUKxsWGoIKoE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Bi4HaCmMAY5lOEkmivDy3HR7L0WhbQgfsJOxyLdNalRUe6ZnzBgoqOKUYDHt5Q39SbrVBv4ePv+swDO48NqAYxZ4YgOOpDVnBpoDp+T+IfcSSSrwU9OuFw88Xox2nfjrpwUWTPifgqMXaeAP5jhir2ezbelXOImYOINjgaGLx9I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0826B13D5; Wed, 8 Jan 2025 06:49:19 -0800 (PST) Received: from [10.57.5.66] (unknown [10.57.5.66]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B01A13F673; Wed, 8 Jan 2025 06:48:48 -0800 (PST) Message-ID: Date: Wed, 8 Jan 2025 14:48:46 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/panthor: Remove dead code To: Florent Tomasin , Boris Brezillon , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: nd@arm.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20250107173310.88329-1-florent.tomasin@arm.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20250107173310.88329-1-florent.tomasin@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 07/01/2025 17:33, Florent Tomasin wrote: > Remove unused function declaration in panthor_gem.h: > - `panthor_gem_prime_import_sg_table()` > > Remove duplicate macro definitions: > - `MAX_CSG_PRIO` > - `MIN_CS_PER_CSG` > - `MIN_CSGS` > > Signed-off-by: Florent Tomasin Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_fw.c | 1 - > drivers/gpu/drm/panthor/panthor_gem.h | 5 ----- > drivers/gpu/drm/panthor/panthor_sched.c | 3 --- > 3 files changed, 9 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c > index 68eb4fb4d3a8..4a9c4afa9ad7 100644 > --- a/drivers/gpu/drm/panthor/panthor_fw.c > +++ b/drivers/gpu/drm/panthor/panthor_fw.c > @@ -201,7 +201,6 @@ struct panthor_fw_section { > > #define MIN_CS_PER_CSG 8 > #define MIN_CSGS 3 > -#define MAX_CSG_PRIO 0xf > > #define CSF_IFACE_VERSION(major, minor, patch) \ > (((major) << 24) | ((minor) << 16) | (patch)) > diff --git a/drivers/gpu/drm/panthor/panthor_gem.h b/drivers/gpu/drm/panthor/panthor_gem.h > index e43021cf6d45..5749ef2ebe03 100644 > --- a/drivers/gpu/drm/panthor/panthor_gem.h > +++ b/drivers/gpu/drm/panthor/panthor_gem.h > @@ -85,11 +85,6 @@ struct panthor_gem_object *to_panthor_bo(struct drm_gem_object *obj) > > struct drm_gem_object *panthor_gem_create_object(struct drm_device *ddev, size_t size); > > -struct drm_gem_object * > -panthor_gem_prime_import_sg_table(struct drm_device *ddev, > - struct dma_buf_attachment *attach, > - struct sg_table *sgt); > - > int > panthor_gem_create_with_handle(struct drm_file *file, > struct drm_device *ddev, > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c > index 77b184c3fb0c..5844a7f639e0 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -88,9 +88,6 @@ > > #define JOB_TIMEOUT_MS 5000 > > -#define MIN_CS_PER_CSG 8 > - > -#define MIN_CSGS 3 > #define MAX_CSG_PRIO 0xf > > #define NUM_INSTRS_PER_CACHE_LINE (64 / sizeof(u64))