From: Sudeep Holla <sudeep.holla@arm.com>
To: Sekhar Nori <nsekhar@ti.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Russell King <linux@armlinux.org.uk>,
LKML <linux-kernel@vger.kernel.org>,
arm-soc <linux-arm-kernel@lists.infradead.org>,
linux-drm <dri-devel@lists.freedesktop.org>,
linux-devicetree <devicetree@vger.kernel.org>,
Jyri Sarha <jsarha@ti.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
David Airlie <airlied@linux.ie>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH 1/3] of: base: add support to get machine compatible string
Date: Wed, 23 Nov 2016 12:15:37 +0000 [thread overview]
Message-ID: <b47cd425-ea89-31ff-5b99-dea27bea2d14@arm.com> (raw)
In-Reply-To: <11467504-c700-cbfa-a945-be9ec8776144@ti.com>
On 23/11/16 12:13, Sekhar Nori wrote:
> On Wednesday 23 November 2016 05:37 PM, Sudeep Holla wrote:
>>> So, the if(!of_node_get()) is just an expensive NULL pointer check. I
>>> think
>>> it is better to be explicit about it by not using of_node_get/put() at
>>> all.
>>> How about:
>>>
>>
>> Are we planning to use this in any time sensitive paths? Anyways I am
>> fine removing them.
>
> Not worried about the time taken as much as it serving as a bad example
> and getting carried over to other places where the impact might actually
> be real.
>
Ah OK, sure.
--
Regards,
Sudeep
next prev parent reply other threads:[~2016-11-23 12:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 10:41 [PATCH 0/3] ARM: da8xx: fix section mismatch in new drivers Bartosz Golaszewski
2016-11-22 10:41 ` [PATCH 1/3] of: base: add support to get machine compatible string Bartosz Golaszewski
2016-11-22 10:53 ` Sudeep Holla
2016-11-22 10:57 ` Bartosz Golaszewski
2016-11-22 10:58 ` Bartosz Golaszewski
2016-11-22 11:06 ` Sudeep Holla
2016-11-22 12:17 ` Sekhar Nori
2016-11-22 15:06 ` Sekhar Nori
2016-11-22 15:46 ` Sudeep Holla
2016-11-23 7:49 ` Sekhar Nori
2016-11-23 10:05 ` Sudeep Holla
2016-11-23 11:47 ` Sekhar Nori
2016-11-23 12:07 ` Sudeep Holla
2016-11-23 12:13 ` Sekhar Nori
2016-11-23 12:15 ` Sudeep Holla [this message]
2016-11-22 10:41 ` [PATCH 2/3] bus: da8xx-mstpri: drop the call to of_flat_dt_get_machine_name() Bartosz Golaszewski
2016-11-22 10:41 ` [PATCH 3/3] memory: da8xx-ddrctl: " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b47cd425-ea89-31ff-5b99-dea27bea2d14@arm.com \
--to=sudeep.holla@arm.com \
--cc=airlied@linux.ie \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=jsarha@ti.com \
--cc=khilman@baylibre.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome