From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932626AbeAHTQp (ORCPT + 1 other); Mon, 8 Jan 2018 14:16:45 -0500 Received: from mail-bn3nam01on0053.outbound.protection.outlook.com ([104.47.33.53]:6816 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755602AbeAHTQO (ORCPT ); Mon, 8 Jan 2018 14:16:14 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Felix.Kuehling@amd.com; Subject: Re: [PATCH] drm/amdgpu: use %pap format string for phys_addr_t To: Arnd Bergmann , Oded Gabbay , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= Cc: David Airlie , Harish Kasiviswanathan , Andres Rodriguez , Kent Russell , Jay Cornwall , Flora Cui , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20180108125440.4052836-1-arnd@arndb.de> From: Felix Kuehling Organization: AMD Inc. Message-ID: Date: Mon, 8 Jan 2018 14:16:07 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180108125440.4052836-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-CA X-Originating-IP: [165.204.55.251] X-ClientProxiedBy: SN4PR0201CA0041.namprd02.prod.outlook.com (10.162.76.27) To CY4PR1201MB0229.namprd12.prod.outlook.com (10.172.78.150) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 35673909-58cc-44ac-d9cc-08d556cc47f1 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:CY4PR1201MB0229; X-Microsoft-Exchange-Diagnostics: 1;CY4PR1201MB0229;3:0aX+R3G/sO0XHJHILurVc4Ko6J1VTrRvWXpEPiMKEBLUVrztGlMI8HlvtYMkiZCRAPZRH+5vyVEO7GugOrtdiu1rrslCob42+/SPSWEe8pOQGQBlP7QAQRdA9tli3+W9vVC2GAaFJlAAe5fB2DbhxFu9/MXSgr2YJhV3QZ05vX/MdkVZqcL5lOxXr0sB1Cyb4EUcCt/tANWvqFIKGA0fQe/vCtEScLFNt0nOlKUTfP2UIIhKz0pfNJoYpNWvsz+n;25:wufV4+CKh8RTHDEB/QU+1v/P1Uyr0timK0nhepXG1VzJZfEWExcxQLxqM90W9mvcixSjEQ2FP4HUREUUGqI1UvpWU9aIN1eNhf5q6A0z0aoc4BiA8bPtskOQ5unEQFzA7OoEJ5/wpoLOr0nv/cVp0gxxe1YW892pdfnFJ+ntRw5rQcRlCLsI5/ZdFicViPbHFRnA5IFh/CpLdP8lZZOxLwDStvv6ESr8g5P1v8e5KJ6Zd3e3/4P/I6GmHFeROtjhZ+lkn4F4oaMfEMh+LNqi7ryfsx8PxPRj/cGwJ4aYyjEqxOOGQhY8urya8znciymO//G4gg8h/ehYT9209nSFUA==;31:unSJ/oQqQnZEGpTVOum2Hihhjd/70Pt3Z46tr9ewd/kuGKp1KbbXLIoDR/rpsSo6DXa7971RK4GNMtMswYB9MvmeFAAPSy1bUO5IcpB9W2J8QjegYseJJdkxCd1E1k5Yid/EChE/XSKv3wK10CZtE3hyMuiX96MFSjGeLzFhnTlS1MiTBh4F24cRtQyID/5xZXwGYF13m9eCsL/m4DqNxz1357wkD544LmA64qZNtSg= X-MS-TrafficTypeDiagnostic: CY4PR1201MB0229: X-Microsoft-Exchange-Diagnostics: 1;CY4PR1201MB0229;20:RQ+bnky0okcmnAe0t9OnV6KAO9KxAs3dH8ThysmOpFpzetRSaBTF1hU1RaMRrFpjyTza7oq5Rdy5seFOQcHbv3DsKT/CESDr6zwsEsiGoncaW3S3rFIrJEI+RziZidTQKA9W/qS4u1FYkFCPko1jSN1NBCsUWIkLRDVGJD8fnkj3s9BycyuASclJAvpkcE1yhk5SsQhxtLbMg0NWL0EfdUh2TgLKml4SivY2BPWjCwzHr0sEw8CQLmVYbiaPV80ipZ7T7iJUH/TB7+umIIIQiFKrAqyx06zMFZtL5pacQqz6OQL5/PNv59ezP5p7h1sfugyzaMJuHmi3jks3WsWqfLXBH7KoAjx4vVoBh81rT8F87/PJDSnV+49ZtQ1wFraFa8nGDA5Lxz1J920rnNvO/pz3vYYmD5NQBlhs80sH9OQxqfykTec35JgIov85W5t47IBRtwy97kdWVfWgY5SA3ZO5q/PXxwxLfPfVaQvJLfflQiNHIOgmTa3bxaMd5HeV;4:eoBcSCD84l02MepDJ4Roj739MLCli53Z2syJiq7msvf1u5Uw1FgePJtIKM2Q/jkLRN3pWsUeqYpMcvGfjPuuDdIY/fLXLTSfMAE37p8cgvrppf/OhAMtNS3FHCwm8Kmvykm9yW/Wnh2AbvXZ3Yq2/3QO9ajUnCbEFq0uWRR2rVvM7u6UjANs22hi4GpD8B2rgIu5QZdZthLAKAp4rLCohf8xiptyJoWQHaXj1zcet0yLCbaTGiA2BULiwnEvZf6j4Bm3UrEgaKZZRrutYYvYJPKPeffWVZ/i1Thb6q8r48M5+/G5gDz6AntnxG04rwbF X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231023)(944501075)(6055026)(6041268)(20161123558120)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011);SRVR:CY4PR1201MB0229;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:CY4PR1201MB0229; X-Forefront-PRVS: 054642504A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(346002)(396003)(366004)(39860400002)(39380400002)(376002)(377424004)(24454002)(199004)(189003)(76176011)(2950100002)(105586002)(53546011)(7736002)(54906003)(106356001)(23676004)(31686004)(52146003)(86362001)(36756003)(39060400002)(6246003)(58126008)(110136005)(83506002)(36916002)(65826007)(65806001)(59450400001)(2870700001)(47776003)(16526018)(2486003)(97736004)(5660300001)(65956001)(66066001)(305945005)(25786009)(386003)(52116002)(6636002)(6666003)(4326008)(478600001)(8936002)(53936002)(81156014)(8676002)(3846002)(81166006)(6116002)(68736007)(16576012)(72206003)(31696002)(50466002)(6486002)(64126003)(2906002)(316002)(90366009)(77096006)(229853002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR1201MB0229;H:[172.27.225.16];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjEyMDFNQjAyMjk7MjM6ZGJKSzBnNnF4aVFPbTBvWjRFS01XT0Ez?= =?utf-8?B?Z3I1NVF6bTIvZEY3V3k2M3JZSlMvYW9XOW95d3hNa0hRdlpKRHcrcEIra0tM?= =?utf-8?B?QTRNNDZpNkF1ZGVFdWdiZ1QwTlJCWnlvYlNHcEJzTVg1ZGJMUmpKMDIvNUdB?= =?utf-8?B?c3RSRmV5U1R5RklKcmJYem1FT1JDTTM1enVJR09YbWZSaWFibUs1dy9CNnFU?= =?utf-8?B?em1qM3BXd2tqYkpmY1pDSEE1elVUOFNBYWpSYjJRd0FwT1gvSEp5M1IwelNU?= =?utf-8?B?YUliVTFENUhHSFd0MXNmbmpZRzMvcGtKLzY2SG50U0pJVG5DRXpFSWRTRzB5?= =?utf-8?B?ZXI2dGpibmhRTnJYS3R1OUVWNURCVmZWemtzNE9iSUxEV3FSUzAxbEQ4b0dR?= =?utf-8?B?YVZYRzVRVU9zOURPN0lMempLdEpYNGVoSjVUUFZKWVVwQWxvMjhOT2FIMTFo?= =?utf-8?B?WmR6OGwrenFxYitJOWZsYlFQeHU0amt2d28rT21vQm10SWJ0bGVqRWprbUlN?= =?utf-8?B?Q3FTWVBpZ05rb0Q2TGlGb3F5ZmRlSEY4Rml6dmdOTlUxMEtTS1FzYVFQZkNq?= =?utf-8?B?SHRTdW1vN3ZBckNPWUdTZCtkckRxMyswV21weXdJWkFIR2xYYy9hRXFnbzBI?= =?utf-8?B?RDZQMlp3ZElKdE1RK0tzcHpkUjlIZE5ZTnJFZEpWbFJBRzVydjVPSVdha0FG?= =?utf-8?B?OVpqTDIzay82OThwckNqSEVndk0zL21ZdkExY1d0MlVPczB1RzFERStIUXJ0?= =?utf-8?B?YlgvSlJSQWkrYkUzbGR6QjJvdmZFZDJ3TXhITGY1ejBvMEc2QjlwVU1vbVAw?= =?utf-8?B?anV2V3dFTUZuZFRBRFlPemZ0T1o3cHk2Nm5UTlZOK0dmdk5TSS9MZGFtaHJx?= =?utf-8?B?MVh4cGJTTUYxZW9UbEIwRkJtOWVLNnJKQUVONXJQT2c0bFpZVWpsUW44VzZ4?= =?utf-8?B?TEZLbFhoSE96b3JRU2FBdGdHMFZDKzl5emZvWWhUdkc1VDcrWUltOWswVWgv?= =?utf-8?B?Rk45VUFMV1NGQ0tMT1RKRmkyYzZyaC9JYitoNkwvSWttYnEvQTAwNlNMVFlY?= =?utf-8?B?MXhHSTZ3d3BaYVRQQmgzZlpIMStQbDRudGZpZGR2cGJnMVVBVisyL0MwMUEw?= =?utf-8?B?SEVDRlV2dmRZT000d0hsdzJuTGVVZDROaldOUmtCdlM2R1JDc0ZqM3dBbTdG?= =?utf-8?B?MlgrK1IvdUhIRzFsRjV6YWdOdm5HL2VoaWZVVkJwL3hWMnNBRlZyODRkcllt?= =?utf-8?B?b2dPWS90Z3I1Rnk0bktaRWpiSVpGeXpMQ1pHUmJSWUIrNUNMTktraWllaUhv?= =?utf-8?B?Mlc1S0ZTZzlGVy9EUnJuejN4NThWdXNURHdzM1JyUytJN2o5MFVidlFIMXJI?= =?utf-8?B?NXFYTm1ZTHZnOVBuT3NNcmF1YUE5bHhEemdOVEdhRGNNUE81Zmk1QUduS3N6?= =?utf-8?B?cys3dnBGMkx3M3RheWFmNWcrSFdNczZkemdpVTVXanlRRFNnNVNnRVBZakMy?= =?utf-8?B?U3l6NEtwSWZJL1BvM2hrWVgwMW9PUVBoV3pwSllxY2tWa1RiVTZBUWNZNGpx?= =?utf-8?B?d24zbGdqNmpBVXY2c0VQc0t5cnlCVldEbjhiSUI1aUpUd3Q2MVFraGZsdHBP?= =?utf-8?B?T1MzUUVCSG9pNjZOZTNWL1g5Z1ZWWDR3bWF6ZVRsZFhLQU9jenBoY2k5SUJr?= =?utf-8?B?ekpscTFhaTVLVWhiYTN5YjcraVU1b0hrK25iYlBmdkNiMWdvcCtuYTJHajQy?= =?utf-8?B?WkpRN1hTNWhVdGRabzU4Y1hTMU93RTZPbStXZlRWOGsyMlR6V1d4bEZxWmZ0?= =?utf-8?B?SngrTVY5K3UyWGlQSVptNTFxdjdRemFDdzhHRE1DMW5TbVdnZDBxQVhmWm9Z?= =?utf-8?B?enlxTEQ5TWhnKzlxa01kMmgwc3hHc1BneXoxZkR5NDdXTmdyZUhwL2lqWStj?= =?utf-8?B?eHNaUzlJdzl3ZzA3UkdhbnFiV0ZDTVZwbDY5enY2dGNCZ0w5c2cvVm12MWtw?= =?utf-8?B?OE04T1ZaQkd4WU5kVExlTGtFUDlpZXo3SFJYRldVSVNEZXJ0VUJPYU8rTkZy?= =?utf-8?Q?NzqufcDmk71hx3bYLXiW54eE4kV?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR1201MB0229;6:uWuUN71mqagTRtN9T5+9Ta7azMGG4RaEYpAh1HyfbeAn8CTYiKrMJvaulfZxti7fz1kJMgYOUo9kbQMwiBoKBi40yE5eXGK66sF4bx/EynqwzeGm5xKjRmPlWzfD6AmLQFScfVgVrdRmvBidNP5v4mgcSiVNhSR+BAZcshNNfB6me9gUz3AG0VPbEBgf7MsvPcJsnY85IXkQhNojplkoHeia+ndCfYkyoeE2TFZWaWfcFfjEAYZSPpRn2mMEgmnUtm5tYXGD7ECYEprn2JUcpfflDWuSj6kKLU4DD3getKAFSsW/wsAmHjbXyNJeBmfMlVpLvYx3Vv8C6ZHOZWo5PNTxfhldX8ICxGVRJ7QpnPo=;5:n9lsfYEs3zosNVUFBqbCVZyLcDeqPAunW7i29X1tAi9Ksoi2Svkr00qgCT00vv4ZePGtonveEnGVfiomr9u6ZZsqpj4Yh9B5qjLMXZGeSw3OocxGLGcS1HJflecGOX2QqdR5PyIvViWOhHt30y0RiUvb/uHTJZ3+nF/Guze/M6U=;24:3jrzNiztrO/sM4ky35ZH+t2t6LqrNdK6+PBkO0KFs62YcvrwbsCElO/LZzBQ9ouKtJK1lBfvRiPSLZOcubJ90avDoSsJ4PrudoweauEVptk=;7:o5sOi06Pm+6yVS69etHiYkf0kCEHOaTANpLT63V2TPh1v/Cg6t6/IMpSG6c4TdEv1LUJpf3X7Ax8+kpNt3VgZWDZvPFa9uQCK5ftGcGlc3zB9UHTUoiicH4cuk6LwFtEPG4gNJ5HFTgSBDcH6LDsmNCD1w8rrm0Lbw2JaezGtJ9tu9TF65/RLUzaWpDtHdyfeO6ynQUa45a2nvDH0UlaY53FD8gHM5nrq9pdiVXHoP8RYxSRf3AFhFZunSKIo/hE SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR1201MB0229;20:KXMbK+2N/RF4EdCCV9PYPwivQKf2YVDud3hKZQA1ljpSd+Xgd7Z5uMx79jgQJwE8F0S0Jkc6qTyriwYAl4zgsKkN4LJduu2yfaCxt6n7GaQ8sEF1mGIW7hllrMCw1JR5q7w4B92Wszc96gQTfRHiRpPUFc/CEBj9QdFtjXBNDTccreLNjghew/f+2ggrFfEUCyCwBSuvgYsq7N8+iSlGXZ2iuLM4LADyQ2F/dgoVUQOLZ7KkRzsXKs26LZ37M8po X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2018 19:16:11.1736 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 35673909-58cc-44ac-d9cc-08d556cc47f1 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0229 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: This commit is Reviewed-by: Felix Kuehling Thanks,   Felix On 2018-01-08 07:53 AM, Arnd Bergmann wrote: > The newly added get_local_mem_info() function prints a phys_addr_t > using 0x%llx, which is wrong on most 32-bit systems, as shown by > this warning: > > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c: In function 'get_local_mem_info': > include/linux/kern_levels.h:5:18: error: format '%llx' expects argument of type 'long long unsigned int', but argument 2 has type 'resource_size_t {aka unsigned int}' [-Werror=format=] > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c:297:31: note: format string is defined here > pr_debug("Address base: 0x%llx limit 0x%llx public 0x%llx private 0x%llx\n", > > Passing the address by reference to the special %pap format string will > produce the correct output and avoid the warning. > > Fixes: 30f1c0421ec5 ("drm/amdgpu: Implement get_local_mem_info") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c > index 335e454e2ee1..1d605e1c1d66 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c > @@ -294,8 +294,8 @@ void get_local_mem_info(struct kgd_dev *kgd, > } > mem_info->vram_width = adev->mc.vram_width; > > - pr_debug("Address base: 0x%llx limit 0x%llx public 0x%llx private 0x%llx\n", > - adev->mc.aper_base, aper_limit, > + pr_debug("Address base: %pap limit %pap public 0x%llx private 0x%llx\n", > + &adev->mc.aper_base, &aper_limit, > mem_info->local_mem_size_public, > mem_info->local_mem_size_private); >