From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65E5132F748 for ; Wed, 3 Jun 2026 13:10:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780492242; cv=none; b=o+G+WaRpQDwyAfCSk+BOpCnkUfx41nGil2vCqZ6dQkoMnMrVlKUu/Ky5kSg9Pnz0feyl8qw79AP8ZvySi8aAKTUchGHk2Hp2EtD7QTeSvhxLNozLDoqRMPHkDuODz77CZuVegLjxPz5F2V001nirRbpSxR/qFJML6Smyz6/OPNs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780492242; c=relaxed/simple; bh=DA2FW+m2bWueyUDMLsGb7KZj+YBbfbYQwznE2VUZHeY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=arf2aJhmc0sEPjjIc1UXz2e0rdAabRUVfvAHItTeutdOLq4mc88zhOjo2s6TiOvF5Is726/x1sEFryMelnejRGETI4JO7cS1T1TI3ihFtyXZ+umYZ4AlFwSorIfGLHPyyusZjqMR7vYkFkqj7OYBHBNSMKA3CtjHXJZSJO2+NjA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tzOZ5zSw; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tzOZ5zSw" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-bec43ee8ff0so111247766b.1 for ; Wed, 03 Jun 2026 06:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1780492239; x=1781097039; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=X1Ude0q8UJNEq/jv9daxrUZHrb0trlAcIj1CVfNsKe4=; b=tzOZ5zSwVVEsQSIcpKmLO1Z47lE42mK5pFQSe8jtORpBnPY/hute9iWahmsiIAmGV1 OrjVeFrqPgaSXPXiV92pmUj/Kc67Wo9wK0E9asWP0yJf05LrbFM4CHFX6+wjKIKb8d+e v/paP1p/I4CiwvoAt7lSnAIYXHBamY8cOSqgYFu2+2Pg8XVnQWbUDWtNKiZmVM8aLAuS Ef6/InC8nNsu2D4ZSmR0R4FzQNUmefTb8reqLWDfJQ6GqKnHfjbQZxM2guWOZyy5umnL H6xg313ByCl+bsbcneWHPVae38sEMxokG1iwSsvlOjsNYLlhgqqaZ6Qb3Ka0Tq4gcrwA E+GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780492239; x=1781097039; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=X1Ude0q8UJNEq/jv9daxrUZHrb0trlAcIj1CVfNsKe4=; b=S35TtkSdkpJ/vgxBKehg1fAIbAZWEJVLPFfOKk6GKdhAuT+VEFuqopQwCI36gEZPB8 NR024BBHhQGLzUdhgB0+JRG040QhfFlZeRw5JoN7vZG81NEcs+VIhRL/r+t1dqQippaj 0/mcGiU8hl75ZZ8gWvTxHnI0wih8/piG4LXTwltbM4PC7LV10xGV0D/AyIubxE9UusWN tRTF+YNseNiGLPDNyUFa2JGZOSOT7+olVobLjdsEzCHLMcB+vrbW0QyY3JzxGurYB17C OB4uxbGoOcJEv0LxZE4pHgwy5nTpWDKJM3C8xvuHCK9k+UHQzHcS8QN/U8ql4Dif8BdK 7V7A== X-Forwarded-Encrypted: i=1; AFNElJ8JBXSXw74HKq9uZvKaDN0qrEQkXsFXxDm/UO1zqCCfBmCPiJh2+Tt5sr/VuJGMqO4RFH5NysPfkcCjc/k=@vger.kernel.org X-Gm-Message-State: AOJu0YyDAYnc6El+5DAVDcwnLGoZ95t66sPkIYdlzQeTPnPQbitVFZdj fjwPbIalhj+zuqJyymsD97Nqqd9qrz+pY3CfQf17fS0V7Qx95dnxBPcLmybjz24fkCB2ZLueqaX 7yiKCtHY= X-Gm-Gg: Acq92OFzijhSoeNGfwtL8kCTJATh4Ktxo290/JZnlEsYXe5sid2r5XMhkO6aePZBnRh CzFJgqH+fBn5bJ1X82Jva/AI1skt5CNX6cHWP27WBt9ZfzFcO+96dhESrVokvl24ReGwiDr8+3B oCCXsTIqmUjkH4/wk5jv3i6Ar2lY8hEGofB8h4Ihk2aRrInUtVUGKIrUH147xSc5XxlGjFbOiek PYTNsgeEqDmSKKgBnJR0RD6Ha0IDHnANZjQ4Inqxdbo0grtSXQl8kpxQe1Ld7T1uGn6VMMHsh2d khOhYac2Cxwe+EcLxJnlfGbuLV3FM1zW3WaSneaipso26eU/FY57MEPLUJttNbVMdWBhMhLDXWo C7wFeEovD70M36vxwOnRLWFqZyTWg+Qhs3cyKwTC45r1YA8qh6ZBgrtuKCJ7fRyVLxVCmu1lmuy joHCjn7FNAUtzG4phNB0hK7gR+vvqx50v90gaE8xA= X-Received: by 2002:a17:907:c783:b0:beb:4d05:9a0a with SMTP id a640c23a62f3a-bf09ea5e71fmr166944866b.15.1780492238789; Wed, 03 Jun 2026 06:10:38 -0700 (PDT) Received: from [192.168.1.3] ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf0517714c5sm155160966b.2.2026.06.03.06.10.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jun 2026 06:10:38 -0700 (PDT) Message-ID: Date: Wed, 3 Jun 2026 14:10:37 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 05/18] perf test: Add deterministic workload To: Leo Yan Cc: Suzuki K Poulose , Mike Leach , Arnaldo Carvalho de Melo , Namhyung Kim , Jiri Olsa , Ian Rogers , Amir Ayupov , Jonathan Corbet , Shuah Khan , Paschalis Mpeis , coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , linux-doc@vger.kernel.org References: <20260602-james-cs-context-tracking-fix-v2-0-85b5ce6f55c6@linaro.org> <20260602-james-cs-context-tracking-fix-v2-5-85b5ce6f55c6@linaro.org> <20260603112742.GT101133@e132581.arm.com> Content-Language: en-US From: James Clark In-Reply-To: <20260603112742.GT101133@e132581.arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03/06/2026 12:27 pm, Leo Yan wrote: > On Tue, Jun 02, 2026 at 03:26:47PM +0100, James Clark wrote: > > [...] > >> @@ -22,3 +23,4 @@ CFLAGS_brstack.o = -g -O0 -fno-inline -U_FORTIFY_SOURCE >> CFLAGS_datasym.o = -g -O0 -fno-inline -U_FORTIFY_SOURCE >> CFLAGS_traploop.o = -g -O0 -fno-inline -U_FORTIFY_SOURCE >> CFLAGS_inlineloop.o = -g -O2 >> +CFLAGS_deterministic.o = -g -O0 > > I have no strong opinion for using 'noinline' in source or using the > global option '-fno-inline', just thought this is not easy to follow > up if anyone (likely myself) will write a new workload for disabling > inline. Could we have consistent style for this? > > For the patch itself: > > Reviewed-by: Leo Yan Actually it's a fair question why some have -fno-inline and others do it in the code, it could just be copied from when these were built by their shell script tests. From a quick look I would say we can easily drop the -fno-inline and do it in the code, and it's better to only noinline what's needed rather than everything. But that's probably a change for another time. That leaves the only custom build options as the ones that force -O0 (which also requires U_FORTIFY_SOURCE), or force -O2.