From: Andrew Lunn <andrew@lunn.ch>
To: Yibo Dong <dong100@mucse.com>
Cc: Parthiban.Veerasooran@microchip.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, corbet@lwn.net,
gur.stavi@huawei.com, maddy@linux.ibm.com, mpe@ellerman.id.au,
danishanwar@ti.com, lee@trager.us, gongfan1@huawei.com,
lorenzo@kernel.org, geert+renesas@glider.be,
lukas.bulwahn@redhat.com, alexanderduyck@fb.com,
richardcochran@gmail.com, kees@kernel.org, gustavoars@kernel.org,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH net-next v7 4/5] net: rnpgbe: Add basic mbx_fw support
Date: Fri, 22 Aug 2025 16:33:54 +0200 [thread overview]
Message-ID: <b488b893-389f-4c20-b2c3-23071279272c@lunn.ch> (raw)
In-Reply-To: <A1F3F9E0764A4308+20250822065132.GA1942990@nic-Precision-5820-Tower>
> /* Initialized as a defensive measure to handle edge cases
> * where try_cnt might be modified
> */
> int err = -EIO;
We don't use defensive code in the kernel. Defensive code suggests you
don't actually know what your driver is doing and you are guessing
this might happen. You should convince yourself it is
possible/impossible and write the code as needed.
Andrew
next prev parent reply other threads:[~2025-08-22 14:34 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 2:34 [PATCH net-next v7 0/5] Add driver for 1Gbe network chips from MUCSE Dong Yibo
2025-08-22 2:34 ` [PATCH net-next v7 1/5] net: rnpgbe: Add build support for rnpgbe Dong Yibo
2025-08-22 4:32 ` Parthiban.Veerasooran
2025-08-22 5:23 ` Yibo Dong
2025-08-22 2:34 ` [PATCH net-next v7 2/5] net: rnpgbe: Add n500/n210 chip support Dong Yibo
2025-08-22 2:34 ` [PATCH net-next v7 3/5] net: rnpgbe: Add basic mbx ops support Dong Yibo
2025-08-22 4:41 ` Parthiban.Veerasooran
2025-08-22 5:25 ` Yibo Dong
2025-08-22 2:34 ` [PATCH net-next v7 4/5] net: rnpgbe: Add basic mbx_fw support Dong Yibo
2025-08-22 4:49 ` Parthiban.Veerasooran
2025-08-22 5:37 ` Yibo Dong
2025-08-22 6:07 ` Parthiban.Veerasooran
2025-08-22 6:51 ` Yibo Dong
2025-08-22 8:05 ` Parthiban.Veerasooran
2025-08-22 9:04 ` Yibo Dong
2025-08-22 14:33 ` Andrew Lunn [this message]
2025-08-23 2:03 ` Yibo Dong
2025-08-22 14:43 ` Andrew Lunn
2025-08-23 1:58 ` Yibo Dong
2025-08-23 15:17 ` Andrew Lunn
2025-08-24 4:10 ` Yibo Dong
2025-08-24 15:15 ` Andrew Lunn
2025-08-25 1:30 ` Yibo Dong
2025-08-23 15:02 ` Vadim Fedorenko
2025-08-24 3:46 ` Yibo Dong
2025-08-25 16:37 ` Vadim Fedorenko
2025-08-26 1:31 ` Yibo Dong
2025-08-26 10:14 ` Vadim Fedorenko
2025-08-26 11:05 ` Yibo Dong
2025-08-26 12:39 ` Andrew Lunn
2025-08-27 1:42 ` Yibo Dong
2025-08-27 19:54 ` Andrew Lunn
2025-08-28 2:02 ` Yibo Dong
2025-08-22 2:34 ` [PATCH net-next v7 5/5] net: rnpgbe: Add register_netdev Dong Yibo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b488b893-389f-4c20-b2c3-23071279272c@lunn.ch \
--to=andrew@lunn.ch \
--cc=Parthiban.Veerasooran@microchip.com \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=dong100@mucse.com \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=gongfan1@huawei.com \
--cc=gur.stavi@huawei.com \
--cc=gustavoars@kernel.org \
--cc=horms@kernel.org \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=lee@trager.us \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=lukas.bulwahn@redhat.com \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®