From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Andre Przywara <andre.przywara@arm.com>,
Stefan Wahren <stefan.wahren@i2se.com>,
Enric Balletbo i Serra <eballetbo@gmail.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm: dts: bcm2711: Describe Ethernet LEDs
Date: Sat, 26 Aug 2023 05:29:33 +0200 [thread overview]
Message-ID: <b493bce5-a8a3-4dc1-b480-537243f2785d@lunn.ch> (raw)
In-Reply-To: <91d52461-1e76-dc79-2575-f6f6848f2697@broadcom.com>
> So in this case, the amber LED indicates the link activity, and the green
> LED indicates the link status. AFAICT we still do not have function names
> defined for those, the closest I can think is to do:
>
> function = LED_FUNCTION_ACTIVITY for the amber LED
>
> and for the green LED:
>
> function = (LED_FUNCTION_RX | LED_FUNCTION_TX)
>
> is that acceptable?
I have a WIP DT binding for exact meaning of the LED.
https://github.com/lunn/linux v6.5-rc4-net-next-led-bindings
It is too late for this merge window, so i will likely post it as an
RFC in a weeks time.
We probably need a discussion, LED_FUNCTION_LAN gives the high level
description, and contributes to the naming, and then this binding
gives the specific meaning of the LED? Or do we want to define
LED_FUNCTION_* for details?
Andrew
next prev parent reply other threads:[~2023-08-26 3:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 19:27 Florian Fainelli
2023-08-22 13:18 ` Andrew Lunn
2023-08-25 16:49 ` Florian Fainelli
2023-08-26 3:29 ` Andrew Lunn [this message]
2023-08-22 16:44 ` Stefan Wahren
2023-08-22 19:44 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b493bce5-a8a3-4dc1-b480-537243f2785d@lunn.ch \
--to=andrew@lunn.ch \
--cc=andre.przywara@arm.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetbo@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®