From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7456C001DB for ; Tue, 15 Aug 2023 12:32:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237235AbjHOMbn (ORCPT ); Tue, 15 Aug 2023 08:31:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236484AbjHOMbF (ORCPT ); Tue, 15 Aug 2023 08:31:05 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D544D1; Tue, 15 Aug 2023 05:31:04 -0700 (PDT) Received: from dggpemm500005.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RQ9ZG3FwtzrSgW; Tue, 15 Aug 2023 20:29:42 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 15 Aug 2023 20:31:02 +0800 Subject: Re: [PATCH net-next v6 1/6] page_pool: frag API support for 32-bit arch with 64-bit DMA To: Simon Horman CC: , , , , , Lorenzo Bianconi , Alexander Duyck , Liang Chen , Alexander Lobakin , Saeed Mahameed , Leon Romanovsky , Eric Dumazet , Jesper Dangaard Brouer , Ilias Apalodimas , References: <20230814125643.59334-1-linyunsheng@huawei.com> <20230814125643.59334-2-linyunsheng@huawei.com> From: Yunsheng Lin Message-ID: Date: Tue, 15 Aug 2023 20:31:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500005.china.huawei.com (7.185.36.74) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/8/15 19:24, Simon Horman wrote: > On Mon, Aug 14, 2023 at 08:56:38PM +0800, Yunsheng Lin wrote: > > ... > >> diff --git a/net/core/page_pool.c b/net/core/page_pool.c >> index 77cb75e63aca..d62c11aaea9a 100644 >> --- a/net/core/page_pool.c >> +++ b/net/core/page_pool.c > > ... > >> @@ -737,18 +736,16 @@ static void page_pool_free_frag(struct page_pool *pool) >> page_pool_return_page(pool, page); >> } >> >> -struct page *page_pool_alloc_frag(struct page_pool *pool, >> - unsigned int *offset, >> - unsigned int size, gfp_t gfp) >> +struct page *__page_pool_alloc_frag(struct page_pool *pool, >> + unsigned int *offset, >> + unsigned int size, gfp_t gfp) >> { >> unsigned int max_size = PAGE_SIZE << pool->p.order; >> struct page *page = pool->frag_page; >> >> - if (WARN_ON(!(pool->p.flags & PP_FLAG_PAGE_FRAG) || >> - size > max_size)) >> + if (WARN_ON(!(pool->p.flags & PP_FLAG_PAGE_FRAG)) > > Hi Yunsheng Lin, > > There is a ')' missing on the line above, which results in a build failure. Yes, thanks for noticing. As the above checking is removed in patch 3, so it is not noticeable in testing when the whole patchset is applied. >