From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AD8227468 for ; Mon, 31 Mar 2025 15:49:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743436173; cv=none; b=Rol8lmB/sCKpx/IeTeMJXHdT9KEtDkV2jvAxGzFooySBZQp5f/XhkIbLp1UHBAkYq28gJ9JHwdqAyiWV8vEqakqnZ1XYcfnBV7zdTO8pddNMusQbkx0z7Q7QSYq6/RbYG5vJKZ0PX6gbZ3vcCm9sAf8ME48dbrx8WgdocqFjK5c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743436173; c=relaxed/simple; bh=IGBH4wxVg1pNnD/eSgoSpRXhf9gdVCfg02O/OGATn1w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ekiafpaEdYondd3TvS3ZvtvZloeFzlZh+QrqtRcZKW9AbNWknGv97DFrRwGxnSxkGf53qozrwym66g+RjJp69zPqFanCHijo+cPgPsCWvE207hW1aajdDNdhoJNwYCAxuqYNViN/Lh3S4j6LCjSxzhhTDCjVWwRQhmMI5Ot7Vrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=E9nl8+23; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="E9nl8+23" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52VFCuuB029543 for ; Mon, 31 Mar 2025 15:49:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JQfeCNQU3Vgxd6VbOxmW+SSNqYouK+Dr05GCEQnKu5Y=; b=E9nl8+23kNEbGNMH 1LVghavU+TRhoX0mpA+RfdCuC5MrTua0XbHbzC69cSGa3I0z0LofjbZk3VSORqwl WB+Qve+DXY9RcSd62IeYtNYwweVWQ9scupKcgMBu5FvBBdqzxtCRxdnwcGOXpVmx rLMqbdEAPA/k88cQZl/FADk5gQ1/TeKSEfNGSv6HCJJRw8b4XRN5V0XWLClXXcFq Zu7ZUKryh5L7Ttz8DbZF86Hq2OzxUQmfi+0xhLIRDav+Rxp5JYPU6qji+fu2TP/6 lj43xV4oQisj5aGdJ8Yt2Z7cgTxv1a5WDJXpnvWx9/vbJ+RHDcAoWKB81dXhbpt+ eEio0g== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45p935vw2t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 31 Mar 2025 15:49:30 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7c549ea7166so726045085a.2 for ; Mon, 31 Mar 2025 08:49:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743436169; x=1744040969; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JQfeCNQU3Vgxd6VbOxmW+SSNqYouK+Dr05GCEQnKu5Y=; b=crbnC2ky7XLJyKQk+R/sOaleCGN+RY0JYjI+hA3d4vDQliGntCte71ybAI73+TRkq7 Ev5Ly3geulBSvmoc7R0k1ae7WI7kOoO4ySNOXbIGbr7BOzjg8PWB7y0uB2Is2aFCqmP5 hbJcvvyBNSS7P3EXRni2B2BGqzOIiWx9DligOfcpyWlfLcPldHHTF1OLze+1L5Zk9sXG 6PnDzLra/CpRcdsmJHaXmwKF7VKPYmVbG4lhzqTPEgEvjxXkr9tzBq1TUdpgKpQwHRFo f9nWgBLjwzmFdGqNu/sdgxUMnox65iyxrWfGtyn+N+ZEHJFDhqO+qABl+7pbPG+wQ4mA 2XoA== X-Forwarded-Encrypted: i=1; AJvYcCVsoYsSUEnvOjRvZRRzsZCumFE/BGgdsqLV6OuaV/LPy9FNCyURV4S+ZVG4z99rxDwj+sE6Pnp2bXFi1EI=@vger.kernel.org X-Gm-Message-State: AOJu0YwWum8oo8aU8+IkMqVsLb5fQAwQtKYWD+qYXZCHnSoiG/HfoiF1 fzIKqShgvzQf16c9MKSZSzI1xsV0dglGPT9gFIm4aq7QWvY27wl7PKFh51hmvGrmhsD3oc2VYJw vaRp1z1ltKxyH0/6PDZ586uhRB691cxghXBQSTqxgCdnvSBJFlyEqENqb8ENUqtQ= X-Gm-Gg: ASbGncu5jgIgkj8Ftuqs7gMmT05XXd0ImQ/e+MfY8ibJmb3UoTEkalZdgnRtXtZa2Ff IBViCfFxp2J7Qj2jaFX6pYfoxkkDixb+vUKAEU8djA7mDa19esMtwqUvrZTXyQ2GWfhwssKV0b/ q86xpTLeNhzcdoY7GJR1xPtRCtAOtyzJpml/qFIdf7+lCkFLYpf4FsxJmvpqAqTVB1xGixI/Rpk gHrnQ0YnUYWF3ZqGR6bodajSsNh2nScFaZMqK7dHp+GXed7o9z5qbxUqtfHIyQyo1WhBhNTkrwk rg3S0K115y4QT99yXeV8cqUv3j8SydAmj2WvKWObJh9krjXG6zNgj/mmLVQKlQjyQ0k= X-Received: by 2002:a05:620a:4105:b0:7c5:562d:cd02 with SMTP id af79cd13be357-7c690875665mr1327158985a.41.1743436169082; Mon, 31 Mar 2025 08:49:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEAFI3UMTVKl1f4Q8Z9ayeXB3UNVJ+jJ+IjQs7TXV+ypHv91zaFO4bVygk5ud+r/cnISXI9Fg== X-Received: by 2002:a05:620a:4105:b0:7c5:562d:cd02 with SMTP id af79cd13be357-7c690875665mr1327153585a.41.1743436168664; Mon, 31 Mar 2025 08:49:28 -0700 (PDT) Received: from [127.0.0.1] (87-92-196-151.rev.dnainternet.fi. [87.92.196.151]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5edc16aae56sm5773557a12.14.2025.03.31.08.49.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Mar 2025 08:49:26 -0700 (PDT) Message-ID: Date: Mon, 31 Mar 2025 18:49:18 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] arm64: dts: qcom: x1e78100-t14s: add hpd gpio to eDP panel To: Christopher Obbard , Johan Hovold Cc: Douglas Anderson , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Rui Miguel Silva , Abel Vesa , devicetree@vger.kernel.org, Bryan O'Donoghue References: <20250327-wip-obbardc-qcom-t14s-oled-panel-v3-0-45d5f2747398@linaro.org> <20250327-wip-obbardc-qcom-t14s-oled-panel-v3-1-45d5f2747398@linaro.org> Content-Language: en-US From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 6gcVRSpTtWBYl5iRihXfhytjyQXDqSB8 X-Authority-Analysis: v=2.4 cv=KOFaDEFo c=1 sm=1 tr=0 ts=67eab98a cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=OTAToBYhIyEwkxHp7GKTIQ==:17 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=3C20PiN8XUAt7dgb-g4A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: 6gcVRSpTtWBYl5iRihXfhytjyQXDqSB8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-31_07,2025-03-27_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 adultscore=0 spamscore=0 phishscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503310112 On 31/03/2025 18:39, Christopher Obbard wrote: > Hi Johan, > > On Mon, 31 Mar 2025 at 09:50, Johan Hovold wrote: >> >> On Thu, Mar 27, 2025 at 04:56:53PM +0000, Christopher Obbard wrote: >>> The eDP panel has an HPD GPIO. Describe it in the device tree >>> for the generic T14s model, as the HPD GPIO property is used in >>> both the OLED and LCD models which inherit this device tree. >> >> AFAICT, this patch is not correct as the hotplug detect signal is >> connected directly to the display controller on (these) Qualcomm SoCs >> and is already handled by its driver. >> >> Describing it as you do here leads to less accurate delays, see commits: >> >> 2327b13d6c47 ("drm/panel-edp: Take advantage of wait_hpd_asserted() in struct drm_dp_aux"). >> 3b5765df375c ("drm/panel: atna33xc20: Take advantage of wait_hpd_asserted() in struct drm_dp_aux") >> >> Perhaps you lose some other functionality too. >> >>> Reviewed-by: Bryan O'Donoghue >>> Signed-off-by: Christopher Obbard >>> --- >>> arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 11 +++++++++++ >>> 1 file changed, 11 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi >>> index 962fb050c55c4fd33f480a21a8c47a484d0c82b8..46c73f5c039ed982b553636cf8c4237a20ba7687 100644 >>> --- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi >>> @@ -980,8 +980,12 @@ &mdss_dp3 { >>> aux-bus { >>> panel: panel { >>> compatible = "edp-panel"; >>> + hpd-gpios = <&tlmm 119 GPIO_ACTIVE_HIGH>; >>> power-supply = <&vreg_edp_3p3>; >>> >>> + pinctrl-0 = <&edp_hpd_n_default>; >>> + pinctrl-names = "default"; >>> + >>> port { >>> edp_panel_in: endpoint { >>> remote-endpoint = <&mdss_dp3_out>; >>> @@ -1286,6 +1290,13 @@ hall_int_n_default: hall-int-n-state { >>> bias-disable; >>> }; >>> >>> + edp_hpd_n_default: edp-hpd-n-state { >>> + pins = "gpio119"; >>> + function = "gpio"; >>> + drive-strength = <2>; >>> + bias-pull-up; >>> + }; >> >> I checked the firmware configuration for this pin on my T14s, which >> does not match what you have here. Instead the function is set to >> "edp0_hot" which forwards the signal to the display controller which >> already handles the signal on panel power on. (And there is also no >> internal pull up enabled). >> >> We may want to describe this pin configuration somewhere, but that's a >> separate issue. > > Thanks for your review, I will send another version in coming days and > drop this first patch (adding hpd to the T14s DTSI). > > As a consequence I will need to add no-hpd property to the panel node. No, you won't. There is a HPD line and it is routed to the DP controller. > I will add a short comment about how the hpd signal is handled by the > driver already. -- With best wishes Dmitry