From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E89BB3176E0 for ; Tue, 10 Mar 2026 22:10:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773180625; cv=none; b=U7yU/hUqKdt236sAJaBMTayMKbuDsVA7/bZFKCpXPdDCcxZfMjazihQWgx/pcD8nQT8jI+t7S0zsLwtSm7ruRLWtVs4nmGGY8n/7G5Y6YKWzG6WCa9R27M4lURN97goZDU0DBMm4p9nL4klahTghjfHU3kWW6gR2LEnfd/f0L4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773180625; c=relaxed/simple; bh=lpiVfMmvMEbc7WpKs/pV2ZfJ12nTPxcYx+2IFGJVlG4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=po4A2eLnai9nDA6EZQUQrHfBnsNuNy9qtfIiYrnU42roIBHW6AozOBQep8c7LY4tL2RvjzZ4O/w4XKwZhmjN42XgtPa8xlNRtVOWpskwcp8FrSGueIFYIEWfchjjmi/xboUTYDyMGFBE+TKiLRfbM6F/ysQpJ306NUXkMrbGfXQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=eYgnBMFK; arc=none smtp.client-ip=209.85.160.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="eYgnBMFK" Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-40429b1d8baso3383106fac.0 for ; Tue, 10 Mar 2026 15:10:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1773180623; x=1773785423; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rUlyMjmWtaDm2hBhXkC/tuotxM3BPDdGyXsYclogIX0=; b=eYgnBMFKWVHouQ58+dgZgkB4xTILOjVIUEmpgWBPiyS8/3U4xC3EO6DH/oU/e6tPO3 QCfvCsjk5UgYHWDiJoPsObYkn2cNxBb9IQmejwzWSQsu5AqfKtGI2jcRyCEL28sCsXcb cxl5khi+GRRdDThB7UOCZvhkH9H2McSlu/5/U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773180623; x=1773785423; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rUlyMjmWtaDm2hBhXkC/tuotxM3BPDdGyXsYclogIX0=; b=kwXrDtr74J72mvfvoKDt17MXdOvuuHudHlB3g8JioRr5NJV+AcB9HxlrRe0ej/XKja XUecrqiafNsO0vOkQW+RG1geEbw+kZRPWbSUOJiXWj7qxf3m2VDN0kZJfv34KkgsUgvC 00GtSozhE00HJl0TGx3B0hb0Nzr8gQLhPWg2K7J4huazdonctMSIUoTyHsoZuR+wF95C iaTqltXiXr4vIrAOpprNZM2s5UomRu6uL/JGjZKS3g7sLL/0oG4ZcgQOEB5LLY0HoN5m +lF7KNWE7WbBwYgTy2VAcd0S++BXlsxBlsUP82Lus+EH6XgXSOTS8X20diLNqvjFEnUZ DTOQ== X-Forwarded-Encrypted: i=1; AJvYcCXbF3WFXtZgNu7UNJKREV8PeoRGpKk/Z1W+bD2fquEcsVfdbwbBHN86pbtrGaOOzXFdsc/rMt60xs3vKoQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyAseQ7M+yF41MbcbZxI4TR1ieI4JD9Vrc3joK5VUw8Yc3SDeIy LJIHSBChEY2dgMwexv4Ojl72Ylg+Uy4bKfTsl8xmit4iny2oOfmEeNZOKocwvv4iVnk= X-Gm-Gg: ATEYQzynCkV3b84t+UvnFDkOsCZ8N6zk1Up51vStm09to6o+un/NYvmMwvj51zoHdIP cT8h0MY0Ue4+KyPe1wHeLXafdB+JOSRgGLyGW6T80A/4KZho57v3dO4O7nnToaaI9GjBey5X1hh yGx1sIRX09fC+65DK7WytS+8rns11o+AtT4gtxHCez81jsKxqZgVP/WXfMc7Q/QFlDxqhbG0AWE JFzxvlTVjnLNb+gGW+rP5wS0VapGay9AdDdspK//kMJoxp/zXrhNdPxo5v7TEzsv65VNe4SoGWy k8BabZFAid7cz5/FOBTULC55HFrE4ELVqBtXvH9vw7fcqZzTT7MFt7X8FwuaO5bRGjQVWC7Rzwz FWNjRWj/J7BjRrQSQZSGyOMtoUbDfZoClN3Yofe5N4fesyNr5uomBVEJe2j16XBABIZDHSdRXwG VxG/h5dzYu6TLqdVe2GTxQE+vTRP4zgsXlP2c= X-Received: by 2002:a05:6870:8e07:b0:3e0:de76:31e5 with SMTP id 586e51a60fabf-4177c8b4e62mr340891fac.25.1773180622827; Tue, 10 Mar 2026 15:10:22 -0700 (PDT) Received: from [192.168.1.14] ([38.175.187.108]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4177e72b40asm215404fac.20.2026.03.10.15.10.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 15:10:22 -0700 (PDT) Message-ID: Date: Tue, 10 Mar 2026 16:10:20 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/6] usbip: vhci_sysfs: Use safer strscpy() instead of strcpy() To: Ai Chao , gregkh@linuxfoundation.org, b-liu@ti.com, johan@kernel.org, badhri@google.com, heikki.krogerus@linux.intel.com, valentina.manea.m@gmail.com, shuah@kernel.org, i@zenithal.me, tiwai@suse.de, kees@kernel.org, christophe.jaillet@wanadoo.fr, prashanth.k@oss.qualcomm.com, khtsai@google.com, dan.carpenter@linaro.org, tglx@kernel.org, mingo@kernel.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20260310094434.3639602-1-aichao@kylinos.cn> <20260310094434.3639602-7-aichao@kylinos.cn> Content-Language: en-US From: Shuah Khan In-Reply-To: <20260310094434.3639602-7-aichao@kylinos.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/10/26 03:44, Ai Chao wrote: > Use a safer function strscpy() instead of strcpy() for copying to > arrays. > > Only idiomatic code replacement, and no functional changes. It is a functional change since it calls a new routine. Get rid of this line from change log. How did you test this patch? I am curious because of you are describing the change as "idiomatic code replacement" > > Signed-off-by: Ai Chao > --- > drivers/usb/usbip/vhci_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/usbip/vhci_sysfs.c b/drivers/usb/usbip/vhci_sysfs.c > index bfc10f665e52..5bc8c47788d4 100644 > --- a/drivers/usb/usbip/vhci_sysfs.c > +++ b/drivers/usb/usbip/vhci_sysfs.c > @@ -463,7 +463,7 @@ static void set_status_attr(int id) > > status = status_attrs + id; > if (id == 0) > - strcpy(status->name, "status"); > + strscpy(status->name, "status"); > else > snprintf(status->name, MAX_STATUS_NAME+1, "status.%d", id); > status->attr.attr.name = status->name; thanks, -- Shuah