From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36B5CC433F5 for ; Fri, 20 May 2022 18:00:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352386AbiETSAL (ORCPT ); Fri, 20 May 2022 14:00:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241477AbiETSAI (ORCPT ); Fri, 20 May 2022 14:00:08 -0400 Received: from relay4.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91A74185CBA for ; Fri, 20 May 2022 11:00:07 -0700 (PDT) Received: from omf07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4061733D16; Fri, 20 May 2022 18:00:05 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA id 022D720032; Fri, 20 May 2022 18:00:01 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2 4/5] clang-format: Fix empty curly braces From: Joe Perches To: Miguel Ojeda Cc: =?ISO-8859-1?Q?Micka=EBl_Sala=FCn?= , Miguel Ojeda , Andy Whitcroft , Brian Norris , Dwaipayan Ray , "Jason A . Donenfeld" , Kees Cook , Konstantin Meskhidze , Lukas Bulwahn , Nathan Chancellor , Nick Desaulniers , Paul Moore , Tom Rix , linux-kernel , llvm@lists.linux.dev Date: Fri, 20 May 2022 11:00:00 -0700 In-Reply-To: References: <20220506160106.522341-1-mic@digikod.net> <20220506160106.522341-5-mic@digikod.net> <5be32ddf7688db38408466315a80e03e9af7ac40.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamout07 X-Rspamd-Queue-Id: 022D720032 X-Stat-Signature: uyp44sgdrwfz49gbd36ydzok3tbmcndf X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX182117J8M64PyKDQx46EsFXLJslc2PgjkA= X-HE-Tag: 1653069601-77227 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2022-05-20 at 19:50 +0200, Miguel Ojeda wrote: > Hi Joe, > > On Fri, May 20, 2022 at 7:24 PM Joe Perches wrote: > > > > static inline void foo1(...) {} > > static inline void foo2(...) {} > > ... > > static inline void fooN(...) {} > > Those are the non-wrapped-from-signature case, which are handled > before this option takes place, i.e. this option is about: > > void f() > {} > > vs. > > void f() > { > } > > For putting everything on the same line, we could adjust > `AllowShortFunctionsOnASingleLine` from `None` to `Empty`, though. As you wish. I think it's more that there's no "one true style" issue than anything.