From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755918AbcECNxf (ORCPT ); Tue, 3 May 2016 09:53:35 -0400 Received: from vulcan.natalenko.name ([104.207.131.136]:39914 "EHLO vulcan.natalenko.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755316AbcECNxe (ORCPT ); Tue, 3 May 2016 09:53:34 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 vulcan.natalenko.name ABF42CB1C3 Authentication-Results: vulcan.natalenko.name; dmarc=none header.from=natalenko.name MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 03 May 2016 16:53:31 +0300 From: Oleksandr Natalenko To: Andrew Morton Cc: Oleg Nesterov , Ben Hutchings , Lee Jones , Wolfram Sang , Roger Tseng , linux-kernel@vger.kernel.org Subject: [PATCH RESEND v2] rtsx_usb_ms: use schedule_timeout_idle() in polling loop Organization: pf-kernel developing community Message-ID: User-Agent: Roundcube Webmail/1.2-rc Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org First version of this patch has already been posted to LKML by Ben Hutchings ~6 months ago, but no further action were performed. Original Ben's message goes below. === rtsx_usb_ms creates a task that mostly sleeps, but tasks in uninterruptible sleep still contribute to the load average (for bug-compatibility with Unix). A load average of ~1 on a system that should be idle is somewhat alarming. Change the sleep to be interruptible, but still ignore signals. === v2 of this patch uses schedule_timeout_idle() instead of msleep() and removes flush_signals() introduces in v1 of this patch as kthread ignores all signals unless it does allow_signal(). References: https://bugs.debian.org/765717 Signed-off-by: Oleksandr Natalenko --- drivers/memstick/host/rtsx_usb_ms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/memstick/host/rtsx_usb_ms.c b/drivers/memstick/host/rtsx_usb_ms.c index 1105db2..d34bc35 100644 --- a/drivers/memstick/host/rtsx_usb_ms.c +++ b/drivers/memstick/host/rtsx_usb_ms.c @@ -706,7 +706,7 @@ poll_again: if (host->eject) break; - msleep(1000); + schedule_timeout_idle(HZ); } complete(&host->detect_ms_exit); -- 2.8.2