From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033845AbdEWUvv (ORCPT ); Tue, 23 May 2017 16:51:51 -0400 Received: from mout.web.de ([212.227.15.4]:63229 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031204AbdEWUvp (ORCPT ); Tue, 23 May 2017 16:51:45 -0400 Subject: [PATCH 1/5] MIPS: pm-cps: Delete an error message for a failed memory allocation in cps_pm_online_cpu() From: SF Markus Elfring To: linux-mips@linux-mips.org, Ingo Molnar , James Hogan , Kees Cook , Marcin Nowakowski , Masahiro Yamada , Matt Redfearn , Paul Burton , =?UTF-8?Q?Ralf_B=c3=a4chle?= , Thomas Gleixner Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Tue, 23 May 2017 22:51:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:NxvQdOciUccGbTMk0M4Ci6QXVsM3XCZGDSFLdrE61OAfLhqrH3G JMwC5ifDknCqt5N7YeTVMAM7r+GrtS+Y/qEUhie3WRUFVfxX+MxdnKFfZi9VSWJBm6+TZHj bfMx2JVSYf0a0/kxiA7hpkPYRDsHAkQoiqAc8KxuYGIu+/gh2RQxgekNaMe/PrAaqaBFCpK QHEfucvmh4469YDhlsBKw== X-UI-Out-Filterresults: notjunk:1;V01:K0:3ir5zC//T2M=:krHFA5dn7NxvwPSzx/v9U+ Dnlul1F01EwfgYQviyQ/SvmVgGPJcTCZeKeeNsGvM1tpquOe2Cv+PQdcNo7cR5YitMM/vPSIi FB8dcTooHgvvR0AFCdLGBPFQQVV8/QuWbKrTc+/IosJ0/QPk8rKtYt/6UsBERetlJjhNKbafd IPqjDpJ3cYQTeInxGiXeaqNhA7QsRWQHeYa1vhOEGYCGqKpCmFnMRHoL7BvwDPH2CDFkNcEnK NaBE6/LRWUFuaBlFOmMh3rf9zcqdD4A+QDOl6fSRrdFcXYDn5LylUcvnOwbPw+2CzPygmudpb Ff5XY1TGdGIIYwQeA34sy7pNp4DFp+62jzNyyLbac1QveI5QJ1Tn8S3kNMuiX62M/p0wGbHK0 Zo4ywKwnsvsOl2NrINFvHYLhHBHQaIRv8DW1ql5uIudpAMRreG/ZazIapXTa8clnGlJDn9O6A M0orclKE36dLbQf2eOzmzzBY9Bw5XL53+SeHD9idQzalGIWMR815XkU7cweOODVtRn2lUkMKb Sx+gLkLYH5ixzd55YSzvsKKSAElYaseYKHClgxiTwghqU99J0fY9iMwMXWs6L6uVO6UZ0qBKR K88vpqP6dxgTQkEudjO5XQg4SxHdHlqciU9OA+htkPqmbIpuWiagRbs2ScjF3KvU6zSFdEddz K8AXqXmFpmWwGtMqnBc6UYu3cEk4k8v7+bbaNG/lC/HJrekypTNNCQ0zEbYg4T3IQWYi87vjp GY5BITvWsZPsawWRYzD/hxolkpYX5QP9I/3UhjpTKEl8SFVejI+wx7xUpfVQpj4rKldvlUCgx tk4LLXJ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>From c7eaa7be6235b37023b23b40b36737f72e5b4b3f Mon Sep 17 00:00:00 2001 From: Markus Elfring Date: Tue, 23 May 2017 21:30:11 +0200 Subject: [PATCH 1/5] MIPS: pm-cps: Delete an error message for a failed memory allocation in cps_pm_online_cpu() Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- arch/mips/kernel/pm-cps.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/mips/kernel/pm-cps.c b/arch/mips/kernel/pm-cps.c index 5f928c34c148..d662838e418f 100644 --- a/arch/mips/kernel/pm-cps.c +++ b/arch/mips/kernel/pm-cps.c @@ -666,7 +666,6 @@ static int cps_pm_online_cpu(unsigned int cpu) - if (!core_rc) { - pr_err("Failed allocate core %u ready_count\n", core); + if (!core_rc) return -ENOMEM; - } + per_cpu(ready_count_alloc, core) = core_rc; /* Ensure ready_count is aligned to a cacheline boundary */ -- 2.13.0