From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752094AbdEPLIS (ORCPT <rfc822;w@1wt.eu>);
        Tue, 16 May 2017 07:08:18 -0400
Received: from mail-qt0-f181.google.com ([209.85.216.181]:33791 "EHLO
        mail-qt0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751795AbdEPLIP (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 16 May 2017 07:08:15 -0400
Subject: Re: [V2, 2/6] tty: serial: lpuart: add little endian 32 bit register
 support
To: Dong Aisheng <aisheng.dong@nxp.com>, linux-serial@vger.kernel.org
References: <1494834539-17523-3-git-send-email-aisheng.dong@nxp.com>
Cc: fugang.duan@nxp.com, dongas86@gmail.com, gregkh@linuxfoundation.org,
        yangbo.lu@nxp.com, linux-kernel@vger.kernel.org, stefan@agner.ch,
        Mingkai.Hu@nxp.com, jslaby@suse.com,
        linux-arm-kernel@lists.infradead.org
From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Message-ID: <b4a2ed13-c71f-c973-3b09-b632e083a88b@cogentembedded.com>
Date: Tue, 16 May 2017 14:08:12 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <1494834539-17523-3-git-send-email-aisheng.dong@nxp.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> @@ -2000,6 +2007,7 @@ static int lpuart_probe(struct platform_device *pdev)
>  	}
>  	sport->port.line = ret;
>  	sport->lpuart32 = sdata->is_32;
> +	lpuart_is_be = sdata->is_be;

Setting a global variable in per-device routine is quite bad design.