From: klondike <klondike@xiscosoft.net>
To: Florian Fainelli <f.fainelli@gmail.com>, linux-kernel@vger.kernel.org
Cc: torvalds@linux-foundation.org, pebolle@tiscali.nl,
ppandit@redhat.com, mmarek@suse.cz,
Andrew Morton <akpm@linux-foundation.org>,
npiggin@gmail.com
Subject: Re: [PATCH] initramfs: Fix spurious rebuilds
Date: Wed, 4 Jan 2017 14:34:16 +0100 [thread overview]
Message-ID: <b4a91c9c-ba35-33da-0509-68c135c85f91@klondike.es> (raw)
In-Reply-To: <20170104013732.26401-1-f.fainelli@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1800 bytes --]
El 04/01/17 a las 02:37, Florian Fainelli escribió:
> Commit 35e669e1a254 ("initramfs: select builtin initram
> compression algorithm on KConfig instead of Makefile") makes suffix_y be
> a quote variable, which can be illustrated looking at the build output:
>
> GEN usr/initramfs_data.cpio".gz"
>
> Make sure that we do strip off double quotes from
> CONFIG_INITRAMFS_COMPRESSION, since the Makefile tracks targets with
> unquoted suffixes.
>
> Fixes: 35e669e1a254 ("initramfs: select builtin initram compression algorithm on KConfig instead of Makefile")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> This is against v4.10-rc2, thanks!
>
> usr/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/usr/Makefile b/usr/Makefile
> index 17a513268325..a9ae8b493e2b 100644
> --- a/usr/Makefile
> +++ b/usr/Makefile
> @@ -5,7 +5,7 @@
> klibcdirs:;
> PHONY += klibcdirs
>
> -suffix_y = $(CONFIG_INITRAMFS_COMPRESSION)
> +suffix_y = $(subst ",,$(CONFIG_INITRAMFS_COMPRESSION))
> AFLAGS_initramfs_data.o += -DINITRAMFS_IMAGE="usr/initramfs_data.cpio$(suffix_y)"
>
> # Generate builtin.o based on initramfs_data.o
Hello,
Thanks for the fix, when I tested the patch I checked that the correct
file was created and embedded but didn't check for spurious rebuilds.
I'm CCing Nicholas Piggin as he sent another (larger version) of the
patch which also addresses a few other hacks in the Makefile, see
"[PATCH] kbuild: Fix dependency checking for initramfs build". I haven't
had time to check that second patch.
I have run the tests I ran for my own patches and they all passed, so
feel free to add Reviewed-by and Tested-by if you want :)
Sincerely,
Francisco Blas Izquierdo Riera (klondike)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-01-04 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 1:37 Florian Fainelli
2017-01-04 13:34 ` klondike [this message]
2017-01-04 14:39 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4a91c9c-ba35-33da-0509-68c135c85f91@klondike.es \
--to=klondike@xiscosoft.net \
--cc=akpm@linux-foundation.org \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=npiggin@gmail.com \
--cc=pebolle@tiscali.nl \
--cc=ppandit@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®