From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA3AF1C6AB for ; Thu, 25 Jan 2024 09:45:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706175919; cv=none; b=YcCPFEmj1bOCpFa/NLzD9jFAOfivKNCoVvJ9VU3L/xYN2YGApMkXDUGhmH7D/ib0zcHP2EqzjYTpW0CWBreMh61BJWnGhJgZWgnZt+5cVNHKevy8scxXt2qTSEH6bKEP/NWV89DC/Q19MzpDVuSzoHz5nWreHga70mpIO2oNM6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706175919; c=relaxed/simple; bh=cWPOC7NSGBppl4zfjZkFzAGHP/WbY62dZdXQCjP/xdY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qHS40I+uuX5EIiZ7jQsIGTC5f6V8+bblZNKzxjn0ajqwpyk/6z4qMpUo1c4ccFCShjggY/CdtVfhnZkll7YjkFBbsv4G63VBYByj+mQYBX1FtVsWgYRMDXszkrFMQ+iukHR5HYeNm0ptyyhWqXrb+4K1oeVKPlf3HY7iCAH4hdw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HNTpD/NK; arc=none smtp.client-ip=209.85.208.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HNTpD/NK" Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2cf1288097aso30041131fa.0 for ; Thu, 25 Jan 2024 01:45:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706175916; x=1706780716; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DIOuj7bR7enUuseulkrPOknNgIfgoOuomvKOHhgQg6I=; b=HNTpD/NKQ09l85DOQ3NB4UWYZ8zjnLYQVjeWPA6N3CncDrj/WL428qjpXGnHwjFp1v /DpYIiTVrqBrgVISGkp8zwtLAS56Kflqcmajdw9Lk0PHKqRbWakQA2OLrRFNkVMHw9yr 6tJceIljequMnKWJRofvVIqivBPyQkGmqen7K0iXSbwX/4GytlzKfNn/Og089jcWPg6n nwRKJ7zx4MordGn1syhelPPdUVccgOF5qA8sbC4x8NH1sTaSrnMRrdZmyLoULjuDoDIq 9UiR9aSI2SqhJY7Z0iwwJH+vg8Az/fpKPg/ECGy4oTorkljz2TDduuRdbz63bGtiSaci LCvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706175916; x=1706780716; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DIOuj7bR7enUuseulkrPOknNgIfgoOuomvKOHhgQg6I=; b=P9C6jrxppdw97Fpl0bPiFlgyDUXvvEHoGjxiJny54RSg7656KSE7VC+A35uRhHbJ9M 0ztT/f/lQYoSYTuZyZEpkWeHR8tnd4o+3uOtLUdw5vKGJqERa5RBz0owcV6KCJPRzm6p pn50NaShhBA3jHBzJpGng6OLahmiolX2XRfZPwcGHlV0PC/rm/ciMSib8mkPD/rkoXPX IqqLDMd9SP8wxFmTh5s4halq7yG7An6HDcGqd1Bszum2E2X3LxukMXWddYoLmL43o7Hx FALhjtYeY7HBYkECmZhzG7EcvScW/fVSuM0GUbX7n0Yx8e6ZiBnuhjRLjnrs3IjC+Fgj mXsQ== X-Gm-Message-State: AOJu0Yzyv3XlS6pH5O4ElMgK6cfdNf+fzPwmNDt8jalZSm2kDkRLdJoS EWgz7JlWku8AaWezwX4Fm2HownyrLllZDzvhslTn3kKQCPIpdGPwWoRDzL7xeBM= X-Google-Smtp-Source: AGHT+IFG+yauXBwOK/woS6AE2eb7O0Y/xtBvYSRv33al+j3vbOLwgE19T/bjbbonr4enfPCkmco7kg== X-Received: by 2002:a2e:a608:0:b0:2cd:fdc1:8e52 with SMTP id v8-20020a2ea608000000b002cdfdc18e52mr415985ljp.71.1706175915573; Thu, 25 Jan 2024 01:45:15 -0800 (PST) Received: from [172.30.205.155] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id p3-20020a2e8043000000b002cd91d0ceefsm232472ljg.33.2024.01.25.01.45.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jan 2024 01:45:15 -0800 (PST) Message-ID: Date: Thu, 25 Jan 2024 10:45:12 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND] arm64: dts: qcom: qcm6490-idp: Add support for PM7250B PMIC To: Dmitry Baryshkov , Umang Chheda Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Kamal Wadhwa References: <20240123102817.2414155-1-quic_uchheda@quicinc.com> <735575f5-ee46-4c91-b0bd-e9c6fb97361c@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/25/24 09:26, Dmitry Baryshkov wrote: > On Thu, 25 Jan 2024 at 10:10, Umang Chheda wrote: >> >> Hi Dmitry, >> >> On 1/23/2024 5:48 PM, Dmitry Baryshkov wrote: >>> On Tue, 23 Jan 2024 at 12:28, Umang Chheda wrote: >>>> >>>> qcm6490-idp platform supports PM7250B PMIC as well. >>>> Add support for the same. >>> >>> The platform can not "support" PMIC. Please fix the commit message. >> Shall I change the commit message as below in the next patch ? >> "Add PM7250B PMIC support for qcm6490-idp" > > This is also not accurate. You are not adding support for the PMIC. > You are describing PMICs present on the board. Umang, consider one of: arm64: dts: qcom: qcm6490-idp: "Include PM7250B" "Enable PM7250B" "Configure PM7250B" Konrad