From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Ronnie.Kunin@microchip.com, Raju.Lakkaraju@microchip.com,
netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
linux-kernel@vger.kernel.org, Bryan.Whitehead@microchip.com,
richardcochran@gmail.com, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net 3/3] net: lan743x: Address problems with wake option flags configuration sequences
Date: Wed, 13 Mar 2024 13:39:35 -0700 [thread overview]
Message-ID: <b4ab8f64-7b33-4365-9ad5-510171a7f9b8@gmail.com> (raw)
In-Reply-To: <725e8182-50de-4469-9f87-fa58179f8922@lunn.ch>
On 3/13/24 12:52, Andrew Lunn wrote:
> So i think we need to agree on best practices for new drivers and
> document what that is, probably in both the ethtool man page and
> include/uapi/linux/ethtool.h
>
> * WAKE_MAGIC on its own is O.K.
> * WAKE_MAGICSECURE without WAKE_MAGIC is invalid. -EINVAL
> * WAKE_MAGIC + WAKE_MAGICSECURE means only secure magic WoL.
> * Each driver needs to enforce this, due to backwards compatibility.
> Some may decide not to.
>
> Can we agree on this?
Yes, that works for me as well.
--
Florian
prev parent reply other threads:[~2024-03-13 20:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 8:09 [PATCH net 0/3] net: lan743x: Fixes for multiple WOL related issues Raju Lakkaraju
2024-02-26 8:09 ` [PATCH net 1/3] net: lan743x: disable WOL upon resume to restore full data path operation Raju Lakkaraju
2024-02-26 8:27 ` Horatiu Vultur
2024-02-29 4:51 ` Raju.Lakkaraju
2024-02-27 1:38 ` Andrew Lunn
2024-02-29 4:57 ` Raju.Lakkaraju
2024-02-26 8:09 ` [PATCH net 2/3] net: lan743x: support WOL in MAC even when PHY does not Raju Lakkaraju
2024-02-26 8:28 ` Horatiu Vultur
2024-02-27 1:42 ` Andrew Lunn
2024-02-29 4:52 ` Raju.Lakkaraju
2024-02-26 8:09 ` [PATCH net 3/3] net: lan743x: Address problems with wake option flags configuration sequences Raju Lakkaraju
2024-02-27 1:58 ` Andrew Lunn
2024-02-29 8:59 ` Raju.Lakkaraju
2024-02-29 15:06 ` Andrew Lunn
2024-03-01 10:22 ` Raju.Lakkaraju
2024-03-04 11:20 ` Raju.Lakkaraju
2024-03-06 23:19 ` Andrew Lunn
2024-03-06 23:53 ` Andrew Lunn
2024-03-08 8:20 ` Raju.Lakkaraju
2024-03-08 18:56 ` Ronnie.Kunin
2024-03-12 21:40 ` Andrew Lunn
2024-03-13 0:22 ` Ronnie.Kunin
2024-03-13 0:53 ` Florian Fainelli
2024-03-13 19:52 ` Andrew Lunn
2024-03-13 20:34 ` Ronnie.Kunin
2024-03-13 20:39 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4ab8f64-7b33-4365-9ad5-510171a7f9b8@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Bryan.Whitehead@microchip.com \
--cc=Raju.Lakkaraju@microchip.com \
--cc=Ronnie.Kunin@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®