From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D035BC77B7E for ; Fri, 21 Apr 2023 07:38:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231237AbjDUHiZ (ORCPT ); Fri, 21 Apr 2023 03:38:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229818AbjDUHiW (ORCPT ); Fri, 21 Apr 2023 03:38:22 -0400 Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 435D686BA; Fri, 21 Apr 2023 00:38:21 -0700 (PDT) Message-ID: Date: Fri, 21 Apr 2023 09:38:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Matthias Schwarzott Subject: Re: [PATCH] media: ov5693: Simplify an error message To: Christophe JAILLET , Daniel Scally , Mauro Carvalho Chehab Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-media@vger.kernel.org References: <928f2f70de241d0fa66801b46d736ad0f881eb72.1681576102.git.christophe.jaillet@wanadoo.fr> Content-Language: en-GB In-Reply-To: <928f2f70de241d0fa66801b46d736ad0f881eb72.1681576102.git.christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 15.04.23 um 18:28 schrieb Christophe JAILLET: > dev_err_probe() already display the error code. There is no need to > duplicate it explicitly in the error message. > > Signed-off-by: Christophe JAILLET > --- > drivers/media/i2c/ov5693.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c > index e3c3bed69ad6..d23786afd754 100644 > --- a/drivers/media/i2c/ov5693.c > +++ b/drivers/media/i2c/ov5693.c > @@ -404,8 +404,8 @@ static int ov5693_read_reg(struct ov5693_device *ov5693, u32 addr, u32 *value) > ret = i2c_transfer(client->adapter, msg, 2); > if (ret < 0) i2c_transfer returns the number of transmitted messages. So I think the values 0 <= ret < 2 also need to be handled. > return dev_err_probe(&client->dev, ret, > - "Failed to read register 0x%04x: %d\n", > - addr & OV5693_REG_ADDR_MASK, ret); > + "Failed to read register 0x%04x\n", > + addr & OV5693_REG_ADDR_MASK); > > *value = 0; > for (i = 0; i < len; ++i) {