From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 307613D333D for ; Mon, 9 Mar 2026 14:34:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773066899; cv=none; b=ONC1Sq8Pl2grdmdmVyzeQ+D7mY95r2Hg1rI2VWiTC52F3t/UMncOanxUwVQ873pl3WEXeoosD3cIHv6hEO60iKy5q9Ecmfb6Ml2GM4eUnaDv/aqi7wlcT8R/tM7B/EtveX14fH738JL0ojNw8+CggGGN0xiK+DRwwdZVW3U6GKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773066899; c=relaxed/simple; bh=dNwjQS4Ze5AVUXxTNwwtAMEcTV30AgWPK58E9Q8lvj8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QtaAmHjuRlfRIX+XwaXTBU+7L/BQIpDvyfRKqnNueMCSSUf+e5ubc+826tV2WlsLLt++dOyNj6TVyLnlVghlOhYWW34FBFNcpCImwn7ieD1kLWZCsxAgd0+g3JUZ1twBNHWwDKNZ6lIsfeQVIyfx4b/zIaXDF4NL2+TlFe/lEu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=GEXiLin1; arc=none smtp.client-ip=209.85.160.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="GEXiLin1" Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-4152698e745so2508224fac.1 for ; Mon, 09 Mar 2026 07:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1773066896; x=1773671696; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=B/2nZ3AXN7tfnpTcvPfto5djcQ417TUS0Z4ffFdUirY=; b=GEXiLin1J3e1ijArnxDfLr/g0ciKQbmfyg6/Hx21Jq+d0zHsSMrywyK4IrniHzFKMl HrMxakK6BqyUtmSCAGTiLCcqixpocqZPiu8vAyzcjU2r1NcnCCcq9uA5sVwKbaT4Col1 S7ZSZMPMv8M2+QTla/MR/LwFt6Lqi3U0Dh0L77vmX7KrsORbt5Lt8K6JVfZCrnhnx/EN g5KTjoMsHJHQzK4Kik87ILDrU7YKxJ4apuiZ1mX+KK0gc3MvdwDg2TDdrGP8jC7dzkDg 7nVSnxVJf4bOdYk5oskF8pOZYTnlTv7C+UAyZwEsqF49YMjRAzWwZQgrkz3Tqu4mGnGH eYYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773066896; x=1773671696; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B/2nZ3AXN7tfnpTcvPfto5djcQ417TUS0Z4ffFdUirY=; b=N6mki0X/SorvRWKJ2YQ3EdguFwvglwwn1qAZ1WUZoS62seup520Tinq8G79HImk7XB PK+M0/keI+6hV+CX9WIELe6OB4xmPTj0juyO0u8bGM/bDTKOue7gsNibPmb/xw+LGwWG tQsikUYez5OI8NaI9qlDYui2WaEAIt33t3xekQMjlLCVN1D7wp/3YM2LgKIl0DtS4rmT T1W4N5DKrIBeTx7vZBqAd5ENHILKd3PuZ/AESyTjcyLcpOdcnF1oOI5I5CkizK9ZSsRi f5j37OKSx6qd+9qFn9MuqUE3DNHknNLpcQFemL4p5HBFBYD5k52BomVlhcHZh17JO0iy Q78w== X-Forwarded-Encrypted: i=1; AJvYcCX5+ZBp4+r7Ks4iI03FkSOKY1A+ecBztMkAG7T3uErDI/43popcERnEFAmOmYtbS1qL88wAcjFE3cOA/wo=@vger.kernel.org X-Gm-Message-State: AOJu0YxAr8FolTyXVd5cdHgMYtdubhgy6ijUit61sfuprssx0h6lejyZ AAL+ccKTRrdewmXfJlH2HxwXN2Vo+N30IzumvrUZlQX20kA45Qb32geWaFXCoKSpeDU= X-Gm-Gg: ATEYQzyCG5Q9sOFOsBaoofjwOmSi70N0DdhJmiQyCyQv2GxSUJAhRSMTnzjavX8jAuQ ATDAIsZUwmtHoM2xNc7+AfSp3d8CMMJSyPs61wycqipTstClP5T7CStvQgAFdHrlyagUjU35u0M m1r/Udx4Vfzg2+J4OQDqs8nN2u6I1teowO1bEQ1W1tqR3j49WtbpjpYO3zUr4GZYo6WtxpWbcVA 5hGCdILily6PklobqUZ778kCV41y6yqeYrVQVEW9pjT41pC87cUkhyDwBGNIS9iuZBFaQlqGRF/ 9pdvob/coO+WwPJ2aa9cfhLAX9IS8TBbvvo/UeLIocEkWJ+PuU8ImNuCDpz+2LFoy2l42pJjGOU 8FUb4O/SXw2z5W7XngbRFqlI4SuwBUMXif/4aSek4wf8SGIbRsI9mHivwBBSgkNvWrnd6rFrwbj ZlcuMAJKsqZy/ma7RbtRtkjaCDZmfaTUvVRC94tYumBm8aM6HNH/fLXzKoGdBvsB+eaCSo X-Received: by 2002:a05:6870:8a21:b0:404:263b:9da1 with SMTP id 586e51a60fabf-416e3e84a31mr6480974fac.5.1773066896060; Mon, 09 Mar 2026 07:34:56 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:77:c35f:9c1b:c75f? ([2600:8803:e7e4:500:77:c35f:9c1b:c75f]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-416e6836886sm8715938fac.16.2026.03.09.07.34.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Mar 2026 07:34:55 -0700 (PDT) Message-ID: Date: Mon, 9 Mar 2026 09:34:53 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] dt-bindings: iio: adc: add bindings for AD4691 family To: "Sabau, Radu bogdan" , Jonathan Cameron Cc: Radu Sabau via B4 Relay , Lars-Peter Clausen , "Hennerich, Michael" , "Sa, Nuno" , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pwm@vger.kernel.org" , "linux-gpio@vger.kernel.org" References: <20260305-ad4692-multichannel-sar-adc-driver-v1-0-336229a8dcc7@analog.com> <20260305-ad4692-multichannel-sar-adc-driver-v1-1-336229a8dcc7@analog.com> <20260305174559.1ded5173@jic23-huawei> <08717cd6-a732-4f06-a6f1-8cbdaa755b78@baylibre.com> <20260308182839.19587743@jic23-huawei> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/9/26 3:57 AM, Sabau, Radu bogdan wrote: > ... >>>> Regarding 'mode', I agree that it should be something that could be modified >>>> at run-time, especially since all register modes (CNV_CLOCK, CNV_BURST, >>>> AUTONOMOUS and SPI_BURST) rely on the same principles of reading the >>>> ADC result from the registers, the main difference being that PWM on the >>>> CNV pin is required for CNV_CLOCK and CNV_BURST, but the board design >>>> stays the same. Perhaps this PWM can be initialized at start-time and only >>>> be used when CNV modes are being used. This would mean mode can >>>> become an IIO attribute that could be set by the user at run-time. >>> >>> More likely, it would be two different ways of doing a buffered read, >>> so maybe two different buffers? Or just pick the "best" one and only >>> implement that mode. >> >> I 'think' burst mode is really an oversampling thing as you read back from >> either the output of an averaging filter or an accumulator. >> I doubt there is reason to support both the oversampled and raw >> readings at the same time. >> > > I agree with that, perhaps burst modes (CNV_BURST and SPI_BURST) could > be dropped. Also, AUTONOMOUS mode could be used for read_raw since > its compatible with both CNV_CLOCK and MANUAL hardware setups. > So, then if the 'pwm' is present in the device tree, CNV_CLOCK > will be used for buffered readings and if not, MANUAL will. > This will indeed not only simplify the driver, but also keep two important > modes up for choice for the user. > > Please let me know your thoughts on this approach. > Sounds sensible to me.