From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941440AbcIHNur (ORCPT ); Thu, 8 Sep 2016 09:50:47 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:15055 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932244AbcIHNuo (ORCPT ); Thu, 8 Sep 2016 09:50:44 -0400 Subject: Re: [PATCH 1/4] ARM: dts: STiH410: Handle interconnect clock required by EHCI/OHCI (USB) To: Lee Jones , , , References: <20160908091136.17301-1-lee.jones@linaro.org> <20160908091136.17301-2-lee.jones@linaro.org> CC: , , , From: Patrice Chotard Message-ID: Date: Thu, 8 Sep 2016 15:50:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160908091136.17301-2-lee.jones@linaro.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.1.66] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-08_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee On 09/08/2016 11:11 AM, Lee Jones wrote: > The STiH4{07,10} platform contains some interconnect clocks which are used > by various IPs. If this clock isn't handled correctly by ST's EHCI/OHCI > drivers, their hub won't be found, the following error be shown and the > result will be non-working USB: > > [ 97.221963] hub 2-1:1.0: hub_ext_port_status failed (err = -110) > > Cc: stable@vger.kernel.org > Tested-by: Peter Griffin > Signed-off-by: Lee Jones > --- > arch/arm/boot/dts/stih410.dtsi | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/stih410.dtsi b/arch/arm/boot/dts/stih410.dtsi > index 9ee5e20..f1aa34c 100644 > --- a/arch/arm/boot/dts/stih410.dtsi > +++ b/arch/arm/boot/dts/stih410.dtsi > @@ -41,7 +41,8 @@ > compatible = "st,st-ohci-300x"; > reg = <0x9a03c00 0x100>; > interrupts = ; > - clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>; > + clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>, > + <&clk_s_c0_flexgen CLK_RX_ICN_DISP_0>; > resets = <&powerdown STIH407_USB2_PORT0_POWERDOWN>, > <&softreset STIH407_USB2_PORT0_SOFTRESET>; > reset-names = "power", "softreset"; > @@ -57,7 +58,8 @@ > interrupts = ; > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_usb0>; > - clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>; > + clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>, > + <&clk_s_c0_flexgen CLK_RX_ICN_DISP_0>; > resets = <&powerdown STIH407_USB2_PORT0_POWERDOWN>, > <&softreset STIH407_USB2_PORT0_SOFTRESET>; > reset-names = "power", "softreset"; > @@ -71,7 +73,8 @@ > compatible = "st,st-ohci-300x"; > reg = <0x9a83c00 0x100>; > interrupts = ; > - clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>; > + clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>, > + <&clk_s_c0_flexgen CLK_RX_ICN_DISP_0>; > resets = <&powerdown STIH407_USB2_PORT1_POWERDOWN>, > <&softreset STIH407_USB2_PORT1_SOFTRESET>; > reset-names = "power", "softreset"; > @@ -87,7 +90,8 @@ > interrupts = ; > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_usb1>; > - clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>; > + clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>, > + <&clk_s_c0_flexgen CLK_RX_ICN_DISP_0>; > resets = <&powerdown STIH407_USB2_PORT1_POWERDOWN>, > <&softreset STIH407_USB2_PORT1_SOFTRESET>; > reset-names = "power", "softreset"; Acked-by: Patrice Chotard