Re: [PATCH] drm: simpledrm: fix wrong unit with pixel clock

[Thomas Zimmermann <tzimmermann@suse.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1191 bytes --]

Hi

Am 12.12.21 um 17:06 schrieb Alejandro Concepcion-Rodriguez:
> Pixel clock has to be set in kHz.
> 
> Fixes: 11e8f5fd223b ("drm: Add simpledrm driver")
> 
> Signed-off-by: Alejandro Concepcion-Rodriguez <asconcepcion@acoro.eu>

Applied to drm-misc-fixes. Thanks.

Best regards
Thomas

> ---
>   drivers/gpu/drm/tiny/simpledrm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c
> index 2f999915b9aa..562bf09f9140 100644
> --- a/drivers/gpu/drm/tiny/simpledrm.c
> +++ b/drivers/gpu/drm/tiny/simpledrm.c
> @@ -459,7 +459,7 @@ static struct drm_display_mode simpledrm_mode(unsigned int width,
>   {
>   	struct drm_display_mode mode = { SIMPLEDRM_MODE(width, height) };
> 
> -	mode.clock = 60 /* Hz */ * mode.hdisplay * mode.vdisplay;
> +	mode.clock = mode.hdisplay * mode.vdisplay * 60 / 1000 /* kHz */;
>   	drm_mode_set_name(&mode);
> 
>   	return mode;
> --
> 2.25.1
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]