From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from flow-b4-smtp.messagingengine.com (flow-b4-smtp.messagingengine.com [202.12.124.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7114544D4F; Tue, 22 Sep 2026 15:35:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790091309; cv=none; b=a5/RBiPjZUfsT8zoWH4J7U3ROSiKgo9wiTu1JJKqP8xUurvbzh34d3WaqzKOdUB65G32S3X1u0I6tqyi3poRylB7EdOADAPpEL3HC52rdV2t7isEoZQQ755v6ZhMnF9QNg9XhC7fKu6kiAka0fvhcHSpOeMgMtMLks16MOGwR6w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790091309; c=relaxed/simple; bh=xHBu+r3dPsHMvUdUQo0Eq1m5mecQ/NelcsTIYE5piBk=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=TIapcTeRSyYI+i2RyTQ2WisMngRj6iUsGKJpimhmCe8o3OCpebrcQkFQGQwRtv8i45b75ZZOkFgktZI5ypNnu1J2bbCk/mobBMuKELulyxtL8nGRjqfFhn5Bjju6RGdkUa8LCmOv8/rmndNUzaiMuo21KEqKHk8+6tRgXtVpsLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=squebb.ca; spf=pass smtp.mailfrom=squebb.ca; dkim=pass (2048-bit key) header.d=squebb.ca header.i=@squebb.ca header.b=vBHFQdAT; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Pob5rp9K; arc=none smtp.client-ip=202.12.124.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=squebb.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=squebb.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=squebb.ca header.i=@squebb.ca header.b="vBHFQdAT"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Pob5rp9K" Received: from stl-compute-04.internal (stl-compute-04.internal [10.204.2.64]) by mailflow.stl.internal (Postfix) with ESMTP id A43E81300129; Tue, 22 Sep 2026 11:35:06 -0400 (EDT) Received: from stl-imap-02 ([10.204.2.93]) by stl-compute-04.internal (MEProxy); Tue, 22 Sep 2026 11:35:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=squebb.ca; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1790091306; x=1790098506; bh=k+BJAVmqueRCG6zFCjOD7Eq+W4AZN/slK53nkPTLIzw=; b= vBHFQdATih6l3N7u8kgSaG6ewsD9JgZ06Ng97KLBVVY4J8D6jacpdSiKK+4im8ZS u9VmgAQFMskN57E4t27jHM2UV5j47xEyHitSw055TIgRMzVNfsIbjzSjZ39uZntv YCu/MCU1Q7yPSzNqZVJm5lwm4dADXHwy4KvQTuYP1EInG+nzTh/diV/dVqg96DRP ix8w4/cUUajZ/PV/H3udbOLDTh+JP0ZaMtjGlmHsGQRLVDb2CFP/X8MH1+eRhG99 2QZnArTu/ZlbZknU5sE369648aFsvw8DjACMUSh0KoZ8z9jcAL81cgznOSvYSd+j ssMfR4wN5CIcYXWKgDz5Uw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1790091306; x= 1790098506; bh=k+BJAVmqueRCG6zFCjOD7Eq+W4AZN/slK53nkPTLIzw=; b=P ob5rp9KchqWFsAfq23R+f5NbH/N973omlKPujuzR8A5vBpVsppAzP7k2aakuEsUM dFFLYXhuzzk7Y9AzU9HQGE5NnzoBT6oZM7NWLByxyKKIYejQ+kvmaeNYNHQMCbs/ iUVxP+nXDO9oEEWlWoWzxuAYAHNF/tsYmxjmywFMlwkGG7EIYUuN1lCv8qjoDvnr MfWyjDHsdvmFsrJw9q2U8xWy8GteZM/Ex+RvIm4XQmrWiGhUYSYmBjK5pglA4byh gFuyun2S1I6Fuih79yVBUZQ+T116X54O3DxYr6g3OT9+qCQfqB47C4SGeY5qaKJ8 6s7nMEh93TuY+ecCimQcA== X-ME-Sender: X-ME-Proxy-Cause: dmFkZTFtO50sYQ5HQ9vqA43bq7Ik43gKK49C4hRnAlX9A2NcSc1pEt79yROnVZUKyvBN/Q PLC8lg14plyO8t93JRmwyuiDu+rSsldUqLFoRsqyyuw9x476BiFA1TJU/iKokRtmSagGho OOZcJCjyQPV1KsVkjZ/gVJdN71ywnrTmwTP9R9Thti3rf06sti9s+JYTC7CXXrspT9q17P zWokE2QYleDx84Xfx9mxpv3xUm5tz8HTKlWamE31/WQbKz22J+mgtXwqR1TS+0EQnuAwYN HL/qx7PGCVOuHBlM8MEJ2N5l4Ooh5pzkmkzmyY5lfAg3Mf/gsytQ7H3AAtIg+LMWZSZFPg 7gGBz57Ll3xeJ3dlJj2ooyr7GnRfU0bw3vJ380NbqVLpjBwF5VPInv5bmQpDYD3xVISide F2xq26yalJCzsRfL5A9vA3YMUmHrY741Sp54Y+W71Y3JyBJrPyjbdGUOlzQ599SqoFtdZU kfdCxY4rTHRJqN3xNybcSpmYV2eX8cItJZyvos+ScMdOsZKukpimy3H5NpEAxLtQruJIkS espiz3yptdMvF/YFSjkfprbH93NBPLmJSvB44uQdeM/VP3AvBIfpprI8W4Bl5RSnsm+XEo rAQDJLlULngYuKc1Lp4bKXB7lQ8I7D6WYvr1ZiqFH9YYELj8UbIEVskfuVsg X-ME-Proxy: Feedback-ID: ibe194615:Fastmail Received: by mailuser.stl.internal (Postfix, from userid 501) id 647182C00067; Tue, 22 Sep 2026 11:35:04 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AVcutaJy7ROZ Date: Tue, 22 Sep 2026 11:34:44 -0400 From: "Mark Pearson" To: "Rafael J. Wysocki" , "linux-acpi@vger.kernel.org" Cc: LKML , "Andy Shevchenko" , "Mika Westerberg" , "Lorenzo Pieralisi" , "Hanjun Guo" , "Sudeep Holla" , linux-arm-kernel@lists.infradead.org, "Ard Biesheuvel" , "Ilias Apalodimas" , linux-efi@vger.kernel.org, "Will Deacon" , "Robin Murphy" , "Joerg Roedel" , "Derek J . Clark" , "Hans de Goede" , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , "platform-driver-x86@vger.kernel.org" , "David Rhodes" , "Richard Fitzgerald" , "Jaroslav Kysela" , "Takashi Iwai" , linux-sound@vger.kernel.org, "Shenghao Ding" , "Kevin Lu" , "Baojun Xu" , "Sen Wang" , "Vijendar Mukunda" , "Venkata Prasad Potturu" , "Liam Girdwood" , "Mark Brown" , "Cezary Rojewski" , "Peter Ujfalusi" , "Bard Liao" , "Kai Vehmanen" , "Pierre-Louis Bossart" , "Binbin Zhou" , "Andreas Noever" , "Mika Westerberg" , "Yehezkel Bernat" Message-Id: In-Reply-To: <1973238.CQOukoFCf9@rafael.j.wysocki> References: <7995179.EvYhyI6sBW@rafael.j.wysocki> <1973238.CQOukoFCf9@rafael.j.wysocki> Subject: Re: [PATCH v1 05/17] platform/x86: yogabook: Switch to use acpi_bus_get_primary_device() Content-Type: text/plain Content-Transfer-Encoding: 7bit On Mon, Sep 21, 2026, at 3:48 PM, Rafael J. Wysocki wrote: > From: "Rafael J. Wysocki" > > Replace acpi_get_first_physical_node() that is slated for removal > with acpi_bus_get_primary_device() that takes a reference to the > device it is about to return. > > This addresses a potential use-after-free that may occur if the > device returned by acpi_get_first_physical_node() is removed right > after dropping its ACPI companion's physical_node_lock in that > function. > > Signed-off-by: Rafael J. Wysocki > --- > drivers/platform/x86/lenovo/yogabook.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/lenovo/yogabook.c > b/drivers/platform/x86/lenovo/yogabook.c > index 1a4b2ab1f35d..8a91d440724b 100644 > --- a/drivers/platform/x86/lenovo/yogabook.c > +++ b/drivers/platform/x86/lenovo/yogabook.c > @@ -353,13 +353,13 @@ static int yogabook_wmi_probe(struct wmi_device > *wdev, const void *context) > goto error_put_devs; > } > > - data->kbd_dev = get_device(acpi_get_first_physical_node(data->kbd_adev)); > + data->kbd_dev = acpi_bus_get_primary_device(data->kbd_adev); > if (!data->kbd_dev || !data->kbd_dev->driver) { > r = -EPROBE_DEFER; > goto error_put_devs; > } > > - data->dig_dev = get_device(acpi_get_first_physical_node(data->dig_adev)); > + data->dig_dev = acpi_bus_get_primary_device(data->dig_adev); > if (!data->dig_dev || !data->dig_dev->driver) { > r = -EPROBE_DEFER; > goto error_put_devs; > -- > 2.51.0 Reviewed-by: Mark Pearson Mark