From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752184AbcDZDa7 (ORCPT ); Mon, 25 Apr 2016 23:30:59 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:38705 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752226AbcDZDa6 (ORCPT ); Mon, 25 Apr 2016 23:30:58 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Mon, 25 Apr 2016 20:27:26 -0700 From: Stefan Agner To: dri-devel@lists.freedesktop.org, stefan@agner.ch Cc: alison.wang@freescale.com, airlied@linux.ie, jianwei.wang.chn@gmail.com, meng.yi@nxp.com, alexander.stein@systec-electronic.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/6] drm/fsl-dcu: unload fixes In-Reply-To: <1460870755-22964-1-git-send-email-stefan@agner.ch> References: <1460870755-22964-1-git-send-email-stefan@agner.ch> Message-ID: User-Agent: Roundcube Webmail/1.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied patchset to my fsl-dcu tree. -- Stefan On 2016-04-16 22:25, Stefan Agner wrote: > Hi all, > > This patchset fixes several issues around unloading/unbinding > the driver. There is still one WARNING when unloading the driver > while vblank interrupts are enabled. I am not sure what/who > should make sure that vblank interrupts get disabled before > unloading the driver: > > root@colibri-vf:~# echo 40058000.dcu > /sys/bus/platform/drivers/fsl-dcu/unbind > [ 37.209656] Console: switching to colour dummy device 80x30 > [ 37.224954] ------------[ cut here ]------------ > [ 37.245375] WARNING: CPU: 0 PID: 170 at > drivers/gpu/drm/drm_irq.c:380 drm_vblank_cleanup+0x5c/0x8c > ... > > Hints welcome... > > Stefan Agner (6): > drm/fsl-dcu: detach panel on destroy > drm/fsl-dcu: handle missing panel gracefully > drm/fsl-dcu: use variable name dev for struct drm_device > drm/fsl-dcu: deallocate fbdev CMA on unload > drm/fsl-dcu: disable output polling on driver unload > drm/fsl-dcu: implement lastclose callback > > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 50 +++++++++++++++++++++---------- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 23 +++++++++----- > 2 files changed, 50 insertions(+), 23 deletions(-)