From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC6E9C7619A for ; Wed, 12 Apr 2023 07:09:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229861AbjDLHJf (ORCPT ); Wed, 12 Apr 2023 03:09:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229535AbjDLHJd (ORCPT ); Wed, 12 Apr 2023 03:09:33 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D0CD30CA for ; Wed, 12 Apr 2023 00:09:31 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id sh8so26264877ejc.10 for ; Wed, 12 Apr 2023 00:09:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681283370; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=n54EsJ6yBbWy+99Uq8T7kmBnGcEminZ4uU6Ei5e8CDw=; b=Yqf1EPBTOZ6E/e8B3wH7y8kilH7wOx/YDPzcMYgkDkHg6XoH6we0FCCVeFIlJP6viL xV0hggGkUu6ia9qBwd3YlRAGWezDlq/6taWf7xWR0RAPM/gj+fMp+/D1v+iG3RzeJn+C cfnmuoDsobXw79fJEt2XgEhuteFqy9q4fLjdxDb28KR3L4uPInfgWZryIwboK1sIdTNc UnSkvmVWQ9iqB1Gv3fHMrz4wD0eyEHdCnIxE4g0NxDvRgKUYo7UBE12iz9Wh9TEXoATo QJAdMcJZiCy6QT1zK6y/MnV2x7h+U4uxkFcXpDczCQgmkauI6M9eVR68er3mv+qrEndG SJfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681283370; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n54EsJ6yBbWy+99Uq8T7kmBnGcEminZ4uU6Ei5e8CDw=; b=F9+jZfeVb6aziyNiy44oyQdCA+bRFYNLRGTLTbHTrWuuKjLXAbyIWzdMe72KbGcqgl N5euBBKAE6xDDzxQWatb00e7fxLamMkMoXCvyVzDO/DfAdyC3Iv45KB5muncTrgmVyzc IqJn8Xpl1SkF7uSNr9ROpV+rhpuYfMW4bSAO17KXm6IBE613BCtePCt8apIOz8ke/tT1 by1DS+ecQ34G7lEnGODNVYmj/tMnn7nQKmDsNKiouU6qE/iEzXO0e5j2prwkGcbOxi1E ZifAG2vxOadRPdEh4LM+sg8LX/FmWsaV1KFuk93N3p0G8b2oXdCzZg/PxvGfeclXiOif qv/Q== X-Gm-Message-State: AAQBX9fzvmBJn3kd0HjIA3DtQdBIZ35lzZVL2VKgaSVKP+IfAYeZQCwp C+83T3CiraPXRqP/X550/p3eXA== X-Google-Smtp-Source: AKy350Z75v3DcpypUUDdq/iWgi36nW75fEQMK+FCrPEJatNrxQGr1LgsdyYrMIRldRFqYcXRwkfjqw== X-Received: by 2002:a17:906:4a0d:b0:94a:70f0:6321 with SMTP id w13-20020a1709064a0d00b0094a70f06321mr8674129eju.61.1681283370186; Wed, 12 Apr 2023 00:09:30 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:8fa0:9989:3f72:b14f? ([2a02:810d:15c0:828:8fa0:9989:3f72:b14f]) by smtp.gmail.com with ESMTPSA id xd4-20020a170907078400b0094a941ad8f0sm2667038ejb.193.2023.04.12.00.09.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 00:09:29 -0700 (PDT) Message-ID: Date: Wed, 12 Apr 2023 09:09:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 1/2] dt-bindings: leds: ROHM BD2606MVV LED driver Content-Language: en-US To: Andreas Kemnade Cc: pavel@ucw.cz, lee@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Matti Vaittinen References: <20230407050803.170773-1-andreas@kemnade.info> <20230407050803.170773-2-andreas@kemnade.info> <20230411213044.4bf6dc89@aktux> From: Krzysztof Kozlowski In-Reply-To: <20230411213044.4bf6dc89@aktux> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/04/2023 21:30, Andreas Kemnade wrote: > On Mon, 10 Apr 2023 17:34:00 +0200 > Krzysztof Kozlowski wrote: > > [...] >>> + led-controller@66 { >>> + compatible = "rohm,bd2606mvv"; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + reg = <0x66>; >> >> reg is always second property in DTS. >> >>> + >>> + led@0 { >>> + color = ; >>> + function = LED_FUNCTION_POWER; >>> + reg = <0x0>; >> >> Ditto >> > hmm, reg also second if no compatible first? I see it usually first in > such cases. Right, then reg is first. Best regards, Krzysztof