From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9911C433EF for ; Thu, 31 Mar 2022 11:24:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235122AbiCaLZv (ORCPT ); Thu, 31 Mar 2022 07:25:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235094AbiCaLZo (ORCPT ); Thu, 31 Mar 2022 07:25:44 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B7F763FB for ; Thu, 31 Mar 2022 04:23:51 -0700 (PDT) Received: from kwepemi500016.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4KTgsZ6D8tz1GCx2; Thu, 31 Mar 2022 19:23:30 +0800 (CST) Received: from kwepemm600017.china.huawei.com (7.193.23.234) by kwepemi500016.china.huawei.com (7.221.188.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 31 Mar 2022 19:23:49 +0800 Received: from [10.174.179.19] (10.174.179.19) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 31 Mar 2022 19:23:48 +0800 Message-ID: Date: Thu, 31 Mar 2022 19:23:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH] hugetlb: Fix hugepages_setup when deal with pernode Content-Language: en-US To: Mike Kravetz , , , , , References: <20220324074037.2024608-1-liupeng256@huawei.com> <361111c6-921b-e129-edf3-367748f6497e@oracle.com> From: "liupeng (DM)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.19] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600017.china.huawei.com (7.193.23.234) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/3/30 1:43, Mike Kravetz wrote: > On 3/28/22 20:59, liupeng (DM) wrote: >> On 2022/3/29 10:46, Mike Kravetz wrote: >>> Yes, I agree that the change is needed and the current behavior is >>> unacceptable. >>> >>> One remaining question is the change from returning '0' to '1' in the case >>> of error.  I do understand this is to prevent the invalid parameter string >>> from being passed to init.  It may not be correct/right, but in every other >>> case where an invalid parameter in encountered in hugetlb command line >>> processing we return "0".  Should we perhaps change all these other places >>> to be consistent?  I honestly do not know what is the appropriate behavior >>> in these situations. >> Thank you for your carefulness and question. >> >> I have checked default_hugepagesz_setup and hugepages_setup will both print >> some information before return '0', so there is no need to print again in >> "Unknown kernel command line parameters". >> >> Should I send another patch to repair the rest "return 0" in hugetlb? > I would suggest two patches: > > 1) Fix the issue with invalid nodes specified. However, leave the "return 0" > behavior in hugepages_setup to be consistent with the rest of the code. > This patch can be sent to stable with "Fixes: b5389086ad7b" tag as it > addresses an existing issue. > 2) Clean up the places where we return 0 and it would be better to return 1. > No cc stable here and just let the changes target future releases. I have tried to write a patch as your suggestion, but the best way I can carry it out is the original patch. To meet "Fix invalid nodes issue and leave thereturn 0 behavior", I have to add the following redundant code:  invalid:         pr_warn("HugeTLB: Invalid hugepages parameter %s\n", p); + +       /* Allocate gigantic hstates for successfully parsed parameters*/ +       if (hugetlb_max_hstate && hstate_is_gigantic(parsed_hstate)) + hugetlb_hstate_alloc_pages(parsed_hstate); +       last_mhp = mhp; return 0; Any ideas?