From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: Ding Xiang <dingxiang@cmss.chinamobile.com>,
oleksandr_andrushchenko@epam.com, airlied@linux.ie,
daniel@ffwll.ch
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [Xen-devel] [PATCH] drm/xen: fix passing zero to 'PTR_ERR' warning
Date: Tue, 31 Mar 2020 17:50:10 +0300 [thread overview]
Message-ID: <b4d43b05-8b30-749c-0b60-87b4cdd7b1dd@gmail.com> (raw)
In-Reply-To: <1585562347-30214-1-git-send-email-dingxiang@cmss.chinamobile.com>
On 3/30/20 12:59, Ding Xiang wrote:
> Fix a static code checker warning:
> drivers/gpu/drm/xen/xen_drm_front.c:404 xen_drm_drv_dumb_create()
> warn: passing zero to 'PTR_ERR'
>
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
> drivers/gpu/drm/xen/xen_drm_front.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
> index 4be49c1..3741420 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
> @@ -401,7 +401,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
>
> obj = xen_drm_front_gem_create(dev, args->size);
> if (IS_ERR_OR_NULL(obj)) {
> - ret = PTR_ERR(obj);
> + ret = PTR_ERR_OR_ZERO(obj);
> goto fail;
> }
>
next prev parent reply other threads:[~2020-03-31 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 9:59 Ding Xiang
2020-03-31 14:50 ` Oleksandr Andrushchenko [this message]
2020-03-31 15:15 ` [Xen-devel] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4d43b05-8b30-749c-0b60-87b4cdd7b1dd@gmail.com \
--to=andr2000@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dingxiang@cmss.chinamobile.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®