From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751207AbdAMSC3 (ORCPT ); Fri, 13 Jan 2017 13:02:29 -0500 Received: from fllnx210.ext.ti.com ([198.47.19.17]:46019 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbdAMSC1 (ORCPT ); Fri, 13 Jan 2017 13:02:27 -0500 Subject: Re: [PATCH V2 0/6] gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip To: Keerthy , , References: <1484281215-24576-1-git-send-email-j-keerthy@ti.com> CC: , , From: Grygorii Strashko Message-ID: Date: Fri, 13 Jan 2017 12:02:24 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1484281215-24576-1-git-send-email-j-keerthy@ti.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [128.247.83.96] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/12/2017 10:20 PM, Keerthy wrote: > The Davinci GPIO driver is implemented to work with one monolithic > Davinci GPIO platform device which may have up to Y(144) gpios. > The Davinci GPIO driver instantiates number of GPIO chips with > max 32 gpio pins per each during initialization and one IRQ domain. > So, the current GPIO's opjects structure is: > > Davinci GPIO controller > |- ------| > ... |--- irq_domain (hwirq [0..143]) > |- ------| > > Current driver creates one chip for every 32 GPIOs in a controller. > This was a limitation earlier now there is no need for that. Hence > redesigning the driver to create one gpio chip for all the ngpio > in the controller. > > |- ------|--- irq_domain (hwirq [0..143]). > > The previous discussion on this can be found here: > https://www.spinics.net/lists/linux-omap/msg132869.html > > The series is posted on top of: > > https://lkml.org/lkml/2017/1/4/94 > > Changes in v2: > > * Optimized the re-design patch. > * Added couple of code clean ups after the re-design. > * Included v2 of https://patchwork.ozlabs.org/patch/710855/ > > Keerthy (6): > gpio: davinci: Remove gpio2regs function to accommodate multi > instances > gpio: davinci: Remove unwanted blank line > gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip > gpio: davinci: Add support for multiple GPIO controllers > gpio: davinci: Remove custom .xlate > gpio: davinci: Remove redundant macros > > drivers/gpio/gpio-davinci.c | 174 +++++++++++++---------------- > include/linux/platform_data/gpio-davinci.h | 20 ++-- > 2 files changed, 90 insertions(+), 104 deletions(-) > Reviewed-by: Grygorii Strashko -- regards, -grygorii