From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEF9A5581FB for ; Wed, 9 Sep 2026 12:42:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788957765; cv=none; b=p3jsFIFonHZINaBdQE+SvdeDOj2qk69GQCBovZz5jM1avysybqq8UCJat6KtgY/doxV4BgGnXd4RDOywOWzY08B+db8GmzX/g7YvBWK/0f7sIPj8vC+L2H5e5fsiC/IcAo+/cs8km9AMQe4yfk1C6KOA19Gd+xvTwT9TH61QeG4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788957765; c=relaxed/simple; bh=0hWrdz4q7rb7I/HCxd1hEn9K+roy/g583HdMM5Nqfwg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AbtF8/zEJgpdtn7PEaV+U4bZ7/LaiHz97z0eqMcOAlGhtOrREEuAcidTdbqe2LFBleO1IPNZYD6S8C+wmCEFCZyX95X86nOwvW7FcwEJNuDBGDzRtqjBXSmMM3SBb0xj1pNHyjRRzVtulQj9qyW4RXtz3NuBYj1FcpMv3ibsTd4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=V86TYKj4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JwhlHyQh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="V86TYKj4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JwhlHyQh" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 689BU0qE1809804 for ; Wed, 9 Sep 2026 12:42:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IqDBfWmpsbVcFz4ktvchUUk0YUbACLYsKQhJUiknkwc=; b=V86TYKj4QA7r5O+E eFBqgvx4oO+e680cr6J9GvM6DOoTjxM8P033ihrA8i0ZJey4nNFepfWdwAq3olyC kXzPWwyhGMmmRBPSTKizUEOyTteHtYTjZItSLy+dyPszLP2icApNnxvfHRFQjhCY VwDVZCjyBPqNy88IjyB+XL38TAsVEkIIsLi55dEnMosQcAViHMqBvy5WNcQI5ghh XLgG10687Y3r7UtHlTcq7kU+LZyjE1vk06jXZgOlD+46t7diSqAe7EVOWo6cSW9l yFp7dBCpmNAU3i+XVWLPLeOdR05EsUFEtExWP3LQCceIEkuFoKNXxx3hSdvCwxj+ ZTLsYw== Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gk4xj0ntv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 09 Sep 2026 12:42:40 +0000 (GMT) Received: by mail-ot1-f70.google.com with SMTP id 46e09a7af769-7ee59eeb8c1so4017872a34.0 for ; Wed, 09 Sep 2026 05:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788957760; x=1789562560; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=IqDBfWmpsbVcFz4ktvchUUk0YUbACLYsKQhJUiknkwc=; b=JwhlHyQhO6GBsbQC1bteQnnpKM/2K1vIVAwY+U89T9729bvJJGjY5fLeygdRSKsmxN AydiXVSy3+UDjpjMbleyxJ62BImYh7aQIotTdMoknQxJMjpOhtZv786SK44UtlvXvzcM JOm2b0OjNMR28Ep7hnhg5E2xoBxbYT34ANlvSfjbDsRQ0G635QYNFaWTvZPIVoY/0NC6 gwwHtWLY1SEP7FrTs8J2UFZqktUL9FWdCN/UZJL+FxzZXvMTXr0UlFBVBNJ/nMhg8a6Y GvMcjCvZVUOsMinYZQMsjfmbb6YTyr9PfGFAyzsE/e6+3JIRXKOxSGJ6KZElz5T79MmK Dwbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788957760; x=1789562560; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IqDBfWmpsbVcFz4ktvchUUk0YUbACLYsKQhJUiknkwc=; b=ZNuXRHcqToxqHyvi4HYu+28K6X6WGktlU7Xz6kzUs9byiM5raGMc/RBU8Q18/KRsTb H54l9I2p8vOjA572D0JSc/73dHbWWMUGCNyv+NujcAIYIpy0t6YQdCD9ZY7WkbHRYbOl yDOGG70HyN8461OlH+0MZ5Ff+ulna2fYhosZj0j1agsN2szeI6us8dmIR5k/url6qy8U XMEMVf/sWnATt1YxpRFxYVCKwXnAg30F/o5oCa+4M+T7zEf6wCNJjA+sJ8V1FTkryLXi NuDwL0ZFqArjwg24q/M0r6Sly/raNWR24NX5d18Mh1tbqBCrDY2TQ7ulDt6m/lhC7/sO 9RzA== X-Forwarded-Encrypted: i=1; AKwUvBzcJ2D8soUhuo3Bx1EM1/WnpeIFqtxpBbCVeD4vqcf8vvYKHZ1bJ+Tos7DQxDxlt9m4mGsO5leMPVJTJWU=@vger.kernel.org X-Gm-Message-State: AFuF++kbcXr8v+LUlz1R4WkG3F6AR3rPYlCrnjOpUJL3vlXo3wpmLCk2 IjFOAfcgg4DdnuUgAsxDWcrRLtmd2Wc6TkahEDeWoiVTZhbQnUTqXDMSZFcVwCnrkg+9M+w9yed vZ4+u1xaKwxa3MX6hyjnvi76kjAtMgXg3Z1PzVbW3fqFkEFCgxnLGrF5vv9sID2/IqAY= X-Gm-Gg: AYBFou1hzttwrRSuoRBtZONwR54WHhN94G/ZPcdkBLERsauRFQ0irQamlw07KsDYzZa 0DOIdsChrzLhejp4cD+rhQJFKdDqWg6Ui25gsKtJsqRHhHhVsr5oVx1PmBMzJ9LR7nvTMz+9rcN TMNvqHee7LJSh0d+D5EfQgs+wdbJ6AVpDizrqu5kpRYfrhdzvqxihqZYoSmy4iAKvdN2P5VrEgF sWYkc336+ZVIhIeEkNFqdSD5dgv4ojpBy45zkr+xwqJmcCGhUlef8WDwZp4c5as6PpNuSz4xH+m hGx/u1LR4oxjkPuUuLU7h0nohr8fJdaKAy+RDRO8O0nZMlVnGN6FTWz5/ERwbaQOFIdFy1gpeHX nmAfdDgQMraSCM38ouy+i8dwr8KYCbS/Z X-Received: by 2002:a05:6830:3592:b0:7dc:4947:36a1 with SMTP id 46e09a7af769-7fa1ff60101mr23258961a34.12.1788957760031; Wed, 09 Sep 2026 05:42:40 -0700 (PDT) X-Received: by 2002:a05:6830:3592:b0:7dc:4947:36a1 with SMTP id 46e09a7af769-7fa1ff60101mr23258934a34.12.1788957759647; Wed, 09 Sep 2026 05:42:39 -0700 (PDT) Received: from [10.218.35.45] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7fa642bc562sm17603801a34.16.2026.09.09.05.42.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Sep 2026 05:42:39 -0700 (PDT) Message-ID: Date: Wed, 9 Sep 2026 18:12:34 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 0/3] PCI: qcom: Implement shutdown() to avoid SMMU/NoC errors on reboot To: Konrad Dybcio , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260909-shutdown-v6-0-62b7bd123236@oss.qualcomm.com> <85ea66bd-65f0-4e05-9928-3cc2e23f02ff@oss.qualcomm.com> Content-Language: en-US From: Krishna Chaitanya Chundru In-Reply-To: <85ea66bd-65f0-4e05-9928-3cc2e23f02ff@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA5MDE0MiBTYWx0ZWRfX8q3TyAHdkLUj 5BIkKaYeUwBz/d0U4dGM2fwkbcw5QbgMS2H2GfUt4PGEoANdByoBhbloKQWSMEQnmavn0qfQQOh eRAndwRubgBrzfxq67YQA3XHf2X24QU= X-Authority-Analysis: v=2.4 cv=J52aKgnS c=1 sm=1 tr=0 ts=6aa15440 cx=c_pps a=7uPEO8VhqeOX8vTJ3z8K6Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=FOk9bOecH7u50CPTZhUA:9 a=QEXdDO2ut3YA:10 a=EXS-LbY8YePsIyqnH6vw:22 X-Proofpoint-ORIG-GUID: e7obO0XMzoJpeN7dj3H7PB86kmAiA1sR X-Proofpoint-GUID: e7obO0XMzoJpeN7dj3H7PB86kmAiA1sR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA5MDE0MiBTYWx0ZWRfX7To7wyOJRYG/ 1wCF7mRTQRUgUlFzW5jWMyZJg7X2Q+LKTFnKz2x2Fe3V3r4wK8Yw2FPzgoAHVp/9YEDK6eVzG4I BPGE55cZt15Btk96ph6cN7lptwsr/UplI6WxsjbZ6U9rl6sF/UwVC+plB7btkWcbEGVzVeTlZPD b3gBtVtj4H7vq/7vKZoZASqfSVPclOqqMG71/SRhv23JsbThEc2VNk6rVWU5Hzmh9RyVgCg1HbY 1yZLSjLmXasDF/PtAhMZVyC4A/4awkOIDZWVUcMVyy//kRyUPRNvMfIfRQZp8TN0xSGJB46Yj5u VmuKkvVwfx001YYuFtwVDZLOZ7+k/PPoYhQJDKO/kOfACGcNQ1dS2ALD1EMN0qcA9EKYK/aC6x/ mJ5D1lgsW5Yk+cMJM8ARXrNVbsBkJtNY9HfCNj0DJB6uMwnWTnKnHPNfhVHGvaNBgrt3DH0WII4 ScatMiQnkg0Jof6hudQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-08_03,2026-09-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 adultscore=0 malwarescore=0 suspectscore=0 impostorscore=0 bulkscore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609090142 On 9/9/2026 6:08 PM, Konrad Dybcio wrote: > On 9/9/26 2:24 PM, Krishna Chaitanya Chundru wrote: >> During system shutdown/reboot, power/clocks to the PCIe controller get >> removed regardless of link state. If the link is still up when that >> happens, it can trigger SMMU or NoC errors. >> >> This series adds a shutdown() callback to the Qualcomm PCIe host driver >> that forces the link into L2/D3cold before shutdown proceeds, reusing >> the existing suspend_noirq() path. >> >> Patch 1 fixes pci_host_common_d3cold_possible()'s underlying bus walk, >> which aborts as soon as it finds a device outside D3hot and can >> therefore miss a later PME-capable device -- something that becomes >> common once patch 3 starts forcing D3cold entry during shutdown while >> endpoints may still be in D0. >> >> Patch 2 adds a force parameter to dw_pcie_suspend_noirq() so that callers can >> set to make dw_pcie_suspend_noirq() force L2 entry during shutdown/ >> reboot, skipping the D3cold capability check that can otherwise leave >> the link up if any endpoint hasn't suspended yet. >> >> Patch 3 adds qcom_pcie_shutdown() and wires it up as .shutdown. >> >> Signed-off-by: Krishna Chaitanya Chundru >> --- >> Changes in v6: >> - remove return 0 in d3cold_possible() (konrad) > I re-read it once again and I'm not sure my comment was right.. If we return directly without checking the pme capability we might disable power to the endpoint and wake up may be broken. I taught you pointed that mistake only. we need to check pme capability even when device is not in d3hot. - Krishna Chaitanya. > > Konrad