From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8B753B6BF5 for ; Fri, 17 Apr 2026 10:31:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776421865; cv=none; b=p33qEZQSqr3S46qdd8tkOpTAefjtwtyUm5ciiJXb7zBsGj/LNxATQa+yeQkB0vsCoVVEsX8iVcMyoWLkI+3LEGMDqLddFzBuZ9Cd6+DhjKLMj3elJylm/QpNbeSDFrUfNQtkh973Klcx+ZRyTDDmPR6CS1V6zFVXgiI5E/rxoYg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776421865; c=relaxed/simple; bh=GCweCtXAwUWPovbXycTA4AU3/QkBeGAdsJflwLi+jcI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Hntly/UWOZ+MgYzb+rMAuCnERlIeikfS/MPIfc/jbeFICQVd45L7mvAmMMDTa+ZCUJwHu+Ruc82XR5nqnbeSwEsZXV7X0wQgybP1ctqycOcoIbrQfdp7kNS16R+WMje9HOQCgBXqkMCULz0S8G6Ef4wzK0sQWWl3texq1hAU8bA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ONnlxy8w; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SiwN9Y2U; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ONnlxy8w"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SiwN9Y2U" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63H82v3o1872519 for ; Fri, 17 Apr 2026 10:31:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= egCLcH6exh4Y768gVMGcYkrfeIsKeLS76r+9rfHPhec=; b=ONnlxy8wz24eqOl8 qxmPf1uN9mFaQ7lg2tA16zJSGHKJS8tWdXn+Tl11OdfRLQ7Er5oaCIGEPi32fgBY BtHnxAycP/3SeFEyujlxd9FIbsZQo5KbUs55jfnLCJrSMIWbSdEQXiwiET+Arv/g Y70eBgdMCnAcR+PQjuY3MF5xpffco+dp/vzXzmiUCTmic1oJQX3ACUCcQz0gPa+s MT36KxBLNpweynllXWCwFPmDm3CCoEFJKTkyHWxTbozIpQbqwxHJiktr/HG+Uc7b 1Dls54zVXudFP3Tw10q3jiDihsxP0kPauPjvMzVseeG5ohtBRShOg3xf3HIV3yUF AJDvjQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dk2knbmkw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Apr 2026 10:31:00 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50b4bd8e77dso1118111cf.3 for ; Fri, 17 Apr 2026 03:31:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776421860; x=1777026660; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=egCLcH6exh4Y768gVMGcYkrfeIsKeLS76r+9rfHPhec=; b=SiwN9Y2Uv6W59E8rFRmAyvoXrrpR+p6qaFcaGEL+mCsJf/XVSF+XBGLU0MuA8TBEgg SViNRZLEl1T9ldhL0LAsgzONp1ym8oqbxUoLBEK65AMGdEoqZ4rMZ3Rj0QSBARCdMZkf qEirkfnvZybLtWuMUfoKDycZvvfVZhnG5XAkji0gvk3mVliG+ug3VJK6R8J2BzsAMwnT mjGzPDnuhsfz/+0ae48sdwSnsrE45tA2p15kp3KnOUZWgj54C3GyJso7gz0EgvaGbd2g yegBgDfWR5IYVhc/G//29MzKM+3KtzTyiDdKwBdZ/r8sYga7cK930piZZwxOmPsjcUJW wWEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776421860; x=1777026660; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=egCLcH6exh4Y768gVMGcYkrfeIsKeLS76r+9rfHPhec=; b=VorqMKqlNXIcFoW9H4dCzoh+9wzpwYT4Nf1k+NbF0f5XeyhrUhcRXsk29mALpc2qP4 4RiAg3cb/FuXoywfQKa1uhPjpZN4ieU/KKdXhGRrpZa4S2RCO4mrdTLOVWMcn1ImmGC3 lWfxb93y0Ni67fO9Mcu4FlaJQCO4VancucvNVvw6u7zXsGRCIW7iMkEiwN9elGZL/sSv UOQt3rEIB2a1+QTwg2FhL8xsw9uSt3rYxaFtyYT5QgluTFVp0/7aExUXLjQrj8EdoZTD FOhfM+VA7gEhd9JavR8SKRaP+e+Uv95KwpTew7wcUg/A3q9MtrsmBfYOudtV53F+BQuv 4QhQ== X-Forwarded-Encrypted: i=1; AFNElJ+Q1+GQ9iP07rCIY52YBDWLsSwcBr1spN13x6qTk1UNA4QylsxodTP9D9d6Mwf7Xot4t1N/tkaf4VioSGA=@vger.kernel.org X-Gm-Message-State: AOJu0YwivDX2S4c8KT+mnYWJ/UsYQREi3WEIBsSnT9r5+DFO4nHp5Puj oizxmM2zHC61M1IUAxO/4ehfrbeYHWY7IAG5395iPKLL89lr3MbT2Vkdy1IE0LC4btfdupWdyj5 6VI2inIQz6+M64bmMe+bShYUkjbZz1WX4LpLslzsqY7zxc+OmBDrhnXUIXvTZN9hyUtw= X-Gm-Gg: AeBDieuC4exUTOUetiufBhAZoynN0HsPx+kOO/wSAOlgBjaKKF4DKsMU/EMaSmKzfdZ RdraPGqxNBgPWF3HbzO8NtIjriNpOYcrslURO17oScgNY0M27SBXAbWgilkEpmHaZioHGBBqlPu TW6xGhDja82LDgp6Y2wO24/wA/y1aa3w48OlDNgmB30wW0gZMGsgxs9VcPrDWiCWXKBGyY5z6Ce 4KWi2ZEMHumi80UWtOS1rH1LjHS/RUqCYKw7g9iJYaDXTPqwmND8vWyIzDiOFYJHG8cYwPIO17s q4S96A+ypJYr3JZIFELpUMvpO935HNWwVEl8wzgsrQhKyBvDT9e06gGab9g0M/j+rbJrpSWa6V1 tGqvOvqhAuRC4N1tGPUfATSMA+LvaJHwXGlSN8g8SRVWWSbbUBb/rdwvK5dW7EGIulqpITuyCto 9c9Mk6AzgPcppMeA== X-Received: by 2002:a05:622a:991:b0:509:2c6e:f6e0 with SMTP id d75a77b69052e-50e36c9d291mr17924201cf.8.1776421859914; Fri, 17 Apr 2026 03:30:59 -0700 (PDT) X-Received: by 2002:a05:622a:991:b0:509:2c6e:f6e0 with SMTP id d75a77b69052e-50e36c9d291mr17923871cf.8.1776421859400; Fri, 17 Apr 2026 03:30:59 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-672c4d6f63fsm258128a12.31.2026.04.17.03.30.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Apr 2026 03:30:57 -0700 (PDT) Message-ID: Date: Fri, 17 Apr 2026 12:30:54 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 3/4] clk: qcom: tcsrcc-glymur: Migrate tcsr_pcie_N_clkref_en to clk_ref common helper To: Manivannan Sadhasivam Cc: Qiang Yu , Bjorn Andersson , Taniya Das , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , johan@kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260331-qref_vote-v1-0-3fd7fbf87864@oss.qualcomm.com> <20260331-qref_vote-v1-3-3fd7fbf87864@oss.qualcomm.com> <3d4a12f1-a9ba-4955-b018-f1c271aab766@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: lYeAl9IlxQnS9v5SAPUweooaK1Tqsmxf X-Authority-Analysis: v=2.4 cv=XNoAjwhE c=1 sm=1 tr=0 ts=69e20be4 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=iRxhbmNlmaEF0NwQHpcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: lYeAl9IlxQnS9v5SAPUweooaK1Tqsmxf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE3MDEwNSBTYWx0ZWRfX8Oz8cAeH3v39 +eZYWuL5oSZSDCdclbtw/W13OdSF9j/oOgAAEs5cufhsn4v0gKxNAyzx2pgNC8yHfjVAjPP6WDm liAOS285TA+UBtwgGbxy/g7Anp8JZvJMufJvv0j38YTBvOZUPEMYIvXrqAKgNqXhTyGyVZxjmDR mbuj9wMGiFLHtTcmiXOpIhXWl0gjnhQ72CXqsEFzYISj+simN+9zjC18JKKiixA/9Xjt5jHMhoI L97Zm1F+otBKB8tMIlewNF+DhrgWGN8upHEZlCxx3LiiRnpQ95yezZSuBgBMxCSkF8RyICQ0hwQ WELXxxwgiXntxPRK5mGVpvBNF+gtw3Dfb5w1ptEGSx96peE2Y9relIgaz27vjjiE7MHh5kFFVQl abEmOGEMr0v3rGeGor3WOpIz5D6sxfJhj37+vWbuPeFLIQKmedKqFksVFO6GdJzuPxAWprW6g3a PR4/KeZrEMFG3dYHk0w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_04,2026-04-16_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 priorityscore=1501 suspectscore=0 spamscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604170105 On 4/17/26 11:39 AM, Manivannan Sadhasivam wrote: > On Mon, Apr 13, 2026 at 01:18:16PM +0200, Konrad Dybcio wrote: >> On 4/13/26 9:06 AM, Qiang Yu wrote: >>> On Thu, Apr 09, 2026 at 08:19:41AM -0500, Bjorn Andersson wrote: >>>> On Wed, Apr 01, 2026 at 09:47:38PM -0700, Qiang Yu wrote: >>>>> On Wed, Apr 01, 2026 at 10:05:12PM +0530, Taniya Das wrote: >>>>>> On 4/1/2026 12:05 PM, Qiang Yu wrote: >>>>>>> diff --git a/drivers/clk/qcom/tcsrcc-glymur.c b/drivers/clk/qcom/tcsrcc-glymur.c >>>> [..] >>>>>>> +static const char * const tcsr_pcie_4_regulators[] = { >>>>>>> + "vdda-refgen-0p9", >>>>>>> + "vdda-refgen-1p2", >>>>>>> + "vdda-qreftx1-0p9", >>>>>>> + "vdda-qrefrpt0-0p9", >>>>>>> + "vdda-qrefrpt1-0p9", >>>>>>> + "vdda-qrefrpt2-0p9", >>>>>>> + "vdda-qrefrx2-0p9", >>>>>>> +}; >>>>>>> + >>>>>> >>>>>> TCSR clock refs are just not for PCIe alone, they would have supplies >>>>>> for all the ref clocks. These supplies can also be shared across other >>>>>> clock refs. I think it is not the correct way to handle the supplies, as >>>>>> TCSR does not have the complete supplies map. >>>>>> >>>>> We have complete supplies map. You can get it on ipcatlog. Here is example >>>>> for other instances eg USB and EDP: >>>>> - Glymur (eDP): CXO PAD -> TX0 -> RPT0 -> RX0 -> eDP >>>>> - Glymur (USB4_2): CXO PAD -> TX0 -> RPT0 -> RPT1 -> RX1 -> USB4_2 >>>>> - Glymur (USB3): CXO PAD -> TX0 -> RPT3 -> RPT4 -> RX4 -> USB3_SS3 >>>>> >>>>> I only add supplies for PCIe in this series because USB and EDP vote these >>>>> LDO in their PHY driver. They can remove them in PHY dts node and add same >>>>> regulator list here. >>>>> >>>> >>>> The regulators are reference counted. Can't we add the USB and eDP >>>> handling here as well now, and then after they are voted here we remove >>>> them from the PHY? >>>> >>> >>> For USB, I’m not yet sure which tcsr_*_clkref_en each USB instance in the >>> QREF diagram is tied to. I need to confirm that mapping first, I'm >>> checking with Wesley Cheng. >> >> I think on at least some platforms the reference clock for the primary >> USB controller is not sw-controllable (so we wouldn't get a handle to >> toggle the regulator this way).. please check that >> > > I would suggest we move forward with atleast PCIe regulators for now. Since USB > and eDP are voting for these regulators on their own, we can work with relevant > teams later to switch to this model and this is not going to cause any > regression for them. I think we can do that, yeah Konrad