From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754141AbeDWGnh (ORCPT ); Mon, 23 Apr 2018 02:43:37 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:36397 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753018AbeDWGnd (ORCPT ); Mon, 23 Apr 2018 02:43:33 -0400 Subject: Re: [PATCH] phy: exynos-mipi-video: Simplify code by using regmap_update_bits() To: Sylwester Nawrocki References: <20180416161938.26958-1-s.nawrocki@samsung.com> CC: , , , , From: Kishon Vijay Abraham I Message-ID: Date: Mon, 23 Apr 2018 12:13:26 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20180416161938.26958-1-s.nawrocki@samsung.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 16 April 2018 09:49 PM, Sylwester Nawrocki wrote: > There is no functional change, just replacing regmap_read()/modify/ > regmap_write() with regmap_update_bits() function calls. merged, thanks! -Kishon > > Signed-off-by: Sylwester Nawrocki > --- > drivers/phy/samsung/phy-exynos-mipi-video.c | 34 ++++++++++++----------------- > 1 file changed, 14 insertions(+), 20 deletions(-) > > diff --git a/drivers/phy/samsung/phy-exynos-mipi-video.c b/drivers/phy/samsung/phy-exynos-mipi-video.c > index c198886f80a3..00d89599c67d 100644 > --- a/drivers/phy/samsung/phy-exynos-mipi-video.c > +++ b/drivers/phy/samsung/phy-exynos-mipi-video.c > @@ -231,33 +231,27 @@ struct exynos_mipi_video_phy { > static int __set_phy_state(const struct exynos_mipi_phy_desc *data, > struct exynos_mipi_video_phy *state, unsigned int on) > { > - u32 val; > + struct regmap *enable_map = state->regmaps[data->enable_map]; > + struct regmap *resetn_map = state->regmaps[data->resetn_map]; > > spin_lock(&state->slock); > > /* disable in PMU sysreg */ > if (!on && data->coupled_phy_id >= 0 && > - state->phys[data->coupled_phy_id].phy->power_count == 0) { > - regmap_read(state->regmaps[data->enable_map], data->enable_reg, > - &val); > - val &= ~data->enable_val; > - regmap_write(state->regmaps[data->enable_map], data->enable_reg, > - val); > - } > - > + state->phys[data->coupled_phy_id].phy->power_count == 0) > + regmap_update_bits(enable_map, data->enable_reg, > + data->enable_val, 0); > /* PHY reset */ > - regmap_read(state->regmaps[data->resetn_map], data->resetn_reg, &val); > - val = on ? (val | data->resetn_val) : (val & ~data->resetn_val); > - regmap_write(state->regmaps[data->resetn_map], data->resetn_reg, val); > - > + if (on) > + regmap_update_bits(resetn_map, data->resetn_reg, > + data->resetn_val, data->resetn_val); > + else > + regmap_update_bits(resetn_map, data->resetn_reg, > + data->resetn_val, 0); > /* enable in PMU sysreg */ > - if (on) { > - regmap_read(state->regmaps[data->enable_map], data->enable_reg, > - &val); > - val |= data->enable_val; > - regmap_write(state->regmaps[data->enable_map], data->enable_reg, > - val); > - } > + if (on) > + regmap_update_bits(enable_map, data->enable_reg, > + data->enable_val, data->enable_val); > > spin_unlock(&state->slock); > >